[libvirt] [PATCH] make distclean: remove generated source files
"make distcheck" is failing because two generated source files are left behind. It requires that all generated files be removed. This fixes it:
From a7f4c47140ed0e585f1135e0f7917bc32f145997 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Mon, 4 Aug 2008 16:10:03 +0200 Subject: [PATCH] make distclean: remove generated source files
* src/Makefile.am (DISTCLEANFILES): Define to $(BUILT_SOURCES) so "make distcheck" passes. --- src/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 556ad0a..5d238cd 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -189,3 +189,4 @@ install-exec-local: $(MKDIR_P) $(DESTDIR)$(localstatedir)/cache/libvirt CLEANFILES = *.gcov .libs/*.gcda .libs/*.gcno *.gcno *.gcda +DISTCLEANFILES = $(BUILT_SOURCES) -- 1.6.0.rc1.36.g5ff70
On Mon, Aug 04, 2008 at 04:24:55PM +0200, Jim Meyering wrote:
"make distcheck" is failing because two generated source files are left behind. It requires that all generated files be removed. This fixes it:
looks fine to me, +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Mon, Aug 04, 2008 at 04:24:55PM +0200, Jim Meyering wrote:
--- a/src/Makefile.am +++ b/src/Makefile.am @@ -189,3 +189,4 @@ install-exec-local: $(MKDIR_P) $(DESTDIR)$(localstatedir)/cache/libvirt
CLEANFILES = *.gcov .libs/*.gcda .libs/*.gcno *.gcno *.gcda +DISTCLEANFILES = $(BUILT_SOURCES)
Ooops, that'd be my fault then. +1. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
"Richard W.M. Jones" <rjones@redhat.com> wrote:
On Mon, Aug 04, 2008 at 04:24:55PM +0200, Jim Meyering wrote:
--- a/src/Makefile.am +++ b/src/Makefile.am @@ -189,3 +189,4 @@ install-exec-local: $(MKDIR_P) $(DESTDIR)$(localstatedir)/cache/libvirt
CLEANFILES = *.gcov .libs/*.gcda .libs/*.gcno *.gcno *.gcda +DISTCLEANFILES = $(BUILT_SOURCES)
Ooops, that'd be my fault then.
Nah. blame the reviewer (me) ;-) I've committed the fix.
participants (3)
-
Daniel Veillard -
Jim Meyering -
Richard W.M. Jones