[libvirt] [PATCH] qemu: Fix augeas support for migration ports

Commit e3ef20d7 allows user to configure migration ports range via qemu.conf. However, it forgot to update augeas definition file and even the test data was malicious. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- Pushed under trivial and build breaker rules. src/qemu/libvirtd_qemu.aug | 2 ++ src/qemu/test_libvirtd_qemu.aug.in | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index 93a2a29..a9ff421 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -82,6 +82,8 @@ module Libvirtd_qemu = | int_entry "keepalive_count" let network_entry = str_entry "migration_address" + | int_entry "migration_port_min" + | int_entry "migration_port_max" (* Each entry in the config is one of the following ... *) let entry = vnc_entry diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in index 8f4b3a9..81fedd6 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -70,5 +70,5 @@ module Test_libvirtd_qemu = { "keepalive_count" = "5" } { "seccomp_sandbox" = "1" } { "migration_address" = "127.0.0.1" } -{ "migration_port_min" = "1234" } -{ "migration_port_max" = "12345" } +{ "migration_port_min" = "49152" } +{ "migration_port_max" = "49215" } -- 1.8.1.5

On Fri, Oct 18, 2013 at 18:31:27 +0200, Michal Privoznik wrote:
Commit e3ef20d7 allows user to configure migration ports range via qemu.conf. However, it forgot to update augeas definition file and even the test data was malicious.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> ---
Pushed under trivial and build breaker rules.
src/qemu/libvirtd_qemu.aug | 2 ++ src/qemu/test_libvirtd_qemu.aug.in | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-)
Oops, I used make -C tests check rather than make check and it of course skipped augeas checks :/ And I was wondering why the build didn't fail when I changed the config file. Thanks for fixing this. Jirka
participants (2)
-
Jiri Denemark
-
Michal Privoznik