[libvirt] [PATCH] build: fix mingw build of vbox
More fallout from commit 7c9a2d88 dropping too many headers. Fixes: In file included from ../../src/vbox/vbox_glue.c:26:0: ../../src/vbox/vbox_MSCOMGlue.c: In function 'vboxLookupVersionInRegistry': ../../src/vbox/vbox_MSCOMGlue.c:435:5: error: implicit declaration of function 'virParseVersionString' [-Werror=implicit-function-declaration] ... ../../src/vbox/vbox_driver.c: In function 'vboxConnectOpen': ../../src/vbox/vbox_driver.c:147:5: error: implicit declaration of function 'getuid' [-Werror=implicit-function-declaration] ../../src/vbox/vbox_driver.c:147:5: error: nested extern declaration of 'getuid' [-Werror=nested-externs] * src/vbox/vbox_MSCOMGlue.c (includes): Add missing includes. * src/vbox/vbox_driver.c (includes): Likewise. Signed-off-by: Eric Blake <eblake@redhat.com> --- Pushing under the build-breaker rule. 1.0.5 is immune. src/vbox/vbox_MSCOMGlue.c | 3 +++ src/vbox/vbox_driver.c | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/vbox/vbox_MSCOMGlue.c b/src/vbox/vbox_MSCOMGlue.c index 6cebfaf..706f1ba 100644 --- a/src/vbox/vbox_MSCOMGlue.c +++ b/src/vbox/vbox_MSCOMGlue.c @@ -2,6 +2,7 @@ /* * vbox_MSCOMGlue.c: glue to the MSCOM based VirtualBox API * + * Copyright (C) 2013 Red Hat, Inc. * Copyright (C) 2010-2011 Matthias Bolte <matthias.bolte@googlemail.com> * * This library is free software; you can redistribute it and/or @@ -33,6 +34,8 @@ #include "viralloc.h" #include "virlog.h" #include "virerror.h" +#include "virstring.h" +#include "virutil.h" #include "vbox_MSCOMGlue.h" #define VIR_FROM_THIS VIR_FROM_VBOX diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c index 30721fd..5dfaf1c 100644 --- a/src/vbox/vbox_driver.c +++ b/src/vbox/vbox_driver.c @@ -3,7 +3,7 @@ */ /* - * Copyright (C) 2010-2012 Red Hat, Inc. + * Copyright (C) 2010-2013 Red Hat, Inc. * Copyright (C) 2008-2009 Sun Microsystems, Inc. * * This file is part of a free software library; you can redistribute @@ -38,6 +38,7 @@ #include "vbox_driver.h" #include "vbox_glue.h" #include "virerror.h" +#include "virutil.h" #define VIR_FROM_THIS VIR_FROM_VBOX -- 1.8.1.4
Following build error caused by commit 7c9a2d88: libvirt.c: In function 'virConnectGetConfigFilePath': libvirt.c:956:9: error: implicit declaration of function 'virGetUserConfigDirectory' [-Werror=implicit-function-declaration] libvirt.c:956:9: error: nested extern declaration of 'virGetUserConfigDirectory' [-Werror=nested-externs] libvirt.c:956:25: error: initialization makes pointer from integer without a cast [-Werror] libvirt.c: In function 'virConnectGetConfigFile': libvirt.c:987:5: error: implicit declaration of function 'virFileExists' [-Werror=implicit-function-declaration] libvirt.c:987:5: error: nested extern declaration of 'virFileExists' [-Werror=nested-externs] libvirt.c: In function 'virDomainSave': libvirt.c:2623:9: error: implicit declaration of function 'virFileAbsPath' [-Werror=implicit-function-declaration] libvirt.c:2623:9: error: nested extern declaration of 'virFileAbsPath' [-Werror=nested-externs] Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- src/libvirt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt.c b/src/libvirt.c index 15b37a3..467f6dd 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -63,6 +63,7 @@ #include "viruri.h" #include "virthread.h" #include "virstring.h" +#include "virutil.h" #ifdef WITH_TEST # include "test/test_driver.h" -- 1.8.1.4
On 05/02/2013 09:44 PM, Hu Tao wrote:
Following build error caused by commit 7c9a2d88:
libvirt.c: In function 'virConnectGetConfigFilePath': libvirt.c:956:9: error: implicit declaration of function 'virGetUserConfigDirectory' [-Werror=implicit-function-declaration]
+++ b/src/libvirt.c @@ -63,6 +63,7 @@ #include "viruri.h" #include "virthread.h" #include "virstring.h" +#include "virutil.h"
This was already fixed in commit 348ac061. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Thu, May 02, 2013 at 10:08:11PM -0600, Eric Blake wrote:
On 05/02/2013 09:44 PM, Hu Tao wrote:
Following build error caused by commit 7c9a2d88:
libvirt.c: In function 'virConnectGetConfigFilePath': libvirt.c:956:9: error: implicit declaration of function 'virGetUserConfigDirectory' [-Werror=implicit-function-declaration]
+++ b/src/libvirt.c @@ -63,6 +63,7 @@ #include "viruri.h" #include "virthread.h" #include "virstring.h" +#include "virutil.h"
This was already fixed in commit 348ac061.
Sorry, didn't notice that one(my git server has some latency).
participants (2)
-
Eric Blake -
Hu Tao