[libvirt-go-xml PATCH 0/2] Switch CI from Travis to GitLab
Daniel P. Berrangé (2): gitlab: add CI definition for GitLab travis: delete CI configuration .gitlab-ci.yml | 25 +++++++++++++++++++++++++ .travis.yml | 13 ------------- README.md | 2 +- 3 files changed, 26 insertions(+), 14 deletions(-) create mode 100644 .gitlab-ci.yml delete mode 100644 .travis.yml -- 2.24.1
We want to test against a variety of Go versions to validate that there are not any incompatibilities in XML parser handling between versions. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- .gitlab-ci.yml | 25 +++++++++++++++++++++++++ README.md | 2 +- 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 .gitlab-ci.yml diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index 0000000..f19d240 --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,25 @@ + +.go_build: &go_build + script: + - go test -timeout 10m -tags xmlroundtrip -v + + +go_1_10: + <<: *go_build + image: golang:1.10 + +go_1_11: + <<: *go_build + image: golang:1.11 + +go_1_12: + <<: *go_build + image: golang:1.12 + +go_1_13: + <<: *go_build + image: golang:1.13 + +go_1_14: + <<: *go_build + image: golang:1.14 diff --git a/README.md b/README.md index fcc1ffb..9e39190 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# libvirt-go-xml [](https://travis-ci.org/libvirt/libvirt-go-xml) [](https://godoc.org/libvirt.org/libvirt-go-xml) +# libvirt-go-xml [](https://gitlab.com/berrange/libvirt-go-xml/-/commits/master) [](https://godoc.org/libvirt.org/libvirt-go-xml) Go API for manipulating libvirt XML documents -- 2.24.1
On Tue, 2020-03-31 at 14:34 +0100, Daniel P. Berrangé wrote:
+++ b/README.md @@ -1,4 +1,4 @@ -# libvirt-go-xml [](https://travis-ci.org/libvirt/libvirt-go-xml) [](https://godoc.org/libvirt.org/libvirt-go-xml) +# libvirt-go-xml [](https://gitlab.com/berrange/libvirt-go-xml/-/commits/master) [](https://godoc.org/libvirt.org/libvirt-go-xml)
s/berrange/libvirt/g ;) Also, wouldn't https://gitlab.com/libvirt/libvirt-go-xml/pipelines be a better location to send people who click on the pipeline status image? With at least the first issue addressed, Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
On Tue, Apr 07, 2020 at 04:38:39PM +0200, Andrea Bolognani wrote:
On Tue, 2020-03-31 at 14:34 +0100, Daniel P. Berrangé wrote:
+++ b/README.md @@ -1,4 +1,4 @@ -# libvirt-go-xml [](https://travis-ci.org/libvirt/libvirt-go-xml) [](https://godoc.org/libvirt.org/libvirt-go-xml) +# libvirt-go-xml [](https://gitlab.com/berrange/libvirt-go-xml/-/commits/master) [](https://godoc.org/libvirt.org/libvirt-go-xml)
s/berrange/libvirt/g ;)
Heh, that's what comes from copying the code snippet from the gitlab admin page
Also, wouldn't
https://gitlab.com/libvirt/libvirt-go-xml/pipelines
be a better location to send people who click on the pipeline status image?
This is just copied from the recommended badge snippet that gitlab displays in the "Settings -> CI -> General Pipelines" page. Not sure why they think sending to the commits page is better, but yeah, it seems more useful to go the pipelines page. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
We are standardizing on GitLab, so no longer need to run CI tests on Travis. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- .travis.yml | 13 ------------- 1 file changed, 13 deletions(-) delete mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index f3396ba..0000000 --- a/.travis.yml +++ /dev/null @@ -1,13 +0,0 @@ -language: go -os: linux -dist: trusty - -go: - - 1.5 - - 1.6 - - 1.7 - - 1.8 - - 1.9 - -script: - go test -timeout 10m -tags xmlroundtrip -v -- 2.24.1
On Tue, 2020-03-31 at 14:34 +0100, Daniel P. Berrangé wrote:
We are standardizing on GitLab, so no longer need to run CI tests on Travis.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- .travis.yml | 13 ------------- 1 file changed, 13 deletions(-) delete mode 100644 .travis.yml
Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Daniel P. Berrangé