[libvirt] [PATCH] Ensure stream is aborted when exiting console
From: "Daniel P. Berrange" <berrange@redhat.com> After running 'virsh console' in interactive mode, there was a missing call to virStreamAbort, which meant the server kept the stream resources open * tools/console.c: Abort stream when exiting --- tools/console.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/console.c b/tools/console.c index 171ebc9..82ef537 100644 --- a/tools/console.c +++ b/tools/console.c @@ -90,9 +90,11 @@ static void virConsoleShutdown(virConsolePtr con) { con->quit = true; - virStreamEventRemoveCallback(con->st); - if (con->st) + if (con->st) { + virStreamEventRemoveCallback(con->st); + virStreamAbort(con->st); virStreamFree(con->st); + } if (con->stdinWatch != -1) virEventRemoveHandle(con->stdinWatch); if (con->stdoutWatch != -1) -- 1.7.6
On 08/15/2011 11:12 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange@redhat.com>
After running 'virsh console' in interactive mode, there was a missing call to virStreamAbort, which meant the server kept the stream resources open
* tools/console.c: Abort stream when exiting --- tools/console.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/console.c b/tools/console.c index 171ebc9..82ef537 100644 --- a/tools/console.c +++ b/tools/console.c @@ -90,9 +90,11 @@ static void virConsoleShutdown(virConsolePtr con) { con->quit = true; - virStreamEventRemoveCallback(con->st); - if (con->st) + if (con->st) { + virStreamEventRemoveCallback(con->st); + virStreamAbort(con->st); virStreamFree(con->st); + }
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On Mon, Aug 15, 2011 at 10:12:54AM -0700, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
After running 'virsh console' in interactive mode, there was a missing call to virStreamAbort, which meant the server kept the stream resources open
The combination of this patch and the other stream related patch makes the problem I was seeing of garbled console following multiple console connect/disconnects go away, but another problem remains in this area. After connecting to the console in interactive virsh and disconnecting, I often see all subsequent commands fail: virsh # dominfo foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown virsh # dominfo foo error: failed to get domain 'foo' error: no call waiting for reply with prog 536903814 vers 1 serial 300 virsh # define bar.xml error: Failed to define domain from bar.xml error: no call waiting for reply with prog 536903814 vers 1 serial 301 Closing and reopening the interactive virsh session makes the problem go away. Powering down the guest while the console is connected has made the problem 100% reproducible in the 4 or 5 tries I've given it. Dave
* tools/console.c: Abort stream when exiting --- tools/console.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/console.c b/tools/console.c index 171ebc9..82ef537 100644 --- a/tools/console.c +++ b/tools/console.c @@ -90,9 +90,11 @@ static void virConsoleShutdown(virConsolePtr con) { con->quit = true; - virStreamEventRemoveCallback(con->st); - if (con->st) + if (con->st) { + virStreamEventRemoveCallback(con->st); + virStreamAbort(con->st); virStreamFree(con->st); + } if (con->stdinWatch != -1) virEventRemoveHandle(con->stdinWatch); if (con->stdoutWatch != -1) -- 1.7.6
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Aug 15, 2011 at 02:19:27PM -0400, Dave Allan wrote:
On Mon, Aug 15, 2011 at 10:12:54AM -0700, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
After running 'virsh console' in interactive mode, there was a missing call to virStreamAbort, which meant the server kept the stream resources open
The combination of this patch and the other stream related patch makes the problem I was seeing of garbled console following multiple console connect/disconnects go away, but another problem remains in this area. After connecting to the console in interactive virsh and disconnecting, I often see all subsequent commands fail:
virsh # dominfo foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown
virsh # dominfo foo error: failed to get domain 'foo' error: no call waiting for reply with prog 536903814 vers 1 serial 300
virsh # define bar.xml error: Failed to define domain from bar.xml error: no call waiting for reply with prog 536903814 vers 1 serial 301
Closing and reopening the interactive virsh session makes the problem go away.
Powering down the guest while the console is connected has made the problem 100% reproducible in the 4 or 5 tries I've given it.
Yeah this is a regression. We were accidentally sending back two stream abort RPC packets in some scenarios (with race condition). I've posted a patch to fix it Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Tue, Aug 16, 2011 at 11:15:04AM -0700, Daniel P. Berrange wrote:
On Mon, Aug 15, 2011 at 02:19:27PM -0400, Dave Allan wrote:
On Mon, Aug 15, 2011 at 10:12:54AM -0700, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
After running 'virsh console' in interactive mode, there was a missing call to virStreamAbort, which meant the server kept the stream resources open
The combination of this patch and the other stream related patch makes the problem I was seeing of garbled console following multiple console connect/disconnects go away, but another problem remains in this area. After connecting to the console in interactive virsh and disconnecting, I often see all subsequent commands fail:
virsh # dominfo foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown
virsh # dominfo foo error: failed to get domain 'foo' error: no call waiting for reply with prog 536903814 vers 1 serial 300
virsh # define bar.xml error: Failed to define domain from bar.xml error: no call waiting for reply with prog 536903814 vers 1 serial 301
Closing and reopening the interactive virsh session makes the problem go away.
Powering down the guest while the console is connected has made the problem 100% reproducible in the 4 or 5 tries I've given it.
Yeah this is a regression. We were accidentally sending back two stream abort RPC packets in some scenarios (with race condition).
I've posted a patch to fix it
It does indeed fix the failure on domain shutdown, but there is still a problem related to high volumes of console output. If I get on the console and execute: while true ; do echo -n "The quick brown fox jumped over the lazy dogs. The quick brown fox jumped over the lazy dogs. "; done and exit the console while the output is spraying, I still see a failure: the lazy dogs. The quick brown fox jumped over the lazy dogs. The quick brown fox jumped over t virsh # console foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown virsh # console foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown virsh # console foo error: failed to get domain 'foo' error: no call waiting for reply with prog 536903814 vers 1 serial 6 virsh # BTW, I noticed this first when exiting the console while boot messages were being output; I'm not *trying* to break it, and many thanks for looking into all this. :) Dave
On Tue, Aug 16, 2011 at 02:52:07PM -0400, Dave Allan wrote:
On Tue, Aug 16, 2011 at 11:15:04AM -0700, Daniel P. Berrange wrote:
On Mon, Aug 15, 2011 at 02:19:27PM -0400, Dave Allan wrote:
On Mon, Aug 15, 2011 at 10:12:54AM -0700, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
After running 'virsh console' in interactive mode, there was a missing call to virStreamAbort, which meant the server kept the stream resources open
The combination of this patch and the other stream related patch makes the problem I was seeing of garbled console following multiple console connect/disconnects go away, but another problem remains in this area. After connecting to the console in interactive virsh and disconnecting, I often see all subsequent commands fail:
virsh # dominfo foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown
virsh # dominfo foo error: failed to get domain 'foo' error: no call waiting for reply with prog 536903814 vers 1 serial 300
virsh # define bar.xml error: Failed to define domain from bar.xml error: no call waiting for reply with prog 536903814 vers 1 serial 301
Closing and reopening the interactive virsh session makes the problem go away.
Powering down the guest while the console is connected has made the problem 100% reproducible in the 4 or 5 tries I've given it.
Yeah this is a regression. We were accidentally sending back two stream abort RPC packets in some scenarios (with race condition).
I've posted a patch to fix it
It does indeed fix the failure on domain shutdown, but there is still a problem related to high volumes of console output. If I get on the console and execute:
while true ; do echo -n "The quick brown fox jumped over the lazy dogs. The quick brown fox jumped over the lazy dogs. "; done
and exit the console while the output is spraying, I still see a failure:
the lazy dogs. The quick brown fox jumped over the lazy dogs. The quick brown fox jumped over t virsh # console foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown
virsh # console foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown
virsh # console foo error: failed to get domain 'foo' error: no call waiting for reply with prog 536903814 vers 1 serial 6
virsh #
BTW, I noticed this first when exiting the console while boot messages were being output; I'm not *trying* to break it, and many thanks for looking into all this. :)
This time i found a bug that pre-dated my RPC refactoring :-) Sent 2 more patches.... Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Tue, Aug 16, 2011 at 04:26:03PM -0700, Daniel P. Berrange wrote:
On Tue, Aug 16, 2011 at 02:52:07PM -0400, Dave Allan wrote:
On Tue, Aug 16, 2011 at 11:15:04AM -0700, Daniel P. Berrange wrote:
On Mon, Aug 15, 2011 at 02:19:27PM -0400, Dave Allan wrote:
On Mon, Aug 15, 2011 at 10:12:54AM -0700, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
After running 'virsh console' in interactive mode, there was a missing call to virStreamAbort, which meant the server kept the stream resources open
The combination of this patch and the other stream related patch makes the problem I was seeing of garbled console following multiple console connect/disconnects go away, but another problem remains in this area. After connecting to the console in interactive virsh and disconnecting, I often see all subsequent commands fail:
virsh # dominfo foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown
virsh # dominfo foo error: failed to get domain 'foo' error: no call waiting for reply with prog 536903814 vers 1 serial 300
virsh # define bar.xml error: Failed to define domain from bar.xml error: no call waiting for reply with prog 536903814 vers 1 serial 301
Closing and reopening the interactive virsh session makes the problem go away.
Powering down the guest while the console is connected has made the problem 100% reproducible in the 4 or 5 tries I've given it.
Yeah this is a regression. We were accidentally sending back two stream abort RPC packets in some scenarios (with race condition).
I've posted a patch to fix it
It does indeed fix the failure on domain shutdown, but there is still a problem related to high volumes of console output. If I get on the console and execute:
while true ; do echo -n "The quick brown fox jumped over the lazy dogs. The quick brown fox jumped over the lazy dogs. "; done
and exit the console while the output is spraying, I still see a failure:
the lazy dogs. The quick brown fox jumped over the lazy dogs. The quick brown fox jumped over t virsh # console foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown
virsh # console foo error: failed to get domain 'foo' error: An error occurred, but the cause is unknown
virsh # console foo error: failed to get domain 'foo' error: no call waiting for reply with prog 536903814 vers 1 serial 6
virsh #
BTW, I noticed this first when exiting the console while boot messages were being output; I'm not *trying* to break it, and many thanks for looking into all this. :)
This time i found a bug that pre-dated my RPC refactoring :-)
Sent 2 more patches....
Ok, that makes everything work much better, with one smaller problem remaining: if there is output flowing to the console at the time that I connect, I usually don't see it until I've sent input to the console, at which point it starts flowing. Often on the first connection to the console output will start flowing immediately, but subsequent connections within a single virsh session will not show output until input is sent. Occasionaly output will start after 10 or 15 seconds, but at other times I've let it sit over a minute with no output. Sending input always resumes the output. Dave
participants (3)
-
Daniel P. Berrange -
Dave Allan -
Eric Blake