[libvirt] [PATCH] Put virt-sanlock-cleanup into section 8
as indicates by the filename. --- tools/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 1dac7c1..644a86d 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -99,7 +99,8 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile || (rm $@ && exit 1) && chmod +x $@ virt-sanlock-cleanup.8: virt-sanlock-cleanup.in $(top_srcdir)/configure.ac - $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP $< $(srcdir)/$@ \ + $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP --section=8 \ + $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi -- 1.8.3.1
On 07/02/2013 03:36 PM, Guido Günther wrote:
as indicates by the filename.
s/indicates/indicated/
--- tools/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am index 1dac7c1..644a86d 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -99,7 +99,8 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile || (rm $@ && exit 1) && chmod +x $@
virt-sanlock-cleanup.8: virt-sanlock-cleanup.in $(top_srcdir)/configure.ac - $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP $< $(srcdir)/$@ \ + $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP --section=8 \ + $< $(srcdir)/$@ \
It would be nice if pod2man could auto-detect --section based on its destination argument name (hmm, the man page says it already does just that for .pm files, but not for .8). But as we must operate with existing software rather than waiting for a new pod2man, your patch makes sense. I didn't check if RHEL 5's pod2man supports the option, but I guess I'll deal with any followup patches if I later run into problems attempting 'make dist' from a RHEL 5 box. Looks like daemon/Makefile.am needs the same tweak for libvirtd.8. ACK if you fix that one too. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Hi Eric, On Tue, Jul 02, 2013 at 03:48:04PM -0600, Eric Blake wrote:
On 07/02/2013 03:36 PM, Guido Günther wrote:
as indicates by the filename.
s/indicates/indicated/
--- tools/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am index 1dac7c1..644a86d 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -99,7 +99,8 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile || (rm $@ && exit 1) && chmod +x $@
virt-sanlock-cleanup.8: virt-sanlock-cleanup.in $(top_srcdir)/configure.ac - $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP $< $(srcdir)/$@ \ + $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP --section=8 \ + $< $(srcdir)/$@ \
It would be nice if pod2man could auto-detect --section based on its destination argument name (hmm, the man page says it already does just that for .pm files, but not for .8). But as we must operate with existing software rather than waiting for a new pod2man, your patch makes sense. I didn't check if RHEL 5's pod2man supports the option, but I guess I'll deal with any followup patches if I later run into problems attempting 'make dist' from a RHEL 5 box.
Looks like daemon/Makefile.am needs the same tweak for libvirtd.8.
Since libvirtd.8.in in processed by sed and not pod2man it doesn't need any additional tweaks. Or am I missing something? It's only the reference inside virt-sanlock-cleanup's manpage that's wrong. It states it's virt-sanlock-cleanup(1) while it's virt-sanlock-cleanup(8). So o.k. to push with only the s/indicates/indicated/ fixed? Cheers, -- Guido
On 07/03/2013 07:11 AM, Guido Günther wrote:
Looks like daemon/Makefile.am needs the same tweak for libvirtd.8.
Since libvirtd.8.in in processed by sed and not pod2man it doesn't need any additional tweaks. Or am I missing something?
Huh, you're right. I just checked 'man virt-sanlock-cleanup' and 'man libvirtd' on my system, and libvirtd already claimed section 8. I'm not sure what the difference is that libvirtd already did it right.
It's only the reference inside virt-sanlock-cleanup's manpage that's wrong. It states it's virt-sanlock-cleanup(1) while it's virt-sanlock-cleanup(8).
So o.k. to push with only the s/indicates/indicated/ fixed?
Yes. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Wed, Jul 03, 2013 at 07:17:37AM -0600, Eric Blake wrote:
On 07/03/2013 07:11 AM, Guido Günther wrote:
Looks like daemon/Makefile.am needs the same tweak for libvirtd.8.
Since libvirtd.8.in in processed by sed and not pod2man it doesn't need any additional tweaks. Or am I missing something?
Huh, you're right. I just checked 'man virt-sanlock-cleanup' and 'man libvirtd' on my system, and libvirtd already claimed section 8. I'm not sure what the difference is that libvirtd already did it right.
Its makefile.am already adds '-s 8' to pod2man flags Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Wed, Jul 03, 2013 at 07:17:37AM -0600, Eric Blake wrote:
On 07/03/2013 07:11 AM, Guido Günther wrote:
Looks like daemon/Makefile.am needs the same tweak for libvirtd.8.
Since libvirtd.8.in in processed by sed and not pod2man it doesn't need any additional tweaks. Or am I missing something?
Huh, you're right. I just checked 'man virt-sanlock-cleanup' and 'man libvirtd' on my system, and libvirtd already claimed section 8. I'm not sure what the difference is that libvirtd already did it right.
It's only the reference inside virt-sanlock-cleanup's manpage that's wrong. It states it's virt-sanlock-cleanup(1) while it's virt-sanlock-cleanup(8).
So o.k. to push with only the s/indicates/indicated/ fixed?
Yes.
Pushed. Thanks. -- Guido
participants (3)
-
Daniel P. Berrange -
Eric Blake -
Guido Günther