[libvirt] [PATCH] build: force -Werror for distcheck target
The 'make distcheck' target validates that a tarball builds and is ready for release. We expect that libvirt builds cleanly on all supported platforms, so we should be enabling -Werror when running distcheck. This ensures that our CI systems in turn also use -Werror. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile.am b/Makefile.am index 2cc4b91f9c..1a9f3af66d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -19,6 +19,10 @@ LCOV = lcov GENHTML = genhtml +# when building from tarball -Werror isn't auto enabled +# so force it explicitly +DISTCHECK_CONFIGURE_FLAGS = --enable-werror + SUBDIRS = . gnulib/lib include/libvirt src tools docs gnulib/tests \ tests po examples -- 2.21.0
On Mon, Oct 7, 2019 at 4:16 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
The 'make distcheck' target validates that a tarball builds and is ready for release. We expect that libvirt builds cleanly on all supported platforms, so we should be enabling -Werror when running distcheck.
This ensures that our CI systems in turn also use -Werror.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- Makefile.am | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Makefile.am b/Makefile.am index 2cc4b91f9c..1a9f3af66d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -19,6 +19,10 @@ LCOV = lcov GENHTML = genhtml
+# when building from tarball -Werror isn't auto enabled +# so force it explicitly +DISTCHECK_CONFIGURE_FLAGS = --enable-werror + SUBDIRS = . gnulib/lib include/libvirt src tools docs gnulib/tests \ tests po examples
-- 2.21.0
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
participants (2)
-
Daniel P. Berrangé -
Fabiano Fidêncio