[libvirt] [PATCH] remove daemon/probes.h from .gitignore
The file daemon/probes.h used to be generated as part of a build, but is no longer used. However, a stale copy of it lying around could cause a build to fail. Removing it from .gitignore will make it more likely someone will notice that they have it lying around. --- Although this is a very simple change, I haven't used the trivial rule to push it, just to make sure everyone notices it, and nobody accidentally adds the file to git with "git add .". .gitignore | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/.gitignore b/.gitignore index 264a419..b35e863 100644 --- a/.gitignore +++ b/.gitignore @@ -54,7 +54,6 @@ /daemon/libvirtd.8 /daemon/libvirtd.8.in /daemon/libvirtd.pod -/daemon/probes.h /docs/devhelp/libvirt.devhelp /docs/hvsupport.html.in /docs/libvirt-api.xml -- 1.7.7.6
On 03/08/2012 02:53 PM, Laine Stump wrote:
The file daemon/probes.h used to be generated as part of a build, but is no longer used. However, a stale copy of it lying around could cause a build to fail. Removing it from .gitignore will make it more likely someone will notice that they have it lying around. ---
Although this is a very simple change, I haven't used the trivial rule to push it, just to make sure everyone notices it, and nobody accidentally adds the file to git with "git add .".
If you have a long-lived tree, or plan on swapping to old commits prior to the point where we renamed things, I recommend doing: echo /daemon/probes.h >> .git/info/exclude then you will be immune from 'git add .' accidentally re-adding it. Fresh checkouts are immune, and with this message serving as notice, I think we're okay. ACK. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 03/08/2012 04:59 PM, Eric Blake wrote:
On 03/08/2012 02:53 PM, Laine Stump wrote:
The file daemon/probes.h used to be generated as part of a build, but is no longer used. However, a stale copy of it lying around could cause a build to fail. Removing it from .gitignore will make it more likely someone will notice that they have it lying around. ---
Although this is a very simple change, I haven't used the trivial rule to push it, just to make sure everyone notices it, and nobody accidentally adds the file to git with "git add .". If you have a long-lived tree, or plan on swapping to old commits prior to the point where we renamed things, I recommend doing:
echo /daemon/probes.h >> .git/info/exclude
then you will be immune from 'git add .' accidentally re-adding it.
Fresh checkouts are immune, and with this message serving as notice, I think we're okay.
ACK.
And pushed.
participants (2)
-
Eric Blake -
Laine Stump