[libvirt] [PATCH] qemu.conf: spaces correction
libvirt/qemu.conf: spaces correction --- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 4fa5e8a..5cf4599 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -38,7 +38,7 @@ # # ca-cert.pem - the CA master certificate # server-cert.pem - the server certificate signed with ca-cert.pem -# server-key.pem - the server private key +# server-key.pem - the server private key # # This option allows the certificate directory to be changed # @@ -123,7 +123,7 @@ # # ca-cert.pem - the CA master certificate # server-cert.pem - the server certificate signed with ca-cert.pem -# server-key.pem - the server private key +# server-key.pem - the server private key # # This option allows the certificate directory to be changed. # @@ -179,7 +179,7 @@ #remote_display_port_max = 65535 # VNC WebSocket port policies, same rules apply as with remote display -# ports. VNC WebSockets use similar display <-> port mappings, with +# ports. VNC WebSockets use similar display <-> port mappings, with # the exception being that ports start from 5700 instead of 5900. # #remote_websocket_port_min = 5700 @@ -196,7 +196,7 @@ # security_driver = [ "selinux", "apparmor" ] # # Notes: The DAC security driver is always enabled; as a result, the -# value of security_driver cannot contain "dac". The value "none" is +# value of security_driver cannot contain "dac". The value "none" is # a special value; security_driver can be set to that value in # isolation, but it cannot appear in a list of drivers. # @@ -272,7 +272,7 @@ # "/dev/null", "/dev/full", "/dev/zero", # "/dev/random", "/dev/urandom", # "/dev/ptmx", "/dev/kvm", "/dev/kqemu", -# "/dev/rtc","/dev/hpet", "/dev/vfio/vfio" +# "/dev/rtc", "/dev/hpet", "/dev/vfio/vfio" #] # # RDMA migration requires the following extra files to be added to the list: @@ -285,11 +285,11 @@ # The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. # @@ -319,7 +319,7 @@ # When a domain is configured to be auto-dumped, enabling this flag # has the same effect as using the VIR_DUMP_BYPASS_CACHE flag with the -# virDomainCoreDump API. That is, the system will avoid using the +# virDomainCoreDump API. That is, the system will avoid using the # file system cache while writing the dump file, but may cause # slower operation. # @@ -327,17 +327,17 @@ # When a domain is configured to be auto-started, enabling this flag # has the same effect as using the VIR_DOMAIN_START_BYPASS_CACHE flag -# with the virDomainCreateWithFlags API. That is, the system will +# with the virDomainCreateWithFlags API. That is, the system will # avoid using the file system cache when restoring any managed state # file, but may cause slower operation. # #auto_start_bypass_cache = 0 # If provided by the host and a hugetlbfs mount point is configured, -# a guest may request huge page backing. When this mount point is +# a guest may request huge page backing. When this mount point is # unspecified here, determination of a host mount point in /proc/mounts -# will be attempted. Specifying an explicit mount overrides detection -# of the same in /proc/mounts. Setting the mount point to "" will +# will be attempted. Specifying an explicit mount overrides detection +# of the same in /proc/mounts. Setting the mount point to "" will # disable guest hugepage backing. If desired, multiple mount points can # be specified at once, separated by comma and enclosed in square # brackets, for example: @@ -353,9 +353,9 @@ #hugetlbfs_mount = "/dev/hugepages" -# Path to the setuid helper for creating tap devices. This executable +# Path to the setuid helper for creating tap devices. This executable # is used to create <source type='bridge'> interfaces when libvirtd is -# running unprivileged. libvirt invokes the helper directly, instead +# running unprivileged. libvirt invokes the helper directly, instead # of using "-netdev bridge", for security reasons. #bridge_helper = "/usr/libexec/qemu-bridge-helper" @@ -411,7 +411,7 @@ # # WARNING: Enabling probing is a security hole in almost all # deployments. It is strongly recommended that users update their -# guest XML <disk> elements to include <driver type='XXXX'/> +# guest XML <disk> elements to include <driver type='XXXX'/> # elements instead of enabling this option. # #allow_disk_format_probing = 1 @@ -437,18 +437,18 @@ ################################################################### # Keepalive protocol: # This allows qemu driver to detect broken connections to remote -# libvirtd during peer-to-peer migration. A keepalive message is +# libvirtd during peer-to-peer migration. A keepalive message is # sent to the daemon after keepalive_interval seconds of inactivity # to check if the daemon is still responding; keepalive_count is a # maximum number of keepalive messages that are allowed to be sent # to the daemon without getting any response before the connection -# is considered broken. In other words, the connection is +# is considered broken. In other words, the connection is # automatically closed approximately after # keepalive_interval * (keepalive_count + 1) seconds since the last # message received from the daemon. If keepalive_interval is set to # -1, qemu driver will not send keepalive requests during # peer-to-peer migration; however, the remote libvirtd can still -# send them and source libvirtd will send responses. When +# send them and source libvirtd will send responses. When # keepalive_count is set to 0, connections will be automatically # closed after keepalive_interval seconds of inactivity without # sending any keepalive messages. @@ -471,9 +471,9 @@ # The default hostname or IP address which will be used by a migration -# source for transferring migration data to this host. The migration +# source for transferring migration data to this host. The migration # source has to be able to resolve this hostname and connect to it so -# setting "localhost" will not work. By default, the host's configured +# setting "localhost" will not work. By default, the host's configured # hostname is used. #migration_host = "host.example.com" -- 2.4.11
On 09.05.2016 14:21, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
Okay. But what I'd like you to do is: 1) Explain in commit message why are you doing this change. 2) Add the following missed chunk: diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 5cf4599..aa94beb 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -445,7 +445,7 @@ # is considered broken. In other words, the connection is # automatically closed approximately after # keepalive_interval * (keepalive_count + 1) seconds since the last -# message received from the daemon. If keepalive_interval is set to +# message received from the daemon. If keepalive_interval is set to # -1, qemu driver will not send keepalive requests during # peer-to-peer migration; however, the remote libvirtd can still # send them and source libvirtd will send responses. When 3) Tell us who you are. Unfortunately, we don't accept patches supplied under a nickname or a fake name. You don't have to sign off the patch. Just make sure that From: line is in form "Name Surname <email@address>". I guess if you look around the list there are plenty of examples of good practice. Michal
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@
# The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected. Jan
On 10.05.2016 17:23, Ján Tomko wrote:
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@
# The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected.
Can you elaborate more on the reasoning behind this intent? Michal
On 05/10/2016 11:56 AM, Michal Privoznik wrote:
On 10.05.2016 17:23, Ján Tomko wrote:
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@
# The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected.
Can you elaborate more on the reasoning behind this intent?
https://en.wikipedia.org/wiki/Sentence_spacing Basically some people use two spaces after a period, some people don't. - Cole
On Tue, May 10, 2016 at 11:58:59AM -0400, Cole Robinson wrote:
On 05/10/2016 11:56 AM, Michal Privoznik wrote:
On 10.05.2016 17:23, Ján Tomko wrote:
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@
# The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected.
Can you elaborate more on the reasoning behind this intent?
https://en.wikipedia.org/wiki/Sentence_spacing
Basically some people use two spaces after a period, some people don't.
On balance libvirt only uses a single space, though there are more uses of double space that I expected. $ git grep -E "\. \w" | wc -l 4540 $ git grep -E "\. \w" | wc -l 17305 Quite alot of the double spaces actually come from the GNU license plate header ! Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 10.05.2016 17:58, Cole Robinson wrote:
On 05/10/2016 11:56 AM, Michal Privoznik wrote:
On 10.05.2016 17:23, Ján Tomko wrote:
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@
# The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected.
Can you elaborate more on the reasoning behind this intent?
What I grasped from the article is that double spacing is now being slowly deprecated in favour of a single space between both words and sentences. Michal
On 05/11/2016 04:16 AM, Michal Privoznik wrote:
On 10.05.2016 17:58, Cole Robinson wrote:
On 05/10/2016 11:56 AM, Michal Privoznik wrote:
On 10.05.2016 17:23, Ján Tomko wrote:
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@
# The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected.
Can you elaborate more on the reasoning behind this intent?
What I grasped from the article is that double spacing is now being slowly deprecated in favour of a single space between both words and sentences.
Double spacing is certainly less common in 'the real world' but it seems like there are a disproportionate number of people who use it in open source communication. Still a minority though, and I agree with the general idea of standardizing on single space in libvirt code - Cole
On Wed, May 11, 2016 at 09:43:07AM -0400, Cole Robinson wrote:
On 05/11/2016 04:16 AM, Michal Privoznik wrote:
On 10.05.2016 17:58, Cole Robinson wrote:
On 05/10/2016 11:56 AM, Michal Privoznik wrote:
On 10.05.2016 17:23, Ján Tomko wrote:
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@
# The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected.
Can you elaborate more on the reasoning behind this intent?
What I grasped from the article is that double spacing is now being slowly deprecated in favour of a single space between both words and sentences.
Double spacing is certainly less common in 'the real world' but it seems like there are a disproportionate number of people who use it in open source communication. Still a minority though, and I agree with the general idea of standardizing on single space in libvirt code
Just my two cents (as that possibility was not mentioned); I use double space after full stop to separate sentences when using monospace (that is for all stuff that can be in terminal. Those who see it with another font usually don't care and for those who do see it in monospace it is usually more readable. And that was the case for the usage earlier in the digital age I believe, although I didn't read the wikipedia article. Did nobody seriously play any classic adventure games from the 80's from a certain known (unnamed) publisher? All the dialogues used double spacing between sentences. Should *I* feel old now? =) Martin
- Cole
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, 2016-05-10 at 17:23 +0200, Ján Tomko wrote:
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@ # The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected.
On the other hand: $ grep -e '\. [A-Za-z]' src/qemu/qemu.conf | wc -l 60 $ grep -e '\. [A-Za-z]' src/qemu/qemu.conf | wc -l 18 So using a single space is prevalent. -- Andrea Bolognani Software Engineer - Virtualization Team
On Tue, May 10, 2016 at 05:23:29PM +0200, Ján Tomko wrote:
On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
libvirt/qemu.conf: spaces correction
--- src/qemu/qemu.conf | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-)
@@ -285,11 +285,11 @@
# The default format for Qemu/KVM guest save images is raw; that is, the -# memory from the domain is dumped out directly to a file. If you have +# memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite -# a bit of space. If you would like to compress the images while they +# a bit of space. If you would like to compress the images while they # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz" -# for save_image_format. Note that this means you slow down the process of +# for save_image_format. Note that this means you slow down the process of # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. #
Most of the changes remove double spacing between sentences. This was intentional and I do not think it needs to be corrected.
Why ? Using 2 spaces at the start of a sentence is very much an exception, not something we do normally anywhere else. IMHO the patch is right to remove these double spaces. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (7)
-
Andrea Bolognani -
Cole Robinson -
Daniel P. Berrange -
Ján Tomko -
Martin Kletzander -
Michal Privoznik -
poma