[libvirt] [PATCH 0/3] docs: storage: document 'lvm2' disk fun
Ján Tomko (3): docs: storage: fix spacing when enumerating volume formats docs: storage: type out two docs: storage: document the 'lvm2' disk format oddness docs/storage.html.in | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.20.1
There was a space missing after 'qcow'. Delete 'qcow' and 'cow' as examples to make the document more relevant for the current decade. Signed-off-by: Ján Tomko <jtomko@redhat.com> --- docs/storage.html.in | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index ab1f880813..9291c69f32 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -90,10 +90,10 @@ A pool with a type of <code>dir</code> provides the means to manage files within a directory. The files can be fully allocated raw files, sparsely allocated raw files, or one of the special disk formats - such as <code>qcow</code>,<code>qcow2</code>,<code>vmdk</code>, - <code>cow</code>, etc as supported by the <code>qemu-img</code> - program. If the directory does not exist at the time the pool is - defined, the <code>build</code> operation can be used to create it. + such as <code>qcow2</code>, <code>vmdk</code>, etc as supported + by the <code>qemu-img</code> program. If the directory does not exist + at the time the pool is defined, the <code>build</code> + operation can be used to create it. </p> <h3>Example pool input definition</h3> @@ -132,9 +132,8 @@ natively. When creating new volumes, only a subset may be available. The <code>raw</code> type is guaranteed always available. The <code>qcow2</code> type can be created if - either <code>qemu-img</code> or <code>qcow-create</code> tools - are present. The others are dependent on support of the - <code>qemu-img</code> tool. + the <code>qemu-img</code> tool is present. The others are + dependent on support of the <code>qemu-img</code> tool. </p> -- 2.20.1
Signed-off-by: Ján Tomko <jtomko@redhat.com> --- docs/storage.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 9291c69f32..4681a02023 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -308,7 +308,7 @@ by adding partitions to the disk. Disk pools have constraints on the size and placement of volumes. The 'free extents' information will detail the regions which are available for creating - new volumes. A volume cannot span across 2 different free extents. + new volumes. A volume cannot span across two different free extents. It will default to using <code>dos</code> as the pool source format. </p> -- 2.20.1
Signed-off-by: Ján Tomko <jtomko@redhat.com> --- docs/storage.html.in | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 4681a02023..7a9a980e7c 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -359,7 +359,16 @@ The formats <code>dos</code> ("msdos" in parted terminology, good for BIOS systems) or <code>gpt</code> (good for UEFI systems) are recommended for best portability - the latter is - needed for disks larger than 2TB. + needed for disks larger than 2TB. Note that the <code>lvm2</code> + format refers to the physical volume format (i.e. the whole + disk is a physical volume - not the usual usage of LVM where + physical volumes are partitions)). This is not really + a partition table and such pool cannot be built by libvirt, + only detected. + </p> + <p> + Building a pool of a certain format depends on its availability + in <code>parted</code>. </p> <h3>Valid volume format types</h3> -- 2.20.1
On 6/15/19 2:54 PM, Ján Tomko wrote:
Ján Tomko (3): docs: storage: fix spacing when enumerating volume formats docs: storage: type out two docs: storage: document the 'lvm2' disk format oddness
docs/storage.html.in | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-)
ACK Michal
participants (2)
-
Ján Tomko -
Michal Privoznik