[libvirt PATCH] spec: Depend on qemu-kvm-block-driver-curl in RHEL-9
The curl block driver is no longer a requirement for qemu-kvm package in RHEL-9, which breaks support for https network disks. Let's depend on it explicitly (in libvirt-daemon-kvm meta package) until we possibly reimplement the https disk support using nbdkit (tracked in bug 2016527). https://bugzilla.redhat.com/show_bug.cgi?id=2014229 Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 4ecb28114c..b71888653d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -791,6 +791,10 @@ Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release} Requires: libvirt-daemon-driver-secret = %{version}-%{release} Requires: libvirt-daemon-driver-storage = %{version}-%{release} Requires: qemu-kvm +# qemu-kvm no longer depends on curl block driver in RHEL-9 +%if 0%{?rhel} > 8 +Requires: qemu-kvm-block-driver-curl +%endif %description daemon-kvm Server side daemon and driver required to manage the virtualization -- 2.33.1
On a Wednesday in 2021, Jiri Denemark wrote:
The curl block driver is no longer a requirement for qemu-kvm package in RHEL-9, which breaks support for https network disks. Let's depend on it explicitly (in libvirt-daemon-kvm meta package) until we possibly reimplement the https disk support using nbdkit (tracked in bug 2016527).
https://bugzilla.redhat.com/show_bug.cgi?id=2014229
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
On Wed, Oct 27, 2021 at 03:58:29PM +0200, Jiri Denemark wrote:
The curl block driver is no longer a requirement for qemu-kvm package in RHEL-9, which breaks support for https network disks. Let's depend on it explicitly (in libvirt-daemon-kvm meta package) until we possibly reimplement the https disk support using nbdkit (tracked in bug 2016527).
https://bugzilla.redhat.com/show_bug.cgi?id=2014229
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 4ecb28114c..b71888653d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -791,6 +791,10 @@ Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release} Requires: libvirt-daemon-driver-secret = %{version}-%{release} Requires: libvirt-daemon-driver-storage = %{version}-%{release} Requires: qemu-kvm +# qemu-kvm no longer depends on curl block driver in RHEL-9 +%if 0%{?rhel} > 8 +Requires: qemu-kvm-block-driver-curl +%endif
it feels pretty dubious to me todo this in libvirt. If curl driver is still required by valid use cases in RHEL-9, then 'qemu-kvm' should still depend on it, until we have a replacement ready. People who want a truly minimal install can already use 'qemu-kvm-core' to avoid all driver modules. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Wed, Oct 27, 2021 at 15:38:22 +0100, Daniel P. Berrangé wrote:
On Wed, Oct 27, 2021 at 03:58:29PM +0200, Jiri Denemark wrote:
The curl block driver is no longer a requirement for qemu-kvm package in RHEL-9, which breaks support for https network disks. Let's depend on it explicitly (in libvirt-daemon-kvm meta package) until we possibly reimplement the https disk support using nbdkit (tracked in bug 2016527).
https://bugzilla.redhat.com/show_bug.cgi?id=2014229
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 4ecb28114c..b71888653d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -791,6 +791,10 @@ Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release} Requires: libvirt-daemon-driver-secret = %{version}-%{release} Requires: libvirt-daemon-driver-storage = %{version}-%{release} Requires: qemu-kvm +# qemu-kvm no longer depends on curl block driver in RHEL-9 +%if 0%{?rhel} > 8 +Requires: qemu-kvm-block-driver-curl +%endif
it feels pretty dubious to me todo this in libvirt.
If curl driver is still required by valid use cases in RHEL-9, then 'qemu-kvm' should still depend on it, until we have a replacement ready.
I would agree with you if this was either permanent or the replacement was to be implemented in QEMU. However, this is a temporary dependency and once we have replacement ready, we can just drop this without having to synchronize with other components and without worrying about possible issues when QEMU and libvirt are not upgraded in a single step. Jirka
On Fri, Oct 29, 2021 at 02:53:09PM +0200, Jiri Denemark wrote:
On Wed, Oct 27, 2021 at 15:38:22 +0100, Daniel P. Berrangé wrote:
On Wed, Oct 27, 2021 at 03:58:29PM +0200, Jiri Denemark wrote:
The curl block driver is no longer a requirement for qemu-kvm package in RHEL-9, which breaks support for https network disks. Let's depend on it explicitly (in libvirt-daemon-kvm meta package) until we possibly reimplement the https disk support using nbdkit (tracked in bug 2016527).
https://bugzilla.redhat.com/show_bug.cgi?id=2014229
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 4ecb28114c..b71888653d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -791,6 +791,10 @@ Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release} Requires: libvirt-daemon-driver-secret = %{version}-%{release} Requires: libvirt-daemon-driver-storage = %{version}-%{release} Requires: qemu-kvm +# qemu-kvm no longer depends on curl block driver in RHEL-9 +%if 0%{?rhel} > 8 +Requires: qemu-kvm-block-driver-curl +%endif
it feels pretty dubious to me todo this in libvirt.
If curl driver is still required by valid use cases in RHEL-9, then 'qemu-kvm' should still depend on it, until we have a replacement ready.
I would agree with you if this was either permanent or the replacement was to be implemented in QEMU. However, this is a temporary dependency and once we have replacement ready, we can just drop this without having to synchronize with other components and without worrying about possible issues when QEMU and libvirt are not upgraded in a single step.
This only fixes the problem in the specific case that someone depends on 'libvirt-daemon-kvm', while apps may well just depend on "Requires: libvirt-daemon-driver-qemu qemu-kvm". We need to fix this in qemu-kvm.spec, as that's where the problem was caused. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (3)
-
Daniel P. Berrangé -
Jiri Denemark -
Ján Tomko