[libvirt] [PATCH] dist: distribute all libvirt_*.syms files, ...

Some of the new libvirt_*.syms files were included in EXTRA_DIST only conditionally. Here's the fix:
From 272938681646e3aeefe5d9b13fab312a47e5d862 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Tue, 6 Jan 2009 12:09:40 +0100 Subject: [PATCH] dist: distribute all libvirt_*.syms files, ...
* src/Makefile.am (EXTRA_DIST): Distribute all libvirt_*.syms files, not just those that happen to be selected at configure time. --- src/Makefile.am | 22 ++++++++++++++-------- 1 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 1f707e2..b3020cc 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -192,7 +192,7 @@ libvirt_driver_la_SOURCES = \ libvirt_driver_la_CFLAGS = $(XEN_CFLAGS) $(NUMACTL_CFLAGS) libvirt_driver_la_LDFLAGS = $(XEN_LIBS) $(NUMACTL_LIBS) -PRIVSYMFILES = libvirt_private.syms +USED_SYM_FILES = libvirt_private.syms if WITH_TEST if WITH_DRIVER_MODULES @@ -412,31 +412,37 @@ EXTRA_DIST += \ # if ENABLE_DEBUG -PRIVSYMFILES += libvirt_debug.syms +USED_SYM_FILES += libvirt_debug.syms endif if WITH_DRIVER_MODULES -PRIVSYMFILES += libvirt_driver_modules.syms +USED_SYM_FILES += libvirt_driver_modules.syms endif if WITH_BRIDGE -PRIVSYMFILES += libvirt_bridge.syms +USED_SYM_FILES += libvirt_bridge.syms endif if WITH_LINUX -PRIVSYMFILES += libvirt_linux.syms +USED_SYM_FILES += libvirt_linux.syms endif -EXTRA_DIST += libvirt_public.syms $(PRIVSYMFILES) +EXTRA_DIST += \ + libvirt_public.syms \ + libvirt_private.syms \ + libvirt_debug.syms \ + libvirt_driver_modules.syms \ + libvirt_bridge.syms \ + libvirt_linux.syms -libvirt.syms: libvirt_public.syms $(PRIVSYMFILES) +libvirt.syms: libvirt_public.syms $(USED_SYM_FILES) rm -f $@-tmp $@ printf '# WARNING: generated from the following:\n# $^\n\n' >$@-tmp cat $(srcdir)/libvirt_public.syms >>$@-tmp printf '\n\n# Private symbols\n\n' >>$@-tmp printf 'LIBVIRT_PRIVATE_$(VERSION) {\n\n' >>$@-tmp printf 'global:\n\n' >>$@-tmp - for file in $(PRIVSYMFILES); do \ + for file in $(USED_SYM_FILES); do \ cat $(srcdir)/$$file >>$@-tmp; \ done printf '\n\nlocal:\n*;\n\n};' >>$@-tmp -- 1.6.1.rc3.350.g541da

On Tue, Jan 06, 2009 at 12:11:42PM +0100, Jim Meyering wrote:
Some of the new libvirt_*.syms files were included in EXTRA_DIST only conditionally.
Yes we need all the remaining sym files to be embedded in the distribution, +1 thanks, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

Daniel Veillard <veillard@redhat.com> wrote:
On Tue, Jan 06, 2009 at 12:11:42PM +0100, Jim Meyering wrote:
Some of the new libvirt_*.syms files were included in EXTRA_DIST only conditionally.
Yes we need all the remaining sym files to be embedded in the distribution, +1
Thanks. committed.
participants (2)
-
Daniel Veillard
-
Jim Meyering