[libvirt] [libvirt-sandbox][PATCH] Docs: fix a typo in help documents
Signed-off-by: Alex Jia <ajia@redhat.com> --- bin/virt-sandbox.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index bd7ac49..654a205 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -87,10 +87,10 @@ int main(int argc, char **argv) { { "name", 'n', 0, G_OPTION_ARG_STRING, &name, N_("name of the sandbox"), "NAME" }, { "mount", 'm', 0, G_OPTION_ARG_STRING_ARRAY, &mounts, - N_("mount a filesystem int he guest"), "TYPE:TARGET=SOURCE" }, + N_("mount a filesystem in the guest"), "TYPE:TARGET=SOURCE" }, { "include", 'i', 0, G_OPTION_ARG_STRING_ARRAY, &includes, N_("file to copy into custom dir"), "GUEST-PATH=HOST-PATH", }, - { "includefile", 'I', 0, G_OPTION_ARG_STRING, &includefile, + { "interfile", 'I', 0, G_OPTION_ARG_STRING, &includefile, N_("file contain list of files to include"), "FILE" }, { "network", 'N', 0, G_OPTION_ARG_STRING_ARRAY, &networks, N_("setup network interface properties"), "PATH", }, -- 1.7.1
On 2013年03月18日 17:39, Alex Jia wrote:
Signed-off-by: Alex Jia<ajia@redhat.com> --- bin/virt-sandbox.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index bd7ac49..654a205 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -87,10 +87,10 @@ int main(int argc, char **argv) { { "name", 'n', 0, G_OPTION_ARG_STRING,&name, N_("name of the sandbox"), "NAME" }, { "mount", 'm', 0, G_OPTION_ARG_STRING_ARRAY,&mounts, - N_("mount a filesystem int he guest"), "TYPE:TARGET=SOURCE" }, + N_("mount a filesystem in the guest"), "TYPE:TARGET=SOURCE" }, { "include", 'i', 0, G_OPTION_ARG_STRING_ARRAY,&includes, N_("file to copy into custom dir"), "GUEST-PATH=HOST-PATH", }, - { "includefile", 'I', 0, G_OPTION_ARG_STRING,&includefile, + { "interfile", 'I', 0, G_OPTION_ARG_STRING,&includefile, N_("file contain list of files to include"), "FILE" },
Didn't check the source, but if it's the right fix, you should also change the variable name (includefile) to be consistent. And also the help message.
{ "network", 'N', 0, G_OPTION_ARG_STRING_ARRAY,&networks, N_("setup network interface properties"), "PATH", },
On 03/18/2013 05:45 PM, Osier Yang wrote:
On 2013年03月18日 17:39, Alex Jia wrote:
Signed-off-by: Alex Jia<ajia@redhat.com> --- bin/virt-sandbox.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index bd7ac49..654a205 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -87,10 +87,10 @@ int main(int argc, char **argv) { { "name", 'n', 0, G_OPTION_ARG_STRING,&name, N_("name of the sandbox"), "NAME" }, { "mount", 'm', 0, G_OPTION_ARG_STRING_ARRAY,&mounts, - N_("mount a filesystem int he guest"), "TYPE:TARGET=SOURCE" }, + N_("mount a filesystem in the guest"), "TYPE:TARGET=SOURCE" }, { "include", 'i', 0, G_OPTION_ARG_STRING_ARRAY,&includes, N_("file to copy into custom dir"), "GUEST-PATH=HOST-PATH", }, - { "includefile", 'I', 0, G_OPTION_ARG_STRING,&includefile, + { "interfile", 'I', 0, G_OPTION_ARG_STRING,&includefile,
It's a wrong operation, in fact, I haven't changed it, I will fix this. thanks.
N_("file contain list of files to include"), "FILE" },
Didn't check the source, but if it's the right fix, you should also change the variable name (includefile) to be consistent. And also the help message.
{ "network", 'N', 0, G_OPTION_ARG_STRING_ARRAY,&networks, N_("setup network interface properties"), "PATH", },
On Mon, Mar 18, 2013 at 05:39:25PM +0800, Alex Jia wrote:
Signed-off-by: Alex Jia <ajia@redhat.com> --- bin/virt-sandbox.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index bd7ac49..654a205 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -87,10 +87,10 @@ int main(int argc, char **argv) { { "name", 'n', 0, G_OPTION_ARG_STRING, &name, N_("name of the sandbox"), "NAME" }, { "mount", 'm', 0, G_OPTION_ARG_STRING_ARRAY, &mounts, - N_("mount a filesystem int he guest"), "TYPE:TARGET=SOURCE" }, + N_("mount a filesystem in the guest"), "TYPE:TARGET=SOURCE" },
ACK to this
{ "include", 'i', 0, G_OPTION_ARG_STRING_ARRAY, &includes, N_("file to copy into custom dir"), "GUEST-PATH=HOST-PATH", }, - { "includefile", 'I', 0, G_OPTION_ARG_STRING, &includefile, + { "interfile", 'I', 0, G_OPTION_ARG_STRING, &includefile,
but NACK to this
N_("file contain list of files to include"), "FILE" }, { "network", 'N', 0, G_OPTION_ARG_STRING_ARRAY, &networks, N_("setup network interface properties"), "PATH", },
Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (3)
-
Alex Jia -
Daniel P. Berrange -
Osier Yang