8:09 a.m.
This series fixes the precise+gcc combo not being actually tested
and significantly improves test coverage by installing a bunch of
additional optional dependencies on the workers.
Andrea Bolognani (8):
travis: Limit git depth to 5 commits
travis: Move variables to 'env' section
travis: Don't abort build due to -Wvariadic-macros
travis: Split building command
travis: Don't have a separate script definition for macOS
travis: Improve test matrix
travis: Install more build dependencies
travis: Shuffle sections around
.travis.yml | 125 ++++++++++++++++++++++++++++++++++++++----------------------
1 file changed, 79 insertions(+), 46 deletions(-)
--
2.13.5
8:09 a.m.
New subject: [libvirt] [PATCH 1/8] travis: Limit git depth to 5 commits
We don't need 50 commits for our purposes, so might as well save some
bandwidth and possibly some time by making the clone more shallow.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.travis.yml b/.travis.yml
index f59bd19c8..8831f742c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -57,6 +57,7 @@ notifications:
- secure:
"QcU9eP96P0RlDNzVRZl/4sxyydPStGzECrpgJhr2IPB/7pHk23yaBrmUsq9S830tB+jwLGma1IscNB8uf7Sf7WY+cYIpfR8v030OffWnaipo/Gcs0dpnlfURWHjOFQI3RJzGEihsqvbwUFOwsM+3IDyO3qdWaiT6cN2Tj9ROlwYCySSX5YWzLyX7arBZ4lp8ESs7ohQaEwp2cegnMP2oGPJJe4SebvlCDjHZbjkU5aEradwUWnRQDJZWTKknpNLArVFxN2/ixp6f/MGY4DmkHoDweio6mHIPN5zTs5Jt32aiX6wDBa+bBa4v8TCRqzhYkQ63ZZhNV8bY5Uf9ufTdyvt96yIANyakd85b1QpMdAX76IyJi1l0/Uub6DTQZAcq3vK7iPjGeTVSpyoXrqTfGy4JxMjqDoocpWvv8ALX1wrYI/HfN2R2Aepw9jModTimOsebYhJ1yMhSt8qnh5AQNftGKL2JBKoA1LWdU2YJ5fO1bGjKNiVEkGFQTPYFWrYCUY5JcT+s5WCzNeMNm8s9na8liYhGl3WtS3rPr5M8bof+BMsBhG2hQ0loduc94x2GkvyhQZUgRbqrwNR+y4hn+rWFC3hBzzyiAULs43vY/PJ+eBdKEf3VAc0MkhQ8GgXGSA61fR6aXYonroI/WnBVItwDmUnnMfSziZXxk09GLl4="
git:
+ depth: 5
submodules: true
before_install:
--
2.13.5
8:44 a.m.
New subject: [libvirt] [PATCH 1/8] travis: Limit git depth to 5 commits
On Thu, Sep 14, 2017 at 03:09:01PM +0200, Andrea Bolognani wrote:
We don't need 50 commits for our purposes, so might as well save
some
bandwidth and possibly some time by making the clone more shallow.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.travis.yml b/.travis.yml
index f59bd19c8..8831f742c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -57,6 +57,7 @@ notifications:
- secure:
"QcU9eP96P0RlDNzVRZl/4sxyydPStGzECrpgJhr2IPB/7pHk23yaBrmUsq9S830tB+jwLGma1IscNB8uf7Sf7WY+cYIpfR8v030OffWnaipo/Gcs0dpnlfURWHjOFQI3RJzGEihsqvbwUFOwsM+3IDyO3qdWaiT6cN2Tj9ROlwYCySSX5YWzLyX7arBZ4lp8ESs7ohQaEwp2cegnMP2oGPJJe4SebvlCDjHZbjkU5aEradwUWnRQDJZWTKknpNLArVFxN2/ixp6f/MGY4DmkHoDweio6mHIPN5zTs5Jt32aiX6wDBa+bBa4v8TCRqzhYkQ63ZZhNV8bY5Uf9ufTdyvt96yIANyakd85b1QpMdAX76IyJi1l0/Uub6DTQZAcq3vK7iPjGeTVSpyoXrqTfGy4JxMjqDoocpWvv8ALX1wrYI/HfN2R2Aepw9jModTimOsebYhJ1yMhSt8qnh5AQNftGKL2JBKoA1LWdU2YJ5fO1bGjKNiVEkGFQTPYFWrYCUY5JcT+s5WCzNeMNm8s9na8liYhGl3WtS3rPr5M8bof+BMsBhG2hQ0loduc94x2GkvyhQZUgRbqrwNR+y4hn+rWFC3hBzzyiAULs43vY/PJ+eBdKEf3VAc0MkhQ8GgXGSA61fR6aXYonroI/WnBVItwDmUnnMfSziZXxk09GLl4="
git:
+ depth: 5
submodules: true
before_install:
Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
8:09 a.m.
New subject: [libvirt] [PATCH 2/8] travis: Move variables to 'env' section
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 8831f742c..367baf861 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -60,14 +60,20 @@ git:
depth: 5
submodules: true
+env:
+ global:
+ # The custom $PATH is just to pick up some extra binaries installed
+ # through homebrew on macOS and it's completely harmless on Linux
+ - PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH"
+ - VIR_TEST_DEBUG=1
+
before_install:
- if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update &&
brew install gnutls libgcrypt yajl gettext rpcgen ; fi
-# the custom PATH is just to pick up OS-X homebrew & its harmless on Linux
before_script:
- - PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH"
./autogen.sh
+ - ./autogen.sh
script:
- - VIR_TEST_DEBUG=1 make -j3 && make -j3 syntax-check && make -j3 check
+ - make -j3 && make -j3 syntax-check && make -j3 check
# Environments here are run in addition to the main environment defined above
matrix:
--
2.13.5
8:44 a.m.
New subject: [libvirt] [PATCH 2/8] travis: Move variables to 'env' section
On Thu, Sep 14, 2017 at 03:09:02PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 8831f742c..367baf861 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -60,14 +60,20 @@ git:
depth: 5
submodules: true
+env:
+ global:
+ # The custom $PATH is just to pick up some extra binaries installed
+ # through homebrew on macOS and it's completely harmless on Linux
+ - PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH"
+ - VIR_TEST_DEBUG=1
+
before_install:
- if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update &&
brew install gnutls libgcrypt yajl gettext rpcgen ; fi
-# the custom PATH is just to pick up OS-X homebrew & its harmless on Linux
before_script:
- - PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH"
./autogen.sh
+ - ./autogen.sh
script:
- - VIR_TEST_DEBUG=1 make -j3 && make -j3 syntax-check && make -j3
check
+ - make -j3 && make -j3 syntax-check && make -j3 check
# Environments here are run in addition to the main environment defined above
matrix:
Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
8:09 a.m.
New subject: [libvirt] [PATCH 3/8] travis: Don't abort build due to -Wvariadic-macros
The openwsman header files are at fault here, but precise is entirely
unmaintained at this point so the issue will never be fixed.
Better to ignore the error and have coverage over the Hyper-V driver
than disabling it: if code that would trigger the warning will be
added to libvirt, the CentOS CI will catch it.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index 367baf861..ba8ff49a1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -65,6 +65,9 @@ env:
# The custom $PATH is just to pick up some extra binaries installed
# through homebrew on macOS and it's completely harmless on Linux
- PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH"
+ # The hyperv driver fails to build with clang on precise due to this
+ # error being raised in one of openwsman header files
+ - CFLAGS="-Wno-error=variadic-macros"
- VIR_TEST_DEBUG=1
before_install:
--
2.13.5
8:45 a.m.
New subject: [libvirt] [PATCH 3/8] travis: Don't abort build due to -Wvariadic-macros
On Thu, Sep 14, 2017 at 03:09:03PM +0200, Andrea Bolognani wrote:
The openwsman header files are at fault here, but precise is
entirely
unmaintained at this point so the issue will never be fixed.
Better to ignore the error and have coverage over the Hyper-V driver
than disabling it: if code that would trigger the warning will be
added to libvirt, the CentOS CI will catch it.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index 367baf861..ba8ff49a1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -65,6 +65,9 @@ env:
# The custom $PATH is just to pick up some extra binaries installed
# through homebrew on macOS and it's completely harmless on Linux
- PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH"
+ # The hyperv driver fails to build with clang on precise due to this
+ # error being raised in one of openwsman header files
+ - CFLAGS="-Wno-error=variadic-macros"
- VIR_TEST_DEBUG=1
before_install:
Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
8:09 a.m.
New subject: [libvirt] [PATCH 4/8] travis: Split building command
The build will fail if any of the commands fail, but this way we
might catch more errors in a single run.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index ba8ff49a1..c2526bc6d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -76,7 +76,9 @@ before_install:
before_script:
- ./autogen.sh
script:
- - make -j3 && make -j3 syntax-check && make -j3 check
+ - make -j3
+ - make -j3 syntax-check
+ - make -j3 check
# Environments here are run in addition to the main environment defined above
matrix:
--
2.13.5
8:48 a.m.
New subject: [libvirt] [PATCH 4/8] travis: Split building command
On Thu, Sep 14, 2017 at 03:09:04PM +0200, Andrea Bolognani wrote:
The build will fail if any of the commands fail, but this way we
might catch more errors in a single run.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index ba8ff49a1..c2526bc6d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -76,7 +76,9 @@ before_install:
before_script:
- ./autogen.sh
script:
- - make -j3 && make -j3 syntax-check && make -j3 check
+ - make -j3
+ - make -j3 syntax-check
+ - make -j3 check
# Environments here are run in addition to the main environment defined above
matrix:
The downside of this is that if syntax-check fails, but check succeeeds,
you now have to search through the middle of the logfile to find the
failure, instead of just jumping straight to the end.
So I'm on the fence about this patch - I'd have a slight preference for
existing behaviour of failing fast to keep errors at the end of the log
None the less
Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
9:45 a.m.
New subject: [libvirt] [PATCH 4/8] travis: Split building command
On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote:
> script:
> - - make -j3 && make -j3 syntax-check && make -j3 check
> + - make -j3
> + - make -j3 syntax-check
> + - make -j3 check
>
> # Environments here are run in addition to the main environment defined above
> matrix:
The downside of this is that if syntax-check fails, but check succeeeds,
you now have to search through the middle of the logfile to find the
failure, instead of just jumping straight to the end.
So I'm on the fence about this patch - I'd have a slight preference for
existing behaviour of failing fast to keep errors at the end of the log
I can drop this patch and have the end result look like
script:
# Many unit tests still fail on macOS, and there are a bunch of issues
# with syntax-check as well, so skip them for now
- make -j3 && if [ "$TRAVIS_OS_NAME" != "osx" ]; then make
-j3 syntax-check && make -j3 check; fi
Would you like that better?
--
Andrea Bolognani / Red Hat / Virtualization
9:49 a.m.
New subject: [libvirt] [PATCH 4/8] travis: Split building command
On Thu, Sep 14, 2017 at 04:45:30PM +0200, Andrea Bolognani wrote:
On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote:
> > script:
> > - - make -j3 && make -j3 syntax-check && make -j3 check
> > + - make -j3
> > + - make -j3 syntax-check
> > + - make -j3 check
> >
> > # Environments here are run in addition to the main environment defined above
> > matrix:
>
> The downside of this is that if syntax-check fails, but check succeeeds,
> you now have to search through the middle of the logfile to find the
> failure, instead of just jumping straight to the end.
>
> So I'm on the fence about this patch - I'd have a slight preference for
> existing behaviour of failing fast to keep errors at the end of the log
I can drop this patch and have the end result look like
script:
# Many unit tests still fail on macOS, and there are a bunch of issues
# with syntax-check as well, so skip them for now
- make -j3 && if [ "$TRAVIS_OS_NAME" != "osx" ]; then
make -j3 syntax-check && make -j3 check; fi
Would you like that better?
Yep, I think so
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
9:49 a.m.
New subject: [libvirt] [PATCH 4/8] travis: Split building command
On Thu, Sep 14, 2017 at 02:48:06PM +0100, Daniel P. Berrange wrote:
On Thu, Sep 14, 2017 at 03:09:04PM +0200, Andrea Bolognani wrote:
> The build will fail if any of the commands fail, but this way we
> might catch more errors in a single run.
>
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> .travis.yml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index ba8ff49a1..c2526bc6d 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -76,7 +76,9 @@ before_install:
> before_script:
> - ./autogen.sh
> script:
> - - make -j3 && make -j3 syntax-check && make -j3 check
> + - make -j3
> + - make -j3 syntax-check
> + - make -j3 check
>
> # Environments here are run in addition to the main environment defined above
> matrix:
The downside of this is that if syntax-check fails, but check succeeeds,
you now have to search through the middle of the logfile to find the
failure, instead of just jumping straight to the end.
So I'm on the fence about this patch - I'd have a slight preference for
existing behaviour of failing fast to keep errors at the end of the log
I, personally, would go with:
script:
- make -j3 check
- make -j3 syntax-check
The former executes the whole build and fails on first compilation or
test error. The second one has a format that's easily skippable
(visually) and that's not that much to scroll through.
I'm leaving the choice up to you, though.
None the less
Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
10:10 a.m.
New subject: [libvirt] [PATCH 4/8] travis: Split building command
On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote:
> So I'm on the fence about this patch - I'd have a slight
preference for
> existing behaviour of failing fast to keep errors at the end of the log
I, personally, would go with:
script:
- make -j3 check
- make -j3 syntax-check
The former executes the whole build and fails on first compilation or
test error. The second one has a format that's easily skippable
(visually) and that's not that much to scroll through.
We can't run either 'make check' or 'make syntax-check' on macOS
though, so your proposal would effectively kill all testing on that
platform :)
--
Andrea Bolognani / Red Hat / Virtualization
10:29 a.m.
New subject: [libvirt] [PATCH 4/8] travis: Split building command
On Thu, Sep 14, 2017 at 05:10:24PM +0200, Andrea Bolognani wrote:
On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote:
> > So I'm on the fence about this patch - I'd have a slight preference for
> > existing behaviour of failing fast to keep errors at the end of the log
>
> I, personally, would go with:
>
> script:
> - make -j3 check
> - make -j3 syntax-check
>
> The former executes the whole build and fails on first compilation or
> test error. The second one has a format that's easily skippable
> (visually) and that's not that much to scroll through.
We can't run either 'make check' or 'make syntax-check' on macOS
though, so your proposal would effectively kill all testing on that
platform :)
Well, but that's changed after this patch, so technically it wouldn't ;)
Anyway, the point was keeping syntax-check last as that's easier to
visually skip.
ACK either way
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
8:09 a.m.
New subject: [libvirt] [PATCH 5/8] travis: Don't have a separate script definition for macOS
Make single commands OS-dependent instead.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index c2526bc6d..e93fc73b2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -77,8 +77,10 @@ before_script:
- ./autogen.sh
script:
- make -j3
- - make -j3 syntax-check
- - make -j3 check
+ # Many unit tests still fail on macOS, and there are a bunch of issues
+ # with syntax-check as well, so skip them for now
+ - if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check;
fi
+ - if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 check; fi
# Environments here are run in addition to the main environment defined above
matrix:
@@ -91,10 +93,6 @@ matrix:
dist: trusty
- compiler: clang
os: osx
- script:
- # many unit tests fail & so does syntax-check, so skip for now
- # one day we must fix it though....
- - make -j3
after_failure:
- echo
'============================================================================'
--
2.13.5
8:48 a.m.
New subject: [libvirt] [PATCH 5/8] travis: Don't have a separate script definition for macOS
On Thu, Sep 14, 2017 at 03:09:05PM +0200, Andrea Bolognani wrote:
Make single commands OS-dependent instead.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index c2526bc6d..e93fc73b2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -77,8 +77,10 @@ before_script:
- ./autogen.sh
script:
- make -j3
- - make -j3 syntax-check
- - make -j3 check
+ # Many unit tests still fail on macOS, and there are a bunch of issues
+ # with syntax-check as well, so skip them for now
+ - if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check;
fi
+ - if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 check; fi
# Environments here are run in addition to the main environment defined above
matrix:
@@ -91,10 +93,6 @@ matrix:
dist: trusty
- compiler: clang
os: osx
- script:
- # many unit tests fail & so does syntax-check, so skip for now
- # one day we must fix it though....
- - make -j3
after_failure:
- echo
'============================================================================'
--
Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
8:09 a.m.
New subject: [libvirt] [PATCH 6/8] travis: Improve test matrix
The default distribution is apparently ignored if an explicit test
matrix is provided, so we haven't actually been testing the precise
plus gcc combo.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index e93fc73b2..154727fa3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,8 +1,5 @@
sudo: false
language: c
-dist: precise
-compiler:
- - gcc
cache: ccache
addons:
apt:
@@ -82,15 +79,16 @@ script:
- if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check;
fi
- if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 check; fi
-# Environments here are run in addition to the main environment defined above
matrix:
include:
+ - compiler: gcc
+ dist: precise
+ - compiler: gcc
+ dist: trusty
- compiler: clang
dist: precise
- compiler: clang
dist: trusty
- - compiler: gcc
- dist: trusty
- compiler: clang
os: osx
--
2.13.5
8:49 a.m.
New subject: [libvirt] [PATCH 6/8] travis: Improve test matrix
On Thu, Sep 14, 2017 at 03:09:06PM +0200, Andrea Bolognani wrote:
The default distribution is apparently ignored if an explicit test
matrix is provided, so we haven't actually been testing the precise
plus gcc combo.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index e93fc73b2..154727fa3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,8 +1,5 @@
sudo: false
language: c
-dist: precise
-compiler:
- - gcc
cache: ccache
addons:
apt:
@@ -82,15 +79,16 @@ script:
- if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check;
fi
- if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 check; fi
-# Environments here are run in addition to the main environment defined above
That'll teach me to cut+paste from QEMU without checking reality :-)
matrix:
include:
+ - compiler: gcc
+ dist: precise
+ - compiler: gcc
+ dist: trusty
- compiler: clang
dist: precise
- compiler: clang
dist: trusty
- - compiler: gcc
- dist: trusty
- compiler: clang
os: osx
Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
8:09 a.m.
New subject: [libvirt] [PATCH 7/8] travis: Install more build dependencies
Since configure automatically picks up as many optional dependencies
as possible, installing more packages allows us to improve our test
coverage.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 37 ++++++++++++++++++++++++++++++-------
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 154727fa3..f56e6ae6f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,37 +5,60 @@ addons:
apt:
# Please keep this list sorted alphabetically
packages:
+ - autoconf
+ - automake
- autopoint
+ - ccache
- dnsmasq-base
-# - dwarves
+ - ebtables
+ - gcc
- gettext
+ - glusterfs-client
+ - libacl1-dev
- libapparmor-dev
+ - libattr1-dev
- libaudit-dev
- libavahi-client-dev
+ - libblkid-dev
+ - libc6-dev
- libcap-ng-dev
+ - libcurl4-gnutls-dev
+ - libdbus-1-dev
- libdevmapper-dev
- - libgcrypt11-dev
+ - libfuse-dev
- libgnutls-dev
- - libncurses5-dev
- libnetcf-dev
- libnl-3-dev
- libnl-route-3-dev
- libnuma-dev
- - libparted0-dev
- - libpcap0.8-dev
+ - libopenwsman-dev
+ - libparted-dev
+ - libpcap-dev
- libpciaccess-dev
- librbd-dev
- libreadline-dev
- libsasl2-dev
+ - libssh2-1-dev
+ - libssl-dev
+ - libtool
- libudev-dev
- libxen-dev
- libxml2-dev
- libxml2-utils
- libyajl-dev
- lvm2
- - uuid-dev
+ - make
+ - nfs-common
+ - open-iscsi
+ - parted
+ - patch
+ - pkg-config
+ - policykit-1
+ - scrub
+ - sheepdog
+ - systemtap-sdt-dev
- xsltproc
- - zlib1g-dev
+ - zfs-fuse
notifications:
irc:
--
2.13.5
8:50 a.m.
New subject: [libvirt] [PATCH 7/8] travis: Install more build dependencies
On Thu, Sep 14, 2017 at 03:09:07PM +0200, Andrea Bolognani wrote:
Since configure automatically picks up as many optional dependencies
as possible, installing more packages allows us to improve our test
coverage.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 37 ++++++++++++++++++++++++++++++-------
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 154727fa3..f56e6ae6f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,37 +5,60 @@ addons:
apt:
# Please keep this list sorted alphabetically
packages:
+ - autoconf
+ - automake
- autopoint
+ - ccache
- dnsmasq-base
-# - dwarves
+ - ebtables
+ - gcc
- gettext
+ - glusterfs-client
+ - libacl1-dev
- libapparmor-dev
+ - libattr1-dev
- libaudit-dev
- libavahi-client-dev
+ - libblkid-dev
+ - libc6-dev
- libcap-ng-dev
+ - libcurl4-gnutls-dev
+ - libdbus-1-dev
- libdevmapper-dev
- - libgcrypt11-dev
+ - libfuse-dev
- libgnutls-dev
- - libncurses5-dev
- libnetcf-dev
- libnl-3-dev
- libnl-route-3-dev
- libnuma-dev
- - libparted0-dev
- - libpcap0.8-dev
+ - libopenwsman-dev
+ - libparted-dev
+ - libpcap-dev
- libpciaccess-dev
- librbd-dev
- libreadline-dev
- libsasl2-dev
+ - libssh2-1-dev
+ - libssl-dev
+ - libtool
- libudev-dev
- libxen-dev
- libxml2-dev
- libxml2-utils
- libyajl-dev
- lvm2
- - uuid-dev
+ - make
+ - nfs-common
+ - open-iscsi
+ - parted
+ - patch
+ - pkg-config
+ - policykit-1
+ - scrub
+ - sheepdog
+ - systemtap-sdt-dev
- xsltproc
- - zlib1g-dev
+ - zfs-fuse
notifications:
irc:
Did you check if travis actually lets you install all these ? They have
to whitelist each individual package that's desired. So if some of these
aren't in the whitelist, adding them here will have no effect IIUC.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
9:09 a.m.
New subject: [libvirt] [PATCH 7/8] travis: Install more build dependencies
On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote:
> @@ -5,37 +5,60 @@ addons:
> apt:
> # Please keep this list sorted alphabetically
> packages:
[...]
> + - zfs-fuse
Did you check if travis actually lets you install all these ? They have
to whitelist each individual package that's desired. So if some of these
aren't in the whitelist, adding them here will have no effect IIUC.
That's kind of insane.
Anyway, it looks like all the packages in the list are allowed,
so whatever :)
--
Andrea Bolognani / Red Hat / Virtualization
9:28 a.m.
New subject: [libvirt] [PATCH 7/8] travis: Install more build dependencies
On Thu, Sep 14, 2017 at 04:09:37PM +0200, Andrea Bolognani wrote:
On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote:
> > @@ -5,37 +5,60 @@ addons:
> > apt:
> > # Please keep this list sorted alphabetically
> > packages:
[...]
> > + - zfs-fuse
>
> Did you check if travis actually lets you install all these ? They have
> to whitelist each individual package that's desired. So if some of these
> aren't in the whitelist, adding them here will have no effect IIUC.
That's kind of insane.
They don't fully trust the security of the container env in which they
populate the packages I guess.
Anyway, it looks like all the packages in the list are allowed,
so whatever :)
Ok,
Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
8:09 a.m.
New subject: [libvirt] [PATCH 8/8] travis: Shuffle sections around
Order them more logically and make sure that stuff that doesn't
need to be modified frequently if at all, such as the notification
settings, are out of the way.
Perform other minor tweaks as well.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 62 +++++++++++++++++++++++++++++++------------------------------
1 file changed, 32 insertions(+), 30 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index f56e6ae6f..f9ee36c17 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,20 @@
sudo: false
language: c
cache: ccache
+
+matrix:
+ include:
+ - compiler: gcc
+ dist: precise
+ - compiler: gcc
+ dist: trusty
+ - compiler: clang
+ dist: precise
+ - compiler: clang
+ dist: trusty
+ - compiler: clang
+ os: osx
+
addons:
apt:
# Please keep this list sorted alphabetically
@@ -60,22 +74,6 @@ addons:
- xsltproc
- zfs-fuse
-notifications:
- irc:
- # The channel name "irc.oftc.net#virt" is encrypted against
libvirt/libvirt
- # to prevent IRC notifications from github forks. This was created using:
- # $ travis encrypt -r "libvirt/libvirt" "irc.oftc.net#virt"
- channels:
- - secure:
"hUPdkLxX7nh75+clpnk4U0XLExLfV9DFKSvQSAUtf5JtDNMslj7AeOCf2wcbkNsEhkiF557odTAnov1s5m1w/yaa56zbjFAh5agzqRKya3QjqsrvlBKw/WuN+l82iMNLLeebTgCPAXrbAbGWH8YmYssp/7+eMsnKaVh84EQQNbMCHlLg6ovE26Fs18mZ6J5RC3OPa1vbv+xkdCHvGg/Oyp4K8bpU7RYyimA56jdxI/OfdTH9HxntHYSzykR7hDbyzZhdIlAUyRKReQVjcV5+R8fdDL/1imyGA/88KTztMeKXpZ5Rf+Ss3vYLZb6qsLLegCZ4AU/q0vvbWxjpZGJZoeyrVpfBTZdYGIzmLTMl9GYXXa/gDwFlbvRDiPDG4TIy6GlMUROinj7KRKEHu1fWRYu012ife5OjidxcwrTnz21vYaCv3AKWPpMPxwIzQPkY1hex9uLLX6z+TrAxxDLF+7UzRT9w2RLFBkLYlj2aDVrLAVb/ynRsxDz5CGzC61FSQVft2e308SkGjdn8YxvguCuXv+N70Fu1cvFyh5XYeHb4fbBRo0Ctzaec78leHlQvRGWKJxXDXRkE2lvvBc7YbBNSAYh7Fs8Y+zY7l7rMxvXdrt3nuaNQhe74V3yhxPDAld66qmAn9TYMmaZW2f5/KKKILLbCa0t2MxiAc6L2OI8="
- on_success: change
- on_failure: always
- email:
- # The list name 'libvirt-ci(a)redhat.com" is encrypted against
libvirt/libvirt
- # to prevent IRC notifications from github forks. This was created using:
- # $ travis encrypt -r "libvirt/libvirt" "libvirt-ci(a)redhat.com"
- recipients:
- - secure:
"QcU9eP96P0RlDNzVRZl/4sxyydPStGzECrpgJhr2IPB/7pHk23yaBrmUsq9S830tB+jwLGma1IscNB8uf7Sf7WY+cYIpfR8v030OffWnaipo/Gcs0dpnlfURWHjOFQI3RJzGEihsqvbwUFOwsM+3IDyO3qdWaiT6cN2Tj9ROlwYCySSX5YWzLyX7arBZ4lp8ESs7ohQaEwp2cegnMP2oGPJJe4SebvlCDjHZbjkU5aEradwUWnRQDJZWTKknpNLArVFxN2/ixp6f/MGY4DmkHoDweio6mHIPN5zTs5Jt32aiX6wDBa+bBa4v8TCRqzhYkQ63ZZhNV8bY5Uf9ufTdyvt96yIANyakd85b1QpMdAX76IyJi1l0/Uub6DTQZAcq3vK7iPjGeTVSpyoXrqTfGy4JxMjqDoocpWvv8ALX1wrYI/HfN2R2Aepw9jModTimOsebYhJ1yMhSt8qnh5AQNftGKL2JBKoA1LWdU2YJ5fO1bGjKNiVEkGFQTPYFWrYCUY5JcT+s5WCzNeMNm8s9na8liYhGl3WtS3rPr5M8bof+BMsBhG2hQ0loduc94x2GkvyhQZUgRbqrwNR+y4hn+rWFC3hBzzyiAULs43vY/PJ+eBdKEf3VAc0MkhQ8GgXGSA61fR6aXYonroI/WnBVItwDmUnnMfSziZXxk09GLl4="
-
git:
depth: 5
submodules: true
@@ -91,10 +89,11 @@ env:
- VIR_TEST_DEBUG=1
before_install:
- - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update &&
brew install gnutls libgcrypt yajl gettext rpcgen ; fi
+ - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update &&
brew install gnutls libgcrypt yajl gettext rpcgen; fi
before_script:
- ./autogen.sh
+
script:
- make -j3
# Many unit tests still fail on macOS, and there are a bunch of issues
@@ -102,19 +101,6 @@ script:
- if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check;
fi
- if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 check; fi
-matrix:
- include:
- - compiler: gcc
- dist: precise
- - compiler: gcc
- dist: trusty
- - compiler: clang
- dist: precise
- - compiler: clang
- dist: trusty
- - compiler: clang
- os: osx
-
after_failure:
- echo
'============================================================================'
- 'if [ -f $(pwd)/tests/test-suite.log ]; then
@@ -122,3 +108,19 @@ after_failure:
else
echo "=== NO LOG FILE FOUND ===";
fi'
+
+notifications:
+ irc:
+ # The channel name "irc.oftc.net#virt" is encrypted against
libvirt/libvirt
+ # to prevent IRC notifications from github forks. This was created using:
+ # $ travis encrypt -r "libvirt/libvirt" "irc.oftc.net#virt"
+ channels:
+ - secure:
"hUPdkLxX7nh75+clpnk4U0XLExLfV9DFKSvQSAUtf5JtDNMslj7AeOCf2wcbkNsEhkiF557odTAnov1s5m1w/yaa56zbjFAh5agzqRKya3QjqsrvlBKw/WuN+l82iMNLLeebTgCPAXrbAbGWH8YmYssp/7+eMsnKaVh84EQQNbMCHlLg6ovE26Fs18mZ6J5RC3OPa1vbv+xkdCHvGg/Oyp4K8bpU7RYyimA56jdxI/OfdTH9HxntHYSzykR7hDbyzZhdIlAUyRKReQVjcV5+R8fdDL/1imyGA/88KTztMeKXpZ5Rf+Ss3vYLZb6qsLLegCZ4AU/q0vvbWxjpZGJZoeyrVpfBTZdYGIzmLTMl9GYXXa/gDwFlbvRDiPDG4TIy6GlMUROinj7KRKEHu1fWRYu012ife5OjidxcwrTnz21vYaCv3AKWPpMPxwIzQPkY1hex9uLLX6z+TrAxxDLF+7UzRT9w2RLFBkLYlj2aDVrLAVb/ynRsxDz5CGzC61FSQVft2e308SkGjdn8YxvguCuXv+N70Fu1cvFyh5XYeHb4fbBRo0Ctzaec78leHlQvRGWKJxXDXRkE2lvvBc7YbBNSAYh7Fs8Y+zY7l7rMxvXdrt3nuaNQhe74V3yhxPDAld66qmAn9TYMmaZW2f5/KKKILLbCa0t2MxiAc6L2OI8="
+ on_success: change
+ on_failure: always
+ email:
+ # The list name 'libvirt-ci(a)redhat.com" is encrypted against
libvirt/libvirt
+ # to prevent IRC notifications from github forks. This was created using:
+ # $ travis encrypt -r "libvirt/libvirt" "libvirt-ci(a)redhat.com"
+ recipients:
+ - secure:
"QcU9eP96P0RlDNzVRZl/4sxyydPStGzECrpgJhr2IPB/7pHk23yaBrmUsq9S830tB+jwLGma1IscNB8uf7Sf7WY+cYIpfR8v030OffWnaipo/Gcs0dpnlfURWHjOFQI3RJzGEihsqvbwUFOwsM+3IDyO3qdWaiT6cN2Tj9ROlwYCySSX5YWzLyX7arBZ4lp8ESs7ohQaEwp2cegnMP2oGPJJe4SebvlCDjHZbjkU5aEradwUWnRQDJZWTKknpNLArVFxN2/ixp6f/MGY4DmkHoDweio6mHIPN5zTs5Jt32aiX6wDBa+bBa4v8TCRqzhYkQ63ZZhNV8bY5Uf9ufTdyvt96yIANyakd85b1QpMdAX76IyJi1l0/Uub6DTQZAcq3vK7iPjGeTVSpyoXrqTfGy4JxMjqDoocpWvv8ALX1wrYI/HfN2R2Aepw9jModTimOsebYhJ1yMhSt8qnh5AQNftGKL2JBKoA1LWdU2YJ5fO1bGjKNiVEkGFQTPYFWrYCUY5JcT+s5WCzNeMNm8s9na8liYhGl3WtS3rPr5M8bof+BMsBhG2hQ0loduc94x2GkvyhQZUgRbqrwNR+y4hn+rWFC3hBzzyiAULs43vY/PJ+eBdKEf3VAc0MkhQ8GgXGSA61fR6aXYonroI/WnBVItwDmUnnMfSziZXxk09GLl4="
--
2.13.5
10:31 a.m.
New subject: [libvirt] [PATCH 8/8] travis: Shuffle sections around
On Thu, Sep 14, 2017 at 03:09:08PM +0200, Andrea Bolognani wrote:
Order them more logically and make sure that stuff that doesn't
need to be modified frequently if at all, such as the notification
settings, are out of the way.
Perform other minor tweaks as well.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.travis.yml | 62 +++++++++++++++++++++++++++++++------------------------------
1 file changed, 32 insertions(+), 30 deletions(-)
Two whitespaces are less than "minor" I'd say :D
Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
10:36 a.m.
New subject: [libvirt] [PATCH 8/8] travis: Shuffle sections around
On Thu, 2017-09-14 at 17:31 +0200, Martin Kletzander wrote:
On Thu, Sep 14, 2017 at 03:09:08PM +0200, Andrea Bolognani wrote:
> Order them more logically and make sure that stuff that doesn't
> need to be modified frequently if at all, such as the notification
> settings, are out of the way.
>
> Perform other minor tweaks as well.
Two whitespaces are less than "minor" I'd say :D
Based on your feedback, I changed it to "very minor" before pushing.
--
Andrea Bolognani / Red Hat / Virtualization
2629
days inactive
2629
days old
24 comments
3 participants
participants (3)
-
Andrea Bolognani -
Daniel P. Berrange -
Martin Kletzander