[libvirt] [PATCH 0/2] util: Fix NAME section for virkey{code, name}-*
Andrea Bolognani (2): keycodemapdb: Update submodule util: Fix NAME section for virkey{code,name}-* src/keycodemapdb | 2 +- src/util/Makefile.inc.am | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- 2.20.1
We need commit 6280c94f306d in order to fix our generated man pages. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/keycodemapdb b/src/keycodemapdb index 16e5b07876..6280c94f30 160000 --- a/src/keycodemapdb +++ b/src/keycodemapdb @@ -1 +1 @@ -Subproject commit 16e5b0787687d8904dad2c026107409eb9bfcb95 +Subproject commit 6280c94f306df6a20bbc100ba15a5a81af0366e6 -- 2.20.1
On Mon, Apr 15, 2019 at 03:21:00PM +0200, Andrea Bolognani wrote:
We need commit 6280c94f306d in order to fix our generated man pages.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
diff --git a/src/keycodemapdb b/src/keycodemapdb index 16e5b07876..6280c94f30 160000 --- a/src/keycodemapdb +++ b/src/keycodemapdb @@ -1 +1 @@ -Subproject commit 16e5b0787687d8904dad2c026107409eb9bfcb95 +Subproject commit 6280c94f306df6a20bbc100ba15a5a81af0366e6 -- 2.20.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Spotted by Lintian (manpage-has-bad-whatis-entry tag). Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/util/Makefile.inc.am | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index f44d3b3b2a..c757f5a6ae 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -321,7 +321,9 @@ util/virkeycode-%.pod: $(srcdir)/keycodemapdb/data/keymaps.csv \ -e 's,\.pod,,'` && \ $(MKDIR_P) util/ && \ $(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \ - --lang pod --varname "Key code values for $$NAME" code-docs \ + --lang pod \ + --varname "virkeycode-$$NAME - Key code values for $$NAME" \ + code-docs \ $(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \ $@-tmp && mv $@-tmp $@ || rm $@-tmp @@ -331,7 +333,9 @@ util/virkeyname-%.pod: $(srcdir)/keycodemapdb/data/keymaps.csv \ -e 's,\.pod,,'` && \ $(MKDIR_P) util/ && \ $(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \ - --lang pod --varname "Key name values for $$NAME" name-docs \ + --lang pod \ + --varname "virkeyname-$$NAME - Key name values for $$NAME" \ + name-docs \ $(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \ $@-tmp && mv $@-tmp $@ || rm $@-tmp -- 2.20.1
On Mon, Apr 15, 2019 at 03:21:01PM +0200, Andrea Bolognani wrote:
Spotted by Lintian (manpage-has-bad-whatis-entry tag).
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/util/Makefile.inc.am | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Makes sense, the two rules above could also have a nicer name like this one, but that's not needed (and neither what this patch is aiming to do). Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index f44d3b3b2a..c757f5a6ae 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -321,7 +321,9 @@ util/virkeycode-%.pod: $(srcdir)/keycodemapdb/data/keymaps.csv \ -e 's,\.pod,,'` && \ $(MKDIR_P) util/ && \ $(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \ - --lang pod --varname "Key code values for $$NAME" code-docs \ + --lang pod \ + --varname "virkeycode-$$NAME - Key code values for $$NAME" \ + code-docs \ $(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \ $@-tmp && mv $@-tmp $@ || rm $@-tmp
@@ -331,7 +333,9 @@ util/virkeyname-%.pod: $(srcdir)/keycodemapdb/data/keymaps.csv \ -e 's,\.pod,,'` && \ $(MKDIR_P) util/ && \ $(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \ - --lang pod --varname "Key name values for $$NAME" name-docs \ + --lang pod \ + --varname "virkeyname-$$NAME - Key name values for $$NAME" \ + name-docs \ $(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \ $@-tmp && mv $@-tmp $@ || rm $@-tmp
-- 2.20.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, 2019-04-15 at 16:10 +0200, Martin Kletzander wrote:
On Mon, Apr 15, 2019 at 03:21:01PM +0200, Andrea Bolognani wrote:
Spotted by Lintian (manpage-has-bad-whatis-entry tag).
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/util/Makefile.inc.am | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Makes sense, the two rules above could also have a nicer name like this one, but that's not needed (and neither what this patch is aiming to do).
I'm not sure I follow... Do you mean passing a different --varname in the util/virkeycodetable_%.h and util/virkeynametable_%.h rules? We can't do that, as --varname is used as the actual variable name when generating C code. Or did you mean something else entirely? -- Andrea Bolognani / Red Hat / Virtualization
On Mon, Apr 15, 2019 at 04:24:27PM +0200, Andrea Bolognani wrote:
On Mon, 2019-04-15 at 16:10 +0200, Martin Kletzander wrote:
On Mon, Apr 15, 2019 at 03:21:01PM +0200, Andrea Bolognani wrote:
Spotted by Lintian (manpage-has-bad-whatis-entry tag).
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/util/Makefile.inc.am | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Makes sense, the two rules above could also have a nicer name like this one, but that's not needed (and neither what this patch is aiming to do).
I'm not sure I follow... Do you mean passing a different --varname in the util/virkeycodetable_%.h and util/virkeynametable_%.h rules? We can't do that, as --varname is used as the actual variable name when generating C code. Or did you mean something else entirely?
Of course... of course I misread the rules (they all look so similar). You are perfectly right.
-- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Martin Kletzander