[libvirt] libvirt-java: change org.libvirt.Error implementing Serializable

Hi java-api-team (-: could you please let org.libvirt.Error implements the serializable interface ? Exceptions (and the content like org.libvirt.Error) should be serializable. I got an exception on my host system connected via RMI to the client-system running libvirt-java (libvirt-java, cvs-snapshot 2008-08-18) like this: ------------------------------------------------ ... cause:java.rmi.UnmarshalException: Error unmarshaling return; nested exception is: java.io.WriteAbortedException: writing aborted; java.io.NotSerializableException: org.libvirt.Error package org.libvirt; ------------------------------------------------ public class Error { VIR_FROM_NONE, /** * Error at Xen hypervisor layer */ VIR_FROM_XEN, ------------------------------------------------ thank you very much regards Danny ------------------------------------------------------------------- DT Netsolution GmbH - Taläckerstr. 30 - D-70437 Stuttgart Geschäftsführer: Daniel Schwager, Stefan Hörz - HRB Stuttgart 19870 Tel: +49-711-849910-32, Fax: -932 - Mailto:daniel.schwager@dtnet.de

On Tue, Aug 19, 2008 at 07:32:50PM +0200, Daniel Schwager wrote:
Hi java-api-team (-:
could you please let org.libvirt.Error implements the serializable interface ? Exceptions (and the content like org.libvirt.Error) should be serializable.
I got an exception on my host system connected via RMI to the client-system running libvirt-java (libvirt-java, cvs-snapshot 2008-08-18) like this:
Any chance you could cook a patch doing this ? Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

Here we are: ### Eclipse Workspace Patch 1.0 #P libvirt-java Index: src/org/libvirt/Error.java =================================================================== RCS file: /data/cvs/libvirt-java/src/org/libvirt/Error.java,v retrieving revision 1.1 diff -u -r1.1 Error.java --- src/org/libvirt/Error.java 18 Jul 2008 14:37:21 -0000 1.1 +++ src/org/libvirt/Error.java 20 Aug 2008 14:22:30 -0000 @@ -1,8 +1,10 @@ package org.libvirt; -public class Error { +import java.io.Serializable; - public static enum ErrorDomain{ +public class Error implements Serializable{ + + public static enum ErrorDomain { VIR_FROM_NONE, /** * Error at Xen hypervisor layer Regards Danny

On Wed, Aug 20, 2008 at 04:22:49PM +0200, Daniel Schwager wrote:
Here we are:
Okay, that didn't applied correctly due to mail reformating of the patch but i applied those manually and commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Schwager
-
Daniel Veillard