[libvirt] [PATCH 0/2] tests: commandtest: handle tcmalloc hacking environment
Nikolay Shirokovskiy (2): tests: commandtest: handle tcmalloc hacking environment tests: fix typo tests/commanddata/test10.log | 3 ++- tests/commanddata/test11.log | 3 ++- tests/commanddata/test12.log | 3 ++- tests/commanddata/test13.log | 3 ++- tests/commanddata/test14.log | 3 ++- tests/commanddata/test15.log | 3 ++- tests/commanddata/test2.log | 3 ++- tests/commanddata/test20.log | 3 ++- tests/commanddata/test21.log | 3 ++- tests/commanddata/test3.log | 3 ++- tests/commanddata/test4.log | 3 ++- tests/commanddata/test5.log | 3 ++- tests/commanddata/test7.log | 3 ++- tests/commanddata/test9.log | 3 ++- tests/commandhelper.c | 11 +++++++++-- tests/commandtest.c | 2 +- 16 files changed, 38 insertions(+), 17 deletions(-) -- 1.8.3.1
If one of the libraries is compiled with tcmalloc then the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to environment at startup and thus break commandtest. --- tests/commandhelper.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 1da2834..0f6ce07 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -94,8 +94,15 @@ int main(int argc, char **argv) { for (i = 0; i < n; i++) { /* Ignore the variables used to instruct the loader into * behaving differently, as they could throw the tests off. */ - if (!STRPREFIX(newenv[i], "LD_")) - fprintf(log, "ENV:%s\n", newenv[i]); + if (STRPREFIX(newenv[i], "LD_")) + continue; + + /* Fix tests if tcmalloc is used in libraries */ + if (STRPREFIX(newenv[i], "GLIBCPP_FORCE_NEW=") || + STRPREFIX(newenv[i], "GLIBCXX_FORCE_NEW=")) + continue; + + fprintf(log, "ENV:%s\n", newenv[i]); } open_max = sysconf(_SC_OPEN_MAX); -- 1.8.3.1
On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote:
If one of the libraries is compiled with tcmalloc then the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to environment at startup and thus break commandtest.
How are they getting those envs into our environment after we clean it out ? We strongly aim to prevent any non-whitelisted env variable leakage into children we spawn, so I would really like to kill these env vars instead of changin the test.
--- tests/commandhelper.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 1da2834..0f6ce07 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -94,8 +94,15 @@ int main(int argc, char **argv) { for (i = 0; i < n; i++) { /* Ignore the variables used to instruct the loader into * behaving differently, as they could throw the tests off. */ - if (!STRPREFIX(newenv[i], "LD_")) - fprintf(log, "ENV:%s\n", newenv[i]); + if (STRPREFIX(newenv[i], "LD_")) + continue; + + /* Fix tests if tcmalloc is used in libraries */ + if (STRPREFIX(newenv[i], "GLIBCPP_FORCE_NEW=") || + STRPREFIX(newenv[i], "GLIBCXX_FORCE_NEW=")) + continue; + + fprintf(log, "ENV:%s\n", newenv[i]); }
open_max = sysconf(_SC_OPEN_MAX); -- 1.8.3.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 17.11.2017 16:24, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote:
If one of the libraries is compiled with tcmalloc then the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to environment at startup and thus break commandtest.
How are they getting those envs into our environment after we clean it out ? We strongly aim to prevent any non-whitelisted env variable leakage into children we spawn, so I would really like to kill these env vars instead of changin the test.
They inserted at process startup I guess [1]. They are cleared out by commandtest but visible in commandhelper. [1] https://github.com/gperftools/gperftools/blob/6e3a702fb9c86eb450f22b326ecbce...
--- tests/commandhelper.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 1da2834..0f6ce07 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -94,8 +94,15 @@ int main(int argc, char **argv) { for (i = 0; i < n; i++) { /* Ignore the variables used to instruct the loader into * behaving differently, as they could throw the tests off. */ - if (!STRPREFIX(newenv[i], "LD_")) - fprintf(log, "ENV:%s\n", newenv[i]); + if (STRPREFIX(newenv[i], "LD_")) + continue; + + /* Fix tests if tcmalloc is used in libraries */ + if (STRPREFIX(newenv[i], "GLIBCPP_FORCE_NEW=") || + STRPREFIX(newenv[i], "GLIBCXX_FORCE_NEW=")) + continue; + + fprintf(log, "ENV:%s\n", newenv[i]); }
open_max = sysconf(_SC_OPEN_MAX); -- 1.8.3.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Regards, Daniel
On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote:
On 17.11.2017 16:24, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote:
If one of the libraries is compiled with tcmalloc then the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to environment at startup and thus break commandtest.
How are they getting those envs into our environment after we clean it out ? We strongly aim to prevent any non-whitelisted env variable leakage into children we spawn, so I would really like to kill these env vars instead of changin the test.
They inserted at process startup I guess [1]. They are cleared out by commandtest but visible in commandhelper.
Hmm, so is comandhelper getting linked to tcmalloc by mistake then ? If so, how easy is it to stop it being linked
[1] https://github.com/gperftools/gperftools/blob/6e3a702fb9c86eb450f22b326ecbce...
--- tests/commandhelper.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 1da2834..0f6ce07 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -94,8 +94,15 @@ int main(int argc, char **argv) { for (i = 0; i < n; i++) { /* Ignore the variables used to instruct the loader into * behaving differently, as they could throw the tests off. */ - if (!STRPREFIX(newenv[i], "LD_")) - fprintf(log, "ENV:%s\n", newenv[i]); + if (STRPREFIX(newenv[i], "LD_")) + continue; + + /* Fix tests if tcmalloc is used in libraries */ + if (STRPREFIX(newenv[i], "GLIBCPP_FORCE_NEW=") || + STRPREFIX(newenv[i], "GLIBCXX_FORCE_NEW=")) + continue; + + fprintf(log, "ENV:%s\n", newenv[i]); }
open_max = sysconf(_SC_OPEN_MAX); -- 1.8.3.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Regards, Daniel
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 17.11.2017 16:40, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote:
On 17.11.2017 16:24, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote:
If one of the libraries is compiled with tcmalloc then the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to environment at startup and thus break commandtest.
How are they getting those envs into our environment after we clean it out ? We strongly aim to prevent any non-whitelisted env variable leakage into children we spawn, so I would really like to kill these env vars instead of changin the test.
They inserted at process startup I guess [1]. They are cleared out by commandtest but visible in commandhelper.
Hmm, so is comandhelper getting linked to tcmalloc by mistake then ? If so, how easy is it to stop it being linked
It is not liked directly. In my case the chain is libdevmapper.so -> libudev.so -> libtcmalloc.so. It is distro specific but I guess other can step across this issue and for a different chain. One just need to link on of the libraries libvirt uses to tcmalloc.
[1] https://github.com/gperftools/gperftools/blob/6e3a702fb9c86eb450f22b326ecbce...
--- tests/commandhelper.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 1da2834..0f6ce07 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -94,8 +94,15 @@ int main(int argc, char **argv) { for (i = 0; i < n; i++) { /* Ignore the variables used to instruct the loader into * behaving differently, as they could throw the tests off. */ - if (!STRPREFIX(newenv[i], "LD_")) - fprintf(log, "ENV:%s\n", newenv[i]); + if (STRPREFIX(newenv[i], "LD_")) + continue; + + /* Fix tests if tcmalloc is used in libraries */ + if (STRPREFIX(newenv[i], "GLIBCPP_FORCE_NEW=") || + STRPREFIX(newenv[i], "GLIBCXX_FORCE_NEW=")) + continue; + + fprintf(log, "ENV:%s\n", newenv[i]); }
open_max = sysconf(_SC_OPEN_MAX); -- 1.8.3.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Regards, Daniel
Regards, Daniel
On Fri, Nov 17, 2017 at 04:45:27PM +0300, Nikolay Shirokovskiy wrote:
On 17.11.2017 16:40, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote:
On 17.11.2017 16:24, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote:
If one of the libraries is compiled with tcmalloc then the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to environment at startup and thus break commandtest.
How are they getting those envs into our environment after we clean it out ? We strongly aim to prevent any non-whitelisted env variable leakage into children we spawn, so I would really like to kill these env vars instead of changin the test.
They inserted at process startup I guess [1]. They are cleared out by commandtest but visible in commandhelper.
Hmm, so is comandhelper getting linked to tcmalloc by mistake then ? If so, how easy is it to stop it being linked
It is not liked directly. In my case the chain is libdevmapper.so -> libudev.so -> libtcmalloc.so. It is distro specific but I guess other can step across this issue and for a different chain. One just need to link on of the libraries libvirt uses to tcmalloc.
Ah I see. I think this smells like a bug in the tests/Makefile.am The commandhelper binary should not link to anything at all except for libc (and perhaps gnulib, but possibly even that is redundant) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 17.11.2017 16:47, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:45:27PM +0300, Nikolay Shirokovskiy wrote:
On 17.11.2017 16:40, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote:
On 17.11.2017 16:24, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote:
If one of the libraries is compiled with tcmalloc then the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to environment at startup and thus break commandtest.
How are they getting those envs into our environment after we clean it out ? We strongly aim to prevent any non-whitelisted env variable leakage into children we spawn, so I would really like to kill these env vars instead of changin the test.
They inserted at process startup I guess [1]. They are cleared out by commandtest but visible in commandhelper.
Hmm, so is comandhelper getting linked to tcmalloc by mistake then ? If so, how easy is it to stop it being linked
It is not liked directly. In my case the chain is libdevmapper.so -> libudev.so -> libtcmalloc.so. It is distro specific but I guess other can step across this issue and for a different chain. One just need to link on of the libraries libvirt uses to tcmalloc.
Ah I see. I think this smells like a bug in the tests/Makefile.am
Ahh, this is fixed upstream already by eae746b2d the way you suggest ))
On Fri, Nov 17, 2017 at 04:53:13PM +0300, Nikolay Shirokovskiy wrote:
On 17.11.2017 16:47, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:45:27PM +0300, Nikolay Shirokovskiy wrote: Ah I see. I think this smells like a bug in the tests/Makefile.am
Ahh, this is fixed upstream already by eae746b2d the way you suggest ))
Hahahah, i totally forgot that it was me who fixed it too :-) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--- tests/commanddata/test10.log | 3 ++- tests/commanddata/test11.log | 3 ++- tests/commanddata/test12.log | 3 ++- tests/commanddata/test13.log | 3 ++- tests/commanddata/test14.log | 3 ++- tests/commanddata/test15.log | 3 ++- tests/commanddata/test2.log | 3 ++- tests/commanddata/test20.log | 3 ++- tests/commanddata/test21.log | 3 ++- tests/commanddata/test3.log | 3 ++- tests/commanddata/test4.log | 3 ++- tests/commanddata/test5.log | 3 ++- tests/commanddata/test7.log | 3 ++- tests/commanddata/test9.log | 3 ++- tests/commandtest.c | 2 +- 15 files changed, 29 insertions(+), 15 deletions(-) diff --git a/tests/commanddata/test10.log b/tests/commanddata/test10.log index 6b22786..6f0fdb5 100644 --- a/tests/commanddata/test10.log +++ b/tests/commanddata/test10.log @@ -4,8 +4,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test11.log b/tests/commanddata/test11.log index 6b22786..6f0fdb5 100644 --- a/tests/commanddata/test11.log +++ b/tests/commanddata/test11.log @@ -4,8 +4,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test12.log b/tests/commanddata/test12.log index 703e6da..bb3103c 100644 --- a/tests/commanddata/test12.log +++ b/tests/commanddata/test12.log @@ -2,8 +2,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test13.log b/tests/commanddata/test13.log index 703e6da..bb3103c 100644 --- a/tests/commanddata/test13.log +++ b/tests/commanddata/test13.log @@ -2,8 +2,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test14.log b/tests/commanddata/test14.log index 703e6da..bb3103c 100644 --- a/tests/commanddata/test14.log +++ b/tests/commanddata/test14.log @@ -2,8 +2,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test15.log b/tests/commanddata/test15.log index edb2fc3..f2b0d5e 100644 --- a/tests/commanddata/test15.log +++ b/tests/commanddata/test15.log @@ -2,8 +2,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test2.log b/tests/commanddata/test2.log index 703e6da..bb3103c 100644 --- a/tests/commanddata/test2.log +++ b/tests/commanddata/test2.log @@ -2,8 +2,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test20.log b/tests/commanddata/test20.log index a0475e6..0c14074 100644 --- a/tests/commanddata/test20.log +++ b/tests/commanddata/test20.log @@ -3,8 +3,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test21.log b/tests/commanddata/test21.log index 703e6da..bb3103c 100644 --- a/tests/commanddata/test21.log +++ b/tests/commanddata/test21.log @@ -2,8 +2,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test3.log b/tests/commanddata/test3.log index f44400b..cfa0979 100644 --- a/tests/commanddata/test3.log +++ b/tests/commanddata/test3.log @@ -2,8 +2,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test4.log b/tests/commanddata/test4.log index 6cd2095..f170be2 100644 --- a/tests/commanddata/test4.log +++ b/tests/commanddata/test4.log @@ -2,8 +2,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test5.log b/tests/commanddata/test5.log index f801dca..ae54189 100644 --- a/tests/commanddata/test5.log +++ b/tests/commanddata/test5.log @@ -1,7 +1,8 @@ ENV:HOME=/home/test ENV:LC_ALL=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test7.log b/tests/commanddata/test7.log index e30efe7..fb4a754 100644 --- a/tests/commanddata/test7.log +++ b/tests/commanddata/test7.log @@ -1,8 +1,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:LC_ALL=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commanddata/test9.log b/tests/commanddata/test9.log index e9e1611..d59d8f4 100644 --- a/tests/commanddata/test9.log +++ b/tests/commanddata/test9.log @@ -10,8 +10,9 @@ ENV:DISPLAY=:0.0 ENV:HOME=/home/test ENV:HOSTNAME=test ENV:LANG=C -ENV:LOGNAME=testTMPDIR=/tmp +ENV:LOGNAME=test ENV:PATH=/usr/bin:/bin +ENV:TMPDIR=/tmp ENV:USER=test FD:0 FD:1 diff --git a/tests/commandtest.c b/tests/commandtest.c index 1aa3e45..ad81c2a 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -843,7 +843,7 @@ static const char *const newenv[] = { "LANG=C", "HOME=/home/test", "USER=test", - "LOGNAME=test" + "LOGNAME=test", "TMPDIR=/tmp", "DISPLAY=:0.0", NULL -- 1.8.3.1
On Fri, Nov 17, 2017 at 04:17:38PM +0300, Nikolay Shirokovskiy wrote:
--- tests/commanddata/test10.log | 3 ++- tests/commanddata/test11.log | 3 ++- tests/commanddata/test12.log | 3 ++- tests/commanddata/test13.log | 3 ++- tests/commanddata/test14.log | 3 ++- tests/commanddata/test15.log | 3 ++- tests/commanddata/test2.log | 3 ++- tests/commanddata/test20.log | 3 ++- tests/commanddata/test21.log | 3 ++- tests/commanddata/test3.log | 3 ++- tests/commanddata/test4.log | 3 ++- tests/commanddata/test5.log | 3 ++- tests/commanddata/test7.log | 3 ++- tests/commanddata/test9.log | 3 ++- tests/commandtest.c | 2 +- 15 files changed, 29 insertions(+), 15 deletions(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 11/17/2017 02:25 PM, Daniel P. Berrange wrote:
On Fri, Nov 17, 2017 at 04:17:38PM +0300, Nikolay Shirokovskiy wrote:
--- tests/commanddata/test10.log | 3 ++- tests/commanddata/test11.log | 3 ++- tests/commanddata/test12.log | 3 ++- tests/commanddata/test13.log | 3 ++- tests/commanddata/test14.log | 3 ++- tests/commanddata/test15.log | 3 ++- tests/commanddata/test2.log | 3 ++- tests/commanddata/test20.log | 3 ++- tests/commanddata/test21.log | 3 ++- tests/commanddata/test3.log | 3 ++- tests/commanddata/test4.log | 3 ++- tests/commanddata/test5.log | 3 ++- tests/commanddata/test7.log | 3 ++- tests/commanddata/test9.log | 3 ++- tests/commandtest.c | 2 +- 15 files changed, 29 insertions(+), 15 deletions(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Pushed now. Michal
participants (3)
-
Daniel P. Berrange -
Michal Privoznik -
Nikolay Shirokovskiy