Re: [libvirt] [PATCH]: pass flags to all virDomain*DefParse* functions

On Thu, Jan 08, 2009 at 05:02:14PM +0100, Jim Meyering wrote: [..snip..]
Hi Guido,
libvirt doesn't build right now, because of this:
xm_internal.c:2288: error: too few arguments to function 'virDomainDefParseString' xm_internal.c:2530: error: too few arguments to function 'virDomainDeviceDefParse' xm_internal.c:2619: error: too few arguments to function 'virDomainDeviceDefParse' xend_internal.c:3860: error: too few arguments to function 'virDomainDeviceDefParse' xend_internal.c:3950: error: too few arguments to function 'virDomainDeviceDefParse' Thought I had tested this with the Xen driver enabled, but seems I didn't. Sorry! Attached patch fixes the build and passes "make check". Thanks for pointing this out! -- Guido

On Thu, Jan 08, 2009 at 06:29:13PM +0100, Guido Günther wrote:
On Thu, Jan 08, 2009 at 05:02:14PM +0100, Jim Meyering wrote: [..snip..]
Hi Guido,
libvirt doesn't build right now, because of this:
xm_internal.c:2288: error: too few arguments to function 'virDomainDefParseString' xm_internal.c:2530: error: too few arguments to function 'virDomainDeviceDefParse' xm_internal.c:2619: error: too few arguments to function 'virDomainDeviceDefParse' xend_internal.c:3860: error: too few arguments to function 'virDomainDeviceDefParse' xend_internal.c:3950: error: too few arguments to function 'virDomainDeviceDefParse' Thought I had tested this with the Xen driver enabled, but seems I didn't. Sorry! Attached patch fixes the build and passes "make check". Thanks for pointing this out! I've pushed the patch to fix the compilation of the Xen driver. -- Guido
participants (1)
-
Guido Günther