Re: [PATCH-for-11.0] qapi: Remove deprecated SchemaInfoEnumMember::values field
On Mon, Mar 23, 2026 at 20:19:45 -0700, Pierrick Bouvier wrote:
On 3/23/26 8:21 AM, Philippe Mathieu-Daudé wrote:
SchemaInfoEnumMember::values field has been deprecated for more than 5 years (see commit 75ecee72625 "qapi: Enable enum member introspection to show more than name"), it should be safe enough to remove.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 7 +++++++ qapi/introspect.json | 12 +----------- scripts/qapi/introspect.py | 3 +-- 4 files changed, 9 insertions(+), 19 deletions(-)
By curiosity, is this patch goal is simply to remove a deprecated feature/code, or does it unlock something beyond it? No judgment here, that's a genuine question, and both are valid reasons!
This patch also shaves off a nice 1.3k lines of duplicate data from the prettified reply from query-qmp-schema. (In libvirt we capture dumps of the schema which we use for internal testing as well as validation that the monitor command handlers and commandline generators (by proxy) don't use deprecated and or non-existent members.)
Looks good to me, to the limit of my qapi knowledge :). Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
On behalf of libvirt (and since I didn't look at the code at all; just at the output): ACKed-by: Peter Krempa <pkrempa@redhat.com>
Peter Krempa <pkrempa@redhat.com> writes:
On Mon, Mar 23, 2026 at 20:19:45 -0700, Pierrick Bouvier wrote:
On 3/23/26 8:21 AM, Philippe Mathieu-Daudé wrote:
SchemaInfoEnumMember::values field has been deprecated for more than 5 years (see commit 75ecee72625 "qapi: Enable enum member introspection to show more than name"), it should be safe enough to remove.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 7 +++++++ qapi/introspect.json | 12 +----------- scripts/qapi/introspect.py | 3 +-- 4 files changed, 9 insertions(+), 19 deletions(-)
By curiosity, is this patch goal is simply to remove a deprecated feature/code, or does it unlock something beyond it? No judgment here, that's a genuine question, and both are valid reasons!
This patch also shaves off a nice 1.3k lines of duplicate data from the prettified reply from query-qmp-schema.
(In libvirt we capture dumps of the schema which we use for internal testing as well as validation that the monitor command handlers and commandline generators (by proxy) don't use deprecated and or non-existent members.)
Looks good to me, to the limit of my qapi knowledge :). Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
On behalf of libvirt (and since I didn't look at the code at all; just at the output):
ACKed-by: Peter Krempa <pkrempa@redhat.com>
Thank you, Peter! Reviewed-by: Markus Armbruster <armbru@redhat.com>
participants (2)
-
Markus Armbruster -
Peter Krempa