[libvirt] [PATCH 0/3] some small fix for guest SEV related code
*** BLURB HERE *** Luyao Huang (3): qemu: correct the ret value qemu: improve the debug message when preparing SEV guest docs: remove extra space in the SEV xml element example docs/formatdomain.html.in | 10 +++++----- src/qemu/qemu_process.c | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) -- 1.8.3.1
Set the return value to 0 when everything work as expected Signed-off-by: Luyao Huang <lhuang@redhat.com> --- src/qemu/qemu_process.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 93fd6ba..631254d 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5842,6 +5842,7 @@ qemuProcessSEVCreateFile(const char *configDir, goto cleanup; } + ret = 0; cleanup: VIR_FREE(configFile); return ret; -- 1.8.3.1
Use 'preparing' instead of 'prepare' like other place in qemu_process.c. Signed-off-by: Luyao Huang <lhuang@redhat.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 631254d..2967568 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5860,7 +5860,7 @@ qemuProcessPrepareSEVGuestInput(virDomainObjPtr vm) if (!sev) return 0; - VIR_DEBUG("Prepare SEV guest"); + VIR_DEBUG("Preparing SEV guest"); if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SEV_GUEST)) { virReportError(VIR_ERR_INTERNAL_ERROR, -- 1.8.3.1
Signed-off-by: Luyao Huang <lhuang@redhat.com> --- docs/formatdomain.html.in | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 7e710d7..89672a0 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -8481,11 +8481,11 @@ qemu-kvm -net nic,model=? /dev/null <domain> ... <launchSecurity type='sev'> - <policy> 0x0001 </policy> - <cbitpos> 47 </cbitpos> - <reducedPhysBits> 1 </reducedPhysBits> - <dhCert> RBBBSDDD=FDDCCCDDDG </dhCert> - <session> AAACCCDD=FFFCCCDSDS </session> + <policy>0x0001</policy> + <cbitpos>47</cbitpos> + <reducedPhysBits>1</reducedPhysBits> + <dhCert>RBBBSDDD=FDDCCCDDDG</dhCert> + <session>AAACCCDD=FFFCCCDSDS</session> </launchSecurity> ... </domain> -- 1.8.3.1
On Wed, Jun 20, 2018 at 05:05:01PM +0800, Luyao Huang wrote:
*** BLURB HERE ***
Luyao Huang (3): qemu: correct the ret value qemu: improve the debug message when preparing SEV guest docs: remove extra space in the SEV xml element example
docs/formatdomain.html.in | 10 +++++----- src/qemu/qemu_process.c | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Erik Skultety <eskultet@redhat.com> PS: I'll reword the commit messages a bit before pushing. Thanks, Erik
Thanks for your quick review ! BR, Luyao ----- Original Message ----- From: "Erik Skultety" <eskultet@redhat.com> To: "Luyao Huang" <lhuang@redhat.com> Cc: libvir-list@redhat.com Sent: Wednesday, June 20, 2018 7:23:26 PM Subject: Re: [libvirt] [PATCH 0/3] some small fix for guest SEV related code On Wed, Jun 20, 2018 at 05:05:01PM +0800, Luyao Huang wrote:
*** BLURB HERE ***
Luyao Huang (3): qemu: correct the ret value qemu: improve the debug message when preparing SEV guest docs: remove extra space in the SEV xml element example
docs/formatdomain.html.in | 10 +++++----- src/qemu/qemu_process.c | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Erik Skultety <eskultet@redhat.com> PS: I'll reword the commit messages a bit before pushing. Thanks, Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Erik Skultety -
Luyao Huang