[libvirt] [PATCH] apparmor: Fix use of uninitialized random_data

Without this, virt-aa-helper would segfault in -c or -r commands. --- src/security/virt-aa-helper.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 4561bb9..b484a20 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -42,6 +42,7 @@ #include "pci.h" #include "virfile.h" #include "configmake.h" +#include "virrandom.h" #define VIR_FROM_THIS VIR_FROM_SECURITY @@ -1182,6 +1183,9 @@ main(int argc, char **argv) memset(ctl, 0, sizeof(vahControl)); + if (virRandomInitialize(time(NULL) ^ getpid()) < 0) + vah_error(ctl, 1, _("could not initialize random generator")); + if (vahParseArgv(ctl, argc, argv) != 0) vah_error(ctl, 1, _("could not parse arguments")); -- 1.7.8.4

On Fri, Jan 27, 2012 at 11:44:51 +0100, Michal Privoznik wrote:
On 27.01.2012 11:19, Jiri Denemark wrote:
Without this, virt-aa-helper would segfault in -c or -r commands. --- src/security/virt-aa-helper.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
ACK
Thanks, pushed. Jirka
participants (2)
-
Jiri Denemark
-
Michal Privoznik