[libvirt] networkxml2argvtest fails to compile

Hi all, Building libvirt 0.9.3 from source with --without-network, make check fails with: CC networkxml2xmltest.o CCLD networkxml2xmltest CC networkxml2argvtest.o make[2]: *** No rule to make target `../src/libvirt_driver_network.la', needed by `networkxml2argvtest'. Stop. make[2]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make: *** [check-recursive] Error 1 Kind regards, Ruben

2011/7/5 Ruben Kerkhof <ruben@rubenkerkhof.com>:
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check fails with:
CC networkxml2xmltest.o CCLD networkxml2xmltest CC networkxml2argvtest.o make[2]: *** No rule to make target `../src/libvirt_driver_network.la', needed by `networkxml2argvtest'. Stop. make[2]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make: *** [check-recursive] Error 1
Kind regards,
Ruben
The attached patch fixes this. -- Matthias Bolte http://photron.blogspot.com

On Tue, Jul 5, 2011 at 12:45, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
2011/7/5 Ruben Kerkhof <ruben@rubenkerkhof.com>:
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check fails with:
CC networkxml2xmltest.o CCLD networkxml2xmltest CC networkxml2argvtest.o make[2]: *** No rule to make target `../src/libvirt_driver_network.la', needed by `networkxml2argvtest'. Stop. make[2]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make: *** [check-recursive] Error 1
Kind regards,
Ruben
The attached patch fixes this.
This fails for me on a clean git checkout with: CC networkxml2xmltest.o CCLD networkxml2xmltest CCLD networkxml2argvtest /usr/lib/gcc/x86_64-redhat-linux/4.4.5/../../../../lib64/crt1.o: In function `_start': (.text+0x20): undefined reference to `main' collect2: ld returned 1 exit status make[2]: *** [networkxml2argvtest] Error 1 make[2]: Leaving directory `/home/ruben/src/libvirt/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/ruben/src/libvirt/tests' make: *** [check-recursive] Error 1 Ruben

On 07/05/2011 06:45 PM, Matthias Bolte wrote:
2011/7/5 Ruben Kerkhof<ruben@rubenkerkhof.com>:
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check fails with:
CC networkxml2xmltest.o CCLD networkxml2xmltest CC networkxml2argvtest.o make[2]: *** No rule to make target `../src/libvirt_driver_network.la', needed by `networkxml2argvtest'. Stop. make[2]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make: *** [check-recursive] Error 1
Kind regards,
Ruben The attached patch fixes this.
It also needs: if WITH_NETWORK check_PROGRAMS += networkxml2argvtest endif if WITH_NETWORK TESTS += networkxml2argvtest endif ACK with this fix. Regards Osier
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

2011/7/5 Osier Yang <jyang@redhat.com>:
On 07/05/2011 06:45 PM, Matthias Bolte wrote:
2011/7/5 Ruben Kerkhof <ruben@rubenkerkhof.com>:
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check fails with:
CC networkxml2xmltest.o CCLD networkxml2xmltest CC networkxml2argvtest.o make[2]: *** No rule to make target `../src/libvirt_driver_network.la', needed by `networkxml2argvtest'. Stop. make[2]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make: *** [check-recursive] Error 1
Kind regards,
Ruben
The attached patch fixes this.
It also needs:
if WITH_NETWORK check_PROGRAMS += networkxml2argvtest endif
if WITH_NETWORK TESTS += networkxml2argvtest endif
ACK with this fix.
Regards Osier
Ah, yes. I should have done a make clean in between to notice this. Thanks, I pushed the patch with your additions. -- Matthias Bolte http://photron.blogspot.com
participants (3)
-
Matthias Bolte
-
Osier Yang
-
Ruben Kerkhof