Re: [libvirt] [libvirt-tck 3/3] Add test case for daemon hook testing

updated, and patch attached. - Osier ----- "Daniel P. Berrange" <berrange@redhat.com> wrote:
On Tue, Oct 19, 2010 at 03:41:55AM -0400, Osier wrote:
attach updated patch for daemon hook testing..
replaced "cat" with "slurp", corrected typos.
From 963158c860d5415117e70b67458745c2b4cf9c13 Mon Sep 17 00:00:00 2001 From: Osier Yang <jyang@redhat.com> Date: Tue, 19 Oct 2010 15:32:17 +0800 Subject: [libvirt-tck 4/4] Add test case for daemon hook testing
Validate daemon hook is invoked correctly while start, stop, restart, reload libvirtd --- scripts/hooks/051-daemon-hook.t | 153 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 153 insertions(+), 0 deletions(-) create mode 100644 scripts/hooks/051-daemon-hook.t
This still needs to skip execution if the Sys::Virt::TCK connection object is not lxc:/// or qemu:///system
Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

On Fri, Oct 22, 2010 at 02:32:20AM -0400, Osier wrote:
updated, and patch attached.
From 8d2a62528a7820939c4d7c86dd10cbf16ea5d751 Mon Sep 17 00:00:00 2001 From: Osier Yang <jyang@redhat.com> Date: Fri, 22 Oct 2010 14:40:13 +0800 Subject: [TCK] Skip daemon hook testing if URI is not qemu:///system or lxc:/// MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit
Skip the case execution if Sys::Virt::TCK connection object is not qemu:///system or lxc:/// --- scripts/hooks/051-daemon-hook.t | 178 +++++++++++++++++++++------------------ 1 files changed, 96 insertions(+), 82 deletions(-)
ACK, this looks good now Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
participants (2)
-
Daniel P. Berrange
-
Osier