On Tue, Jan 20, 2009 at 05:36:46PM -0800, john.levon(a)sun.com wrote: This is already initialized earlier on in the remoteOpen() method so I don't think this chunk could have be the cause of the crashes. if (VIR_ALLOC(priv) < 0) { error (conn, VIR_ERR_NO_MEMORY, _("struct private_data")); return VIR_DRV_OPEN_ERROR; } if (virMutexInit(&priv->lock) < 0) { error(conn, VIR_ERR_INTERNAL_ERROR, _("cannot initialize mutex")); VIR_FREE(priv); return VIR_DRV_OPEN_ERROR; } remoteDriverLock(priv); priv->localUses = 1; priv->watch = -1; The remoteNetworkOpen, remoteStorageOpen and remoteDevMonOpen methods have scenarios where we'd miss the initialization, and thus need a patch. But since you have adapted the Xen driver to always go via libvirtd, you shouldn't hit those scenarios either. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|