[Libvir] [PATCH] lots of warnings removed - libvirt can now compile with -Werror
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
For a completely clean build you need to also apply the previous patch[1].
Rich.
[1] https://www.redhat.com/archives/libvir-list/2007-March/msg00030.html
and see also Mark's reply.
--
Emerging Technologies, Red Hat http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421
"[Negative numbers] darken the very whole doctrines of the equations
and make dark of the things which are in their nature excessively
obvious and simple" (Francis Maseres FRS, mathematician, 1759)
Attachments:
- smime.p7s (application/x-pkcs7-signature — 3.2 KB)
- libvirt-werror.patch (text/x-patch — 14.4 KB)
I've just checked this on Fedora Rawhide, and it works there too.
Rich.
--
Emerging Technologies, Red Hat http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421
"[Negative numbers] darken the very whole doctrines of the equations
and make dark of the things which are in their nature excessively
obvious and simple" (Francis Maseres FRS, mathematician, 1759)
Hi Rich,
Good stuff, looks fine to commit to me.
Just a nitpick:
On Fri, 2007-03-02 at 15:00 +0000, Richard W.M. Jones wrote:
- activeNames = vshMalloc(ctl, sizeof(int) * maxactive);
+ activeNames = vshMalloc(ctl, sizeof (char *) * maxactive);
^
- qsort(&activeNames[0], maxactive, sizeof(int),
namesorter);
+ qsort(activeNames, maxactive, sizeof (char *), namesorter);
^
Extra whitespace here ...
Cheers,
Mark.
On Mon, Mar 05, 2007 at 09:18:49AM +0000, Mark McLoughlin wrote:
Hi Rich,
Good stuff, looks fine to commit to me.
Just a nitpick:
On Fri, 2007-03-02 at 15:00 +0000, Richard W.M. Jones wrote:
> - activeNames = vshMalloc(ctl, sizeof(int) * maxactive);
> + activeNames = vshMalloc(ctl, sizeof (char *) * maxactive);
^
> - qsort(&activeNames[0], maxactive, sizeof(int), namesorter);
> + qsort(activeNames, maxactive, sizeof (char *), namesorter);
^
Extra whitespace here ...
I commited Rich's patch with a handful of whitespace tweaks applied too.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
6505
days inactive
6509
days old
3 comments
3 participants
tags (0)
participants (3)
-
Daniel P. Berrange -
Mark McLoughlin -
Richard W.M. Jones