[Libvir] [PATCH] lots of warnings removed - libvirt can now compile with -Werror
For a completely clean build you need to also apply the previous patch[1]. Rich. [1] https://www.redhat.com/archives/libvir-list/2007-March/msg00030.html and see also Mark's reply. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)
I've just checked this on Fedora Rawhide, and it works there too. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)
Hi Rich, Good stuff, looks fine to commit to me. Just a nitpick: On Fri, 2007-03-02 at 15:00 +0000, Richard W.M. Jones wrote:
- activeNames = vshMalloc(ctl, sizeof(int) * maxactive); + activeNames = vshMalloc(ctl, sizeof (char *) * maxactive); ^
- qsort(&activeNames[0], maxactive, sizeof(int), namesorter); + qsort(activeNames, maxactive, sizeof (char *), namesorter); ^
Extra whitespace here ... Cheers, Mark.
On Mon, Mar 05, 2007 at 09:18:49AM +0000, Mark McLoughlin wrote:
Hi Rich, Good stuff, looks fine to commit to me.
Just a nitpick:
On Fri, 2007-03-02 at 15:00 +0000, Richard W.M. Jones wrote:
- activeNames = vshMalloc(ctl, sizeof(int) * maxactive); + activeNames = vshMalloc(ctl, sizeof (char *) * maxactive); ^
- qsort(&activeNames[0], maxactive, sizeof(int), namesorter); + qsort(activeNames, maxactive, sizeof (char *), namesorter); ^
Extra whitespace here ...
I commited Rich's patch with a handful of whitespace tweaks applied too. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
participants (3)
-
Daniel P. Berrange -
Mark McLoughlin -
Richard W.M. Jones