[libvirt] [PATCH 0/2] Fix a couple of minor doc issues
The QE processing of the feature found a couple of minor doc type issues so just fix an error message and add the command to the man page. Both are rather trivial, but I can wait for reviews rather than push directly as trivial.. John Ferlan (2): conf: Fix typo in error message virsh: Add source-protocol-ver to pool-define-as docs src/conf/storage_conf.c | 2 +- tools/virsh.pod | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.20.1
Fix obvious typo. Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/conf/storage_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 3ae0d7ab77..29988c36c4 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -666,7 +666,7 @@ virStoragePoolDefParseSource(xmlXPathContextPtr ctxt, } if (virStrToLong_uip(ver, NULL, 0, &source->protocolVer) < 0) { virReportError(VIR_ERR_XML_ERROR, - _("storage pool protocol ver '%s' is malformaed"), + _("storage pool protocol ver '%s' is malformed"), ver); goto cleanup; } -- 2.20.1
Commit a3dbaa364 neglected to add the source-protocol-ver to the pool-define-as command. Signed-off-by: John Ferlan <jferlan@redhat.com> --- tools/virsh.pod | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh.pod b/tools/virsh.pod index afc1684db0..6bfeac6492 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4013,6 +4013,7 @@ from the XML I<file>. [I<--source-name name>] [I<--target path>] [I<--source-format format>] [I<--auth-type authtype> I<--auth-username username> [I<--secret-usage usage> | I<--secret-uuid uuid>]] +[I<--source-protocol-ver ver>] [[I<--adapter-name name>] | [I<--adapter-wwnn> I<--adapter-wwpn>] [I<--adapter-parent parent>]] [I<--print-xml>] -- 2.20.1
On 4/29/19 3:00 PM, John Ferlan wrote:
The QE processing of the feature found a couple of minor doc type issues so just fix an error message and add the command to the man page.
Both are rather trivial, but I can wait for reviews rather than push directly as trivial..
John Ferlan (2): conf: Fix typo in error message virsh: Add source-protocol-ver to pool-define-as docs
src/conf/storage_conf.c | 2 +- tools/virsh.pod | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
ACK and safe for freeze. Michal
participants (2)
-
John Ferlan -
Michal Privoznik