It's more accurate this way. https://bugzilla.redhat.com/show_bug.cgi?id=1638889 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; --- docs/manpages/virsh.rst | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index aa3a0095fe3d..4a1500e68628 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -3346,17 +3346,17 @@ bind to for incoming disks traffic. Currently it is supported only by QEMU. Optional *disks-uri* can also be specified (mutually exclusive with *disks-port*) to specify what the remote hypervisor should bind/connect to when migrating disks. This can be *tcp://address:port* to specify a listen address -(which overrides *--listen-address* for the disk migration) and a port or -*unix:///path/to/socket* in case you need the disk migration to happen over a -UNIX socket with that specified path. In this case you need to make sure the -same socket path is accessible to both source and destination hypervisors and -connecting to the socket on the source (after hypervisor creates it on the -destination) will actually connect to the destination. If you are using SELinux -(at least on the source host) you need to make sure the socket on the source is -accessible to libvirtd/QEMU for connection. Libvirt cannot change the context -of the existing socket because it is different from the file representation of -the socket and the context is chosen by its creator (usually by using -*setsockcreatecon{,_raw}()* functions). +(which overrides *--migrate-uri* and *--listen-address* for the disk migration) +and a port or *unix:///path/to/socket* in case you need the disk migration to +happen over a UNIX socket with that specified path. In this case you need to +make sure the same socket path is accessible to both source and destination +hypervisors and connecting to the socket on the source (after hypervisor creates +it on the destination) will actually connect to the destination. If you are +using SELinux (at least on the source host) you need to make sure the socket on +the source is accessible to libvirtd/QEMU for connection. Libvirt cannot change +the context of the existing socket because it is different from the file +representation of the socket and the context is chosen by its creator (usually +by using *setsockcreatecon{,_raw}()* functions). migrate-compcache -- 2.29.2

On Wed, Dec 16, 2020 at 12:19:28 +0100, Martin Kletzander wrote: Is this to check that NBD is used? I think that's not enough as VIR_MIGRATE_NON_SHARED_DISK/INC doesn't necessarily guarantee that NBD is used. It also depends on whether TUNELLED and other possible flags are in the mix too. We might need a helper function for that. Also 'nmigrate_disks' AFAIK requires that VIR_MIGRATE_NON_SHARED_DISK is used so it's redundant here. Please don't split error messages it's hard to grep for them if they are split. Spurious newline addition.