[libvirt] [PATCH 0/2] qemu: Parameter usage cleanups
Here be patches. Ján Tomko (2): qemuDomainSetSchedulerParametersFlags: use the value_ul variable qemuDomainSetInterfaceParameters: use the temporary params variable src/qemu/qemu_driver.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) -- 2.13.0
We assign the unsigned long value of the currently processed parameter to a temporary value_ul variable. Use it consistently in all cases. --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index cdb727b55..74da8c3d0 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10118,7 +10118,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr dom, } if (persistentDef) - persistentDefCopy->cputune.period = params[i].value.ul; + persistentDefCopy->cputune.period = value_ul; } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_VCPU_QUOTA)) { SCHED_RANGE_CHECK(value_l, VIR_DOMAIN_SCHEDULER_VCPU_QUOTA, @@ -10158,7 +10158,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr dom, } if (persistentDef) - persistentDefCopy->cputune.period = params[i].value.ul; + persistentDefCopy->cputune.period = value_ul; } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_GLOBAL_QUOTA)) { SCHED_RANGE_CHECK(value_l, VIR_DOMAIN_SCHEDULER_GLOBAL_QUOTA, @@ -10240,7 +10240,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr dom, } if (persistentDef) - persistentDefCopy->cputune.iothread_period = params[i].value.ul; + persistentDefCopy->cputune.iothread_period = value_ul; } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_IOTHREAD_QUOTA)) { SCHED_RANGE_CHECK(value_l, VIR_DOMAIN_SCHEDULER_IOTHREAD_QUOTA, -- 2.13.0
On Fri, Jul 07, 2017 at 15:20:48 +0200, Ján Tomko wrote:
We assign the unsigned long value of the currently processed parameter to a temporary value_ul variable. Use it consistently in all cases. --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
ACK
We have a temporary pointer to the currently processed parameter. Use it to save three bytes per use. --- src/qemu/qemu_driver.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 74da8c3d0..a512f2199 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10993,22 +10993,22 @@ qemuDomainSetInterfaceParameters(virDomainPtr dom, virTypedParameterPtr param = ¶ms[i]; if (STREQ(param->field, VIR_DOMAIN_BANDWIDTH_IN_AVERAGE)) { - bandwidth->in->average = params[i].value.ui; + bandwidth->in->average = param->value.ui; inboundSpecified = true; } else if (STREQ(param->field, VIR_DOMAIN_BANDWIDTH_IN_PEAK)) { - bandwidth->in->peak = params[i].value.ui; + bandwidth->in->peak = param->value.ui; } else if (STREQ(param->field, VIR_DOMAIN_BANDWIDTH_IN_BURST)) { - bandwidth->in->burst = params[i].value.ui; + bandwidth->in->burst = param->value.ui; } else if (STREQ(param->field, VIR_DOMAIN_BANDWIDTH_IN_FLOOR)) { - bandwidth->in->floor = params[i].value.ui; + bandwidth->in->floor = param->value.ui; inboundSpecified = true; } else if (STREQ(param->field, VIR_DOMAIN_BANDWIDTH_OUT_AVERAGE)) { - bandwidth->out->average = params[i].value.ui; + bandwidth->out->average = param->value.ui; outboundSpecified = true; } else if (STREQ(param->field, VIR_DOMAIN_BANDWIDTH_OUT_PEAK)) { - bandwidth->out->peak = params[i].value.ui; + bandwidth->out->peak = param->value.ui; } else if (STREQ(param->field, VIR_DOMAIN_BANDWIDTH_OUT_BURST)) { - bandwidth->out->burst = params[i].value.ui; + bandwidth->out->burst = param->value.ui; } } -- 2.13.0
On Fri, Jul 07, 2017 at 15:20:49 +0200, Ján Tomko wrote:
We have a temporary pointer to the currently processed parameter. Use it to save three bytes per use. --- src/qemu/qemu_driver.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
ACK
participants (2)
-
Ján Tomko -
Peter Krempa