[libvirt] [PATCH] pyhton: Don't link against libvirt_util.la
As we already link with libvirt.la which contains libvirt_utils.la. Double linking causes global symbols to be presented twice and thus confusion. This partially reverts c700613b8d463212d142c97108b7a2352e23e559 --- python/Makefile.am | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/python/Makefile.am b/python/Makefile.am index 9b791d7..0305bcc 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -41,11 +41,9 @@ EXTRA_DIST = \ if WITH_PYTHON mylibs = \ $(top_builddir)/src/libvirt.la \ - $(top_builddir)/src/libvirt_util.la \ $(top_builddir)/gnulib/lib/libgnu.la myqemulibs = \ $(top_builddir)/src/libvirt-qemu.la \ - $(top_builddir)/src/libvirt_util.la \ $(top_builddir)/gnulib/lib/libgnu.la all-local: libvirt.py libvirt_qemu.py -- 1.7.3.4
On Tue, Feb 07, 2012 at 01:41:52PM +0100, Michal Privoznik wrote:
As we already link with libvirt.la which contains libvirt_utils.la. Double linking causes global symbols to be presented twice and thus confusion. This partially reverts c700613b8d463212d142c97108b7a2352e23e559 --- python/Makefile.am | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/python/Makefile.am b/python/Makefile.am index 9b791d7..0305bcc 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -41,11 +41,9 @@ EXTRA_DIST = \ if WITH_PYTHON mylibs = \ $(top_builddir)/src/libvirt.la \ - $(top_builddir)/src/libvirt_util.la \ $(top_builddir)/gnulib/lib/libgnu.la myqemulibs = \ $(top_builddir)/src/libvirt-qemu.la \ - $(top_builddir)/src/libvirt_util.la \ $(top_builddir)/gnulib/lib/libgnu.la
all-local: libvirt.py libvirt_qemu.py
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 07.02.2012 13:49, Daniel P. Berrange wrote:
On Tue, Feb 07, 2012 at 01:41:52PM +0100, Michal Privoznik wrote:
As we already link with libvirt.la which contains libvirt_utils.la. Double linking causes global symbols to be presented twice and thus confusion. This partially reverts c700613b8d463212d142c97108b7a2352e23e559 --- python/Makefile.am | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/python/Makefile.am b/python/Makefile.am index 9b791d7..0305bcc 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -41,11 +41,9 @@ EXTRA_DIST = \ if WITH_PYTHON mylibs = \ $(top_builddir)/src/libvirt.la \ - $(top_builddir)/src/libvirt_util.la \ $(top_builddir)/gnulib/lib/libgnu.la myqemulibs = \ $(top_builddir)/src/libvirt-qemu.la \ - $(top_builddir)/src/libvirt_util.la \ $(top_builddir)/gnulib/lib/libgnu.la
all-local: libvirt.py libvirt_qemu.py
ACK
Daniel
Thanks, pushed. Michal
On 02/07/2012 08:41 PM, Michal Privoznik wrote:
As we already link with libvirt.la which contains libvirt_utils.la. Double linking causes global symbols to be presented twice and thus confusion. This partially reverts c700613b8d463212d142c97108b7a2352e23e559 --- python/Makefile.am | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/python/Makefile.am b/python/Makefile.am index 9b791d7..0305bcc 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -41,11 +41,9 @@ EXTRA_DIST = \ if WITH_PYTHON mylibs = \ $(top_builddir)/src/libvirt.la \ - $(top_builddir)/src/libvirt_util.la \ $(top_builddir)/gnulib/lib/libgnu.la myqemulibs = \ $(top_builddir)/src/libvirt-qemu.la \ - $(top_builddir)/src/libvirt_util.la \ $(top_builddir)/gnulib/lib/libgnu.la
all-local: libvirt.py libvirt_qemu.py
According to the following patch There are still need another patch to use free() call. https://www.redhat.com/archives/libvir-list/2012-February/msg00141.html
participants (3)
-
Daniel P. Berrange -
Guannan Ren -
Michal Privoznik