[PATCH V2 1/1] qemuProcessEventSubmit : rename vm to event->vm
In error case, free event->vm instead of vm. This makes it easier for the reader to understand what we should free. Signed-off-by: Shaleen Bathla <shaleen.bathla@oracle.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ee9f0784d3a3..83b553418068 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -287,7 +287,7 @@ qemuProcessEventSubmit(virDomainObj *vm, event->data = data; if (virThreadPoolSendJob(driver->workerPool, 0, event) < 0) { - virObjectUnref(vm); + virObjectUnref(event->vm); qemuProcessEventFree(event); } } -- 2.31.1
ping On Tue, Jan 17, 2023 at 02:52:13PM +0530, Shaleen Bathla wrote:
In error case, free event->vm instead of vm. This makes it easier for the reader to understand what we should free.
Signed-off-by: Shaleen Bathla <shaleen.bathla@oracle.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ee9f0784d3a3..83b553418068 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -287,7 +287,7 @@ qemuProcessEventSubmit(virDomainObj *vm, event->data = data;
if (virThreadPoolSendJob(driver->workerPool, 0, event) < 0) { - virObjectUnref(vm); + virObjectUnref(event->vm); qemuProcessEventFree(event); } } -- 2.31.1
On 1/17/23 10:22, Shaleen Bathla wrote:
In error case, free event->vm instead of vm. This makes it easier for the reader to understand what we should free.
Signed-off-by: Shaleen Bathla <shaleen.bathla@oracle.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I tweaked the commit message a bit and pushed. Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
participants (2)
-
Michal Prívozník -
Shaleen Bathla