10:50 a.m.
Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD
to simplify mutex management.
V1: https://listman.redhat.com/archives/libvir-list/2022-March/229144.html
V2: https://listman.redhat.com/archives/libvir-list/2022-March/229329.html
Changes since V2:
* Rewrote virQEMUDriverGetCapabilities, thanks Michal!
* Added VIR_WITH_MUTEX_LOCK_GUARD to nwfilterConnectNumOfNWFilters
* Other patches were reviewed and pushed.
Tim Wiederhake (2):
nwfilter_driver: Use automatic mutex management
qemu_conf: Use automatic memory management
src/nwfilter/nwfilter_driver.c | 94 +++++++++++++++-------------------
src/qemu/qemu_conf.c | 63 ++++++++---------------
2 files changed, 61 insertions(+), 96 deletions(-)
--
2.31.1
10:50 a.m.
New subject: [libvirt PATCH v3 1/2] nwfilter_driver: Use automatic mutex management
Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
---
src/nwfilter/nwfilter_driver.c | 94 +++++++++++++++-------------------
1 file changed, 40 insertions(+), 54 deletions(-)
diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c
index c5f0169623..cac73c50e5 100644
--- a/src/nwfilter/nwfilter_driver.c
+++ b/src/nwfilter/nwfilter_driver.c
@@ -57,15 +57,6 @@ static int nwfilterStateReload(void);
static virMutex driverMutex = VIR_MUTEX_INITIALIZER;
-static void nwfilterDriverLock(void)
-{
- virMutexLock(&driverMutex);
-}
-static void nwfilterDriverUnlock(void)
-{
- virMutexUnlock(&driverMutex);
-}
-
#ifdef WITH_FIREWALLD
static void
@@ -204,6 +195,7 @@ nwfilterStateInitialize(bool privileged,
virStateInhibitCallback callback G_GNUC_UNUSED,
void *opaque G_GNUC_UNUSED)
{
+ VIR_LOCK_GUARD lock = virLockGuardLock(&driverMutex);
GDBusConnection *sysbus = NULL;
if (root != NULL) {
@@ -230,8 +222,6 @@ nwfilterStateInitialize(bool privileged,
if (!privileged)
return VIR_DRV_STATE_INIT_SKIPPED;
- nwfilterDriverLock();
-
driver->stateDir = g_strdup(RUNSTATEDIR "/libvirt/nwfilter");
if (g_mkdir_with_parents(driver->stateDir, S_IRWXU) < 0) {
@@ -290,13 +280,10 @@ nwfilterStateInitialize(bool privileged,
if (virNWFilterBuildAll(driver, false) < 0)
goto error;
- nwfilterDriverUnlock();
-
return VIR_DRV_STATE_INIT_COMPLETE;
error:
- nwfilterDriverUnlock();
- nwfilterStateCleanup();
+ nwfilterStateCleanupLocked();
return VIR_DRV_STATE_INIT_ERROR;
@@ -335,16 +322,15 @@ nwfilterStateReload(void)
/* shut down all threads -- they will be restarted if necessary */
virNWFilterLearnThreadsTerminate(true);
- nwfilterDriverLock();
- virNWFilterWriteLockFilterUpdates();
-
- virNWFilterObjListLoadAllConfigs(driver->nwfilters, driver->configDir);
+ VIR_WITH_MUTEX_LOCK_GUARD(&driverMutex) {
+ virNWFilterWriteLockFilterUpdates();
- virNWFilterUnlockFilterUpdates();
+ virNWFilterObjListLoadAllConfigs(driver->nwfilters, driver->configDir);
- virNWFilterBuildAll(driver, false);
+ virNWFilterUnlockFilterUpdates();
- nwfilterDriverUnlock();
+ virNWFilterBuildAll(driver, false);
+ }
return 0;
}
@@ -422,13 +408,13 @@ static virNWFilterPtr
nwfilterLookupByUUID(virConnectPtr conn,
const unsigned char *uuid)
{
- virNWFilterObj *obj;
+ virNWFilterObj *obj = NULL;
virNWFilterDef *def;
virNWFilterPtr nwfilter = NULL;
- nwfilterDriverLock();
- obj = nwfilterObjFromNWFilter(uuid);
- nwfilterDriverUnlock();
+ VIR_WITH_MUTEX_LOCK_GUARD(&driverMutex) {
+ obj = nwfilterObjFromNWFilter(uuid);
+ }
if (!obj)
return NULL;
@@ -449,13 +435,13 @@ static virNWFilterPtr
nwfilterLookupByName(virConnectPtr conn,
const char *name)
{
- virNWFilterObj *obj;
+ virNWFilterObj *obj = NULL;
virNWFilterDef *def;
virNWFilterPtr nwfilter = NULL;
- nwfilterDriverLock();
- obj = virNWFilterObjListFindByName(driver->nwfilters, name);
- nwfilterDriverUnlock();
+ VIR_WITH_MUTEX_LOCK_GUARD(&driverMutex) {
+ obj = virNWFilterObjListFindByName(driver->nwfilters, name);
+ }
if (!obj) {
virReportError(VIR_ERR_NO_NWFILTER,
@@ -478,14 +464,15 @@ nwfilterLookupByName(virConnectPtr conn,
static int
nwfilterConnectNumOfNWFilters(virConnectPtr conn)
{
- int ret;
+ int ret = -1;
if (virConnectNumOfNWFiltersEnsureACL(conn) < 0)
return -1;
- nwfilterDriverLock();
- ret = virNWFilterObjListNumOfNWFilters(driver->nwfilters, conn,
- virConnectNumOfNWFiltersCheckACL);
- nwfilterDriverUnlock();
+ VIR_WITH_MUTEX_LOCK_GUARD(&driverMutex) {
+ ret = virNWFilterObjListNumOfNWFilters(driver->nwfilters, conn,
+ virConnectNumOfNWFiltersCheckACL);
+ }
+
return ret;
}
@@ -495,16 +482,17 @@ nwfilterConnectListNWFilters(virConnectPtr conn,
char **const names,
int maxnames)
{
- int nnames;
+ int nnames = -1;
if (virConnectListNWFiltersEnsureACL(conn) < 0)
return -1;
- nwfilterDriverLock();
- nnames = virNWFilterObjListGetNames(driver->nwfilters, conn,
- virConnectListNWFiltersCheckACL,
- names, maxnames);
- nwfilterDriverUnlock();
+ VIR_WITH_MUTEX_LOCK_GUARD(&driverMutex) {
+ nnames = virNWFilterObjListGetNames(driver->nwfilters, conn,
+ virConnectListNWFiltersCheckACL,
+ names, maxnames);
+ }
+
return nnames;
}
@@ -514,17 +502,17 @@ nwfilterConnectListAllNWFilters(virConnectPtr conn,
virNWFilterPtr **nwfilters,
unsigned int flags)
{
- int ret;
+ int ret = -1;
virCheckFlags(0, -1);
if (virConnectListAllNWFiltersEnsureACL(conn) < 0)
return -1;
- nwfilterDriverLock();
- ret = virNWFilterObjListExport(conn, driver->nwfilters, nwfilters,
- virConnectListAllNWFiltersCheckACL);
- nwfilterDriverUnlock();
+ VIR_WITH_MUTEX_LOCK_GUARD(&driverMutex) {
+ ret = virNWFilterObjListExport(conn, driver->nwfilters, nwfilters,
+ virConnectListAllNWFiltersCheckACL);
+ }
return ret;
}
@@ -535,6 +523,7 @@ nwfilterDefineXMLFlags(virConnectPtr conn,
const char *xml,
unsigned int flags)
{
+ VIR_LOCK_GUARD lock = virLockGuardLock(&driverMutex);
virNWFilterDef *def;
virNWFilterObj *obj = NULL;
virNWFilterDef *objdef;
@@ -549,7 +538,6 @@ nwfilterDefineXMLFlags(virConnectPtr conn,
return NULL;
}
- nwfilterDriverLock();
virNWFilterWriteLockFilterUpdates();
if (!(def = virNWFilterDefParseString(xml, flags)))
@@ -576,7 +564,6 @@ nwfilterDefineXMLFlags(virConnectPtr conn,
virNWFilterObjUnlock(obj);
virNWFilterUnlockFilterUpdates();
- nwfilterDriverUnlock();
return nwfilter;
}
@@ -592,11 +579,11 @@ nwfilterDefineXML(virConnectPtr conn,
static int
nwfilterUndefine(virNWFilterPtr nwfilter)
{
+ VIR_LOCK_GUARD lock = virLockGuardLock(&driverMutex);
virNWFilterObj *obj;
virNWFilterDef *def;
int ret = -1;
- nwfilterDriverLock();
virNWFilterWriteLockFilterUpdates();
if (!(obj = nwfilterObjFromNWFilter(nwfilter->uuid)))
@@ -625,7 +612,6 @@ nwfilterUndefine(virNWFilterPtr nwfilter)
virNWFilterObjUnlock(obj);
virNWFilterUnlockFilterUpdates();
- nwfilterDriverUnlock();
return ret;
}
@@ -634,15 +620,15 @@ static char *
nwfilterGetXMLDesc(virNWFilterPtr nwfilter,
unsigned int flags)
{
- virNWFilterObj *obj;
+ virNWFilterObj *obj = NULL;
virNWFilterDef *def;
char *ret = NULL;
virCheckFlags(0, NULL);
- nwfilterDriverLock();
- obj = nwfilterObjFromNWFilter(nwfilter->uuid);
- nwfilterDriverUnlock();
+ VIR_WITH_MUTEX_LOCK_GUARD(&driverMutex) {
+ obj = nwfilterObjFromNWFilter(nwfilter->uuid);
+ }
if (!obj)
return NULL;
--
2.31.1
10:50 a.m.
New subject: [libvirt PATCH v3 2/2] qemu_conf: Use automatic memory management
Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
---
src/qemu/qemu_conf.c | 63 +++++++++++++++-----------------------------
1 file changed, 21 insertions(+), 42 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 81449b8b77..c22cf79cbe 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -85,17 +85,6 @@ static int virQEMUConfigOnceInit(void)
VIR_ONCE_GLOBAL_INIT(virQEMUConfig);
-static void
-qemuDriverLock(virQEMUDriver *driver)
-{
- virMutexLock(&driver->lock);
-}
-static void
-qemuDriverUnlock(virQEMUDriver *driver)
-{
- virMutexUnlock(&driver->lock);
-}
-
#ifndef DEFAULT_LOADER_NVRAM
# define DEFAULT_LOADER_NVRAM \
"/usr/share/OVMF/OVMF_CODE.fd:/usr/share/OVMF/OVMF_VARS.fd:" \
@@ -1279,11 +1268,9 @@ virQEMUDriverConfigSetDefaults(virQEMUDriverConfig *cfg)
virQEMUDriverConfig *virQEMUDriverGetConfig(virQEMUDriver *driver)
{
- virQEMUDriverConfig *conf;
- qemuDriverLock(driver);
- conf = virObjectRef(driver->config);
- qemuDriverUnlock(driver);
- return conf;
+ VIR_LOCK_GUARD lock = virLockGuardLock(&driver->lock);
+
+ return virObjectRef(driver->config);
}
virDomainXMLOption *
@@ -1303,16 +1290,13 @@ virQEMUDriverCreateXMLConf(virQEMUDriver *driver,
virCPUDef *
virQEMUDriverGetHostCPU(virQEMUDriver *driver)
{
- virCPUDef *hostcpu;
-
- qemuDriverLock(driver);
+ virCPUDef *hostcpu = NULL;
- if (!driver->hostcpu)
- driver->hostcpu = virCPUProbeHost(virArchFromHost());
-
- hostcpu = driver->hostcpu;
-
- qemuDriverUnlock(driver);
+ VIR_WITH_MUTEX_LOCK_GUARD(&driver->lock) {
+ if (!driver->hostcpu)
+ driver->hostcpu = virCPUProbeHost(virArchFromHost());
+ hostcpu = driver->hostcpu;
+ }
if (hostcpu)
virCPUDefRef(hostcpu);
@@ -1389,32 +1373,27 @@ virCaps *virQEMUDriverCreateCapabilities(virQEMUDriver *driver)
* Returns: a reference to a virCaps *instance or NULL
*/
virCaps *virQEMUDriverGetCapabilities(virQEMUDriver *driver,
- bool refresh)
+ bool refresh)
{
- virCaps *ret = NULL;
if (refresh) {
virCaps *caps = NULL;
if ((caps = virQEMUDriverCreateCapabilities(driver)) == NULL)
return NULL;
- qemuDriverLock(driver);
- virObjectUnref(driver->caps);
- driver->caps = caps;
- } else {
- qemuDriverLock(driver);
-
- if (driver->caps == NULL ||
- driver->caps->nguests == 0) {
- VIR_DEBUG("Capabilities didn't detect any guests. Forcing a "
- "refresh.");
- qemuDriverUnlock(driver);
- return virQEMUDriverGetCapabilities(driver, true);
+ VIR_WITH_MUTEX_LOCK_GUARD(&driver->lock) {
+ virObjectUnref(driver->caps);
+ driver->caps = caps;
+ return virObjectRef(driver->caps);
}
}
- ret = virObjectRef(driver->caps);
- qemuDriverUnlock(driver);
- return ret;
+ VIR_WITH_MUTEX_LOCK_GUARD(&driver->lock) {
+ if (driver->caps && driver->caps->nguests > 0)
+ return virObjectRef(driver->caps);
+ }
+
+ VIR_DEBUG("Capabilities didn't detect any guests. Forcing a
refresh.");
+ return virQEMUDriverGetCapabilities(driver, true);
}
--
2.31.1
11:10 a.m.
On 3/17/22 16:50, Tim Wiederhake wrote:
Use the recently implemented VIR_LOCK_GUARD and
VIR_WITH_MUTEX_LOCK_GUARD
to simplify mutex management.
V1: https://listman.redhat.com/archives/libvir-list/2022-March/229144.html
V2: https://listman.redhat.com/archives/libvir-list/2022-March/229329.html
Changes since V2:
* Rewrote virQEMUDriverGetCapabilities, thanks Michal!
* Added VIR_WITH_MUTEX_LOCK_GUARD to nwfilterConnectNumOfNWFilters
* Other patches were reviewed and pushed.
Tim Wiederhake (2):
nwfilter_driver: Use automatic mutex management
qemu_conf: Use automatic memory management
src/nwfilter/nwfilter_driver.c | 94 +++++++++++++++-------------------
src/qemu/qemu_conf.c | 63 ++++++++---------------
2 files changed, 61 insertions(+), 96 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal
972
days inactive
972
days old
3 comments
2 participants
participants (2)
-
Michal Prívozník -
Tim Wiederhake