[libvirt] [PATCH] build: avoid pod2man on tarball
virt-sanlock-cleanup.8 has static contents (no dependency on configure), but is generated by pod2man (a perl dependency that maintainers must have, but which ordinary tarball users need not have). Therefore, ensure that it is always part of the tarball, even though it is only conditionally installed. This is similar to commit 6db98a2d4b, but made simpler by the fact that the .8 page is static content. * tools/Makefile.am (EXTRA_DIST): Add virt-sanlock-cleanup.8. --- I've tested this with 'make distcheck', when configured --without-sanlock. It resolves my action item from: https://www.redhat.com/archives/libvir-list/2011-June/msg01464.html tools/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index ed38396..62c275e 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -13,6 +13,7 @@ EXTRA_DIST = \ virt-xml-validate.in \ virt-pki-validate.in \ virt-sanlock-cleanup.in \ + virt-sanlock-cleanup.8 \ virsh.pod \ libvirt-guests.init.sh \ libvirt-guests.sysconf -- 1.7.4.4
On Tue, Jun 28, 2011 at 09:58:02PM -0600, Eric Blake wrote:
virt-sanlock-cleanup.8 has static contents (no dependency on configure), but is generated by pod2man (a perl dependency that maintainers must have, but which ordinary tarball users need not have). Therefore, ensure that it is always part of the tarball, even though it is only conditionally installed.
This is similar to commit 6db98a2d4b, but made simpler by the fact that the .8 page is static content.
* tools/Makefile.am (EXTRA_DIST): Add virt-sanlock-cleanup.8. ---
I've tested this with 'make distcheck', when configured --without-sanlock. It resolves my action item from: https://www.redhat.com/archives/libvir-list/2011-June/msg01464.html
tools/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am index ed38396..62c275e 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -13,6 +13,7 @@ EXTRA_DIST = \ virt-xml-validate.in \ virt-pki-validate.in \ virt-sanlock-cleanup.in \ + virt-sanlock-cleanup.8 \ virsh.pod \ libvirt-guests.init.sh \ libvirt-guests.sysconf
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 06/29/2011 03:36 AM, Daniel P. Berrange wrote:
On Tue, Jun 28, 2011 at 09:58:02PM -0600, Eric Blake wrote:
virt-sanlock-cleanup.8 has static contents (no dependency on configure), but is generated by pod2man (a perl dependency that maintainers must have, but which ordinary tarball users need not have). Therefore, ensure that it is always part of the tarball, even though it is only conditionally installed.
This is similar to commit 6db98a2d4b, but made simpler by the fact that the .8 page is static content.
* tools/Makefile.am (EXTRA_DIST): Add virt-sanlock-cleanup.8.
ACK
Thanks; pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Daniel P. Berrange -
Eric Blake