[libvirt] [PATCH] virsh dump should not be live
Live dumps are much less likely to produce usable cores. They also trigger a Xen bug that crashes xend. Signed-off-by: John Levon <john.levon@sun.com> Index: src/xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.211 diff -u -r1.211 xend_internal.c --- src/xend_internal.c 28 Aug 2008 11:59:07 -0000 1.211 +++ src/xend_internal.c 28 Aug 2008 14:10:45 -0000 @@ -3037,7 +3037,7 @@ if (domain->id < 0) return(-1); return xend_op(domain->conn, domain->name, "op", "dump", "file", filename, - "live", "1", "crash", "0", NULL); + "live", "0", "crash", "0", NULL); } /**
On Thu, Aug 28, 2008 at 03:12:06PM +0100, John Levon wrote:
Live dumps are much less likely to produce usable cores. They also trigger a Xen bug that crashes xend.
Better still, we should make use of the '@flags: extra flags, currently unused' parameter to virDomainDumpCore() to allow requesting of live vs offline dumps, since both have valid use cases. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Thu, Aug 28, 2008 at 03:17:06PM +0100, Daniel P. Berrange wrote:
On Thu, Aug 28, 2008 at 03:12:06PM +0100, John Levon wrote:
Live dumps are much less likely to produce usable cores. They also trigger a Xen bug that crashes xend.
Better still, we should make use of the '@flags: extra flags, currently unused' parameter to virDomainDumpCore() to allow requesting of live vs offline dumps, since both have valid use cases.
Well that would be nice, I agree, but I'm fixing a bug here not adding features. I really don't have time to go off and implement extra stuff right now. regards john
On Thu, Aug 28, 2008 at 03:12:06PM +0100, John Levon wrote:
Live dumps are much less likely to produce usable cores. They also trigger a Xen bug that crashes xend.
+1. As John says, fixes the immediate bug. We can add features later. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
On Thu, Aug 28, 2008 at 04:21:14PM +0100, Richard W.M. Jones wrote:
On Thu, Aug 28, 2008 at 03:12:06PM +0100, John Levon wrote:
Live dumps are much less likely to produce usable cores. They also trigger a Xen bug that crashes xend.
+1. As John says, fixes the immediate bug. We can add features later.
Agreed, so patch applied, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (4)
-
Daniel P. Berrange -
Daniel Veillard -
John Levon -
Richard W.M. Jones