[libvirt] [PATCH] qemu: Reset hasManagedSave after removing a corrupted image

When starting a domain with managed save image, we try to restore it first. If the image is corrupted, we silently unlink it and just normally start the domain. At this point the domain has no managed save image, yet we did not reset the hasManagedSave flag. https://bugzilla.redhat.com/show_bug.cgi?id=1460962 Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 32a416f9e..74fdfdb0f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7256,6 +7256,7 @@ qemuDomainObjStart(virConnectPtr conn, } else { VIR_WARN("Ignoring incomplete managed state %s", managed_save); priv->job.current->operation = op; + vm->hasManagedSave = false; } } } -- 2.14.2

On Tue, Oct 24, 2017 at 10:39:53 +0200, Jiri Denemark wrote:
When starting a domain with managed save image, we try to restore it first. If the image is corrupted, we silently unlink it and just normally start the domain. At this point the domain has no managed save image, yet we did not reset the hasManagedSave flag.
https://bugzilla.redhat.com/show_bug.cgi?id=1460962
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+)
ACK
participants (2)
-
Jiri Denemark
-
Peter Krempa