[libvirt] [PATCH] network: kill dead store

* src/network/bridge_driver.c (networkDefine): Kill dead store. --- src/network/bridge_driver.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index b7ee880..217cdcc 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1490,14 +1490,13 @@ static virNetworkPtr networkDefine(virConnectPtr conn, const char *xml) { virNetworkDefPtr def; virNetworkObjPtr network = NULL; virNetworkPtr ret = NULL; - int dupNet; networkDriverLock(driver); if (!(def = virNetworkDefParseString(xml))) goto cleanup; - if ((dupNet = virNetworkObjIsDuplicate(&driver->networks, def, 0)) < 0) + if (virNetworkObjIsDuplicate(&driver->networks, def, 0) < 0) goto cleanup; if (virNetworkSetBridgeName(&driver->networks, def, 1)) -- 1.7.2

On Fri, Jul 30, 2010 at 10:00:46AM -0600, Eric Blake wrote:
* src/network/bridge_driver.c (networkDefine): Kill dead store. --- src/network/bridge_driver.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index b7ee880..217cdcc 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1490,14 +1490,13 @@ static virNetworkPtr networkDefine(virConnectPtr conn, const char *xml) { virNetworkDefPtr def; virNetworkObjPtr network = NULL; virNetworkPtr ret = NULL; - int dupNet;
networkDriverLock(driver);
if (!(def = virNetworkDefParseString(xml))) goto cleanup;
- if ((dupNet = virNetworkObjIsDuplicate(&driver->networks, def, 0)) < 0) + if (virNetworkObjIsDuplicate(&driver->networks, def, 0) < 0) goto cleanup;
if (virNetworkSetBridgeName(&driver->networks, def, 1))
ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

On 07/30/2010 11:09 AM, Daniel Veillard wrote:
- int dupNet;
networkDriverLock(driver);
if (!(def = virNetworkDefParseString(xml))) goto cleanup;
- if ((dupNet = virNetworkObjIsDuplicate(&driver->networks, def, 0)) < 0) + if (virNetworkObjIsDuplicate(&driver->networks, def, 0) < 0) goto cleanup;
if (virNetworkSetBridgeName(&driver->networks, def, 1))
ACK,
Thanks; pushed along with the trivial hunks from the qemu patch. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Daniel Veillard
-
Eric Blake