[Libvir] [PATCH] cleanup of virDeviceMode
Since this was raised yesterday about the purity of the libvirt API w.r.t. Xen specifics, we don't actually use the virDeviceMode nor have any possible use for them at the API level since basically this kind of informations is always rovided as part of an XML and never as an int/enum. So I propose to just remove them from the headers and API, I don't see how an application could use the enum but maybe I missed one, in which case please tell me :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Daniel Veillard wrote:
Since this was raised yesterday about the purity of the libvirt API w.r.t. Xen specifics, we don't actually use the virDeviceMode nor have any possible use for them at the API level since basically this kind of informations is always rovided as part of an XML and never as an int/enum. So I propose to just remove them from the headers and API, I don't see how an application could use the enum but maybe I missed one, in which case please tell me :-)
+1. Rich.
On Tue, Jul 17, 2007 at 03:48:56PM +0100, Richard W.M. Jones wrote:
Daniel Veillard wrote:
Since this was raised yesterday about the purity of the libvirt API w.r.t. Xen specifics, we don't actually use the virDeviceMode nor have any possible use for them at the API level since basically this kind of informations is always rovided as part of an XML and never as an int/enum. So I propose to just remove them from the headers and API, I don't see how an application could use the enum but maybe I missed one, in which case please tell me :-)
+1.
Okay, commited, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Veillard -
Richard W.M. Jones