[libvirt] [libvirt-glib][PATCH] libvirt-glib-1.0.pc.in: Correctly mark variable
In the pkg-config file for libvirt-glib we have a typo: Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@ Noticed the missing '@' after LIBVIRT_LIBS? Well, I just did. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- libvirt-glib-1.0.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-glib-1.0.pc.in b/libvirt-glib-1.0.pc.in index 1e8956d..d00be9f 100644 --- a/libvirt-glib-1.0.pc.in +++ b/libvirt-glib-1.0.pc.in @@ -8,5 +8,5 @@ Version: @VERSION@ Description: libvirt glib library Requires: glib-2.0 Libs: -L${libdir} -lvirt-glib-1.0 -Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@ +Libs.private: @LIBVIRT_LIBS@ @GLIB2_LIBS@ Cflags: -I${includedir}/libvirt-glib-1.0 @LIBVIRT_CFLAGS@ @GLIB2_CFLAGS@ -- 2.4.10
On Sat, Jan 02, 2016 at 12:46:30PM +0100, Michal Privoznik wrote:
In the pkg-config file for libvirt-glib we have a typo:
Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@
Noticed the missing '@' after LIBVIRT_LIBS? Well, I just did.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- libvirt-glib-1.0.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK, although it doesn't look like it hurt anyone, ever. I'm not sure when Libs.private is used, but I haven't managed to convince pkg-config to use it or print it anywhere.
diff --git a/libvirt-glib-1.0.pc.in b/libvirt-glib-1.0.pc.in index 1e8956d..d00be9f 100644 --- a/libvirt-glib-1.0.pc.in +++ b/libvirt-glib-1.0.pc.in @@ -8,5 +8,5 @@ Version: @VERSION@ Description: libvirt glib library Requires: glib-2.0 Libs: -L${libdir} -lvirt-glib-1.0 -Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@ +Libs.private: @LIBVIRT_LIBS@ @GLIB2_LIBS@ Cflags: -I${includedir}/libvirt-glib-1.0 @LIBVIRT_CFLAGS@ @GLIB2_CFLAGS@ -- 2.4.10
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Hey, On Sun, Jan 03, 2016 at 12:49:30PM +0100, Martin Kletzander wrote:
On Sat, Jan 02, 2016 at 12:46:30PM +0100, Michal Privoznik wrote:
In the pkg-config file for libvirt-glib we have a typo:
Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@
Noticed the missing '@' after LIBVIRT_LIBS? Well, I just did.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- libvirt-glib-1.0.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK, although it doesn't look like it hurt anyone, ever. I'm not sure when Libs.private is used, but I haven't managed to convince pkg-config to use it or print it anywhere.
It's used when asking for flags for static linking: $ pkg-config --static --libs libvirt-glib-1.0 -lvirt-glib-1.0 @LIBVIRT_LIBS -lglib-2.0 -pthread Christophe
On Mon, Jan 04, 2016 at 10:58:15AM +0100, Christophe Fergeau wrote:
Hey,
On Sun, Jan 03, 2016 at 12:49:30PM +0100, Martin Kletzander wrote:
On Sat, Jan 02, 2016 at 12:46:30PM +0100, Michal Privoznik wrote:
In the pkg-config file for libvirt-glib we have a typo:
Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@
Noticed the missing '@' after LIBVIRT_LIBS? Well, I just did.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- libvirt-glib-1.0.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK, although it doesn't look like it hurt anyone, ever. I'm not sure when Libs.private is used, but I haven't managed to convince pkg-config to use it or print it anywhere.
It's used when asking for flags for static linking:
$ pkg-config --static --libs libvirt-glib-1.0 -lvirt-glib-1.0 @LIBVIRT_LIBS -lglib-2.0 -pthread
Oh, thanks, good to know.
Christophe
participants (3)
-
Christophe Fergeau -
Martin Kletzander -
Michal Privoznik