[libvirt] [libvirt-php][PATCH 0/3] Couple of trivial fixes/improvements
*** BLURB HERE *** Michal Privoznik (3): Shut up automake libvirt-php.c: Reorder includes examples: Initialize $ret in index.php configure.ac | 4 ++++ examples/index.php | 1 + src/libvirt-php.c | 8 ++++---- 3 files changed, 9 insertions(+), 4 deletions(-) -- 2.13.5
Now that we have multiple source files it makes sense to turn automake into silent mode. Not only it produces nicer output but any error message is easier to find. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- configure.ac | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 12a0838..16b4388 100644 --- a/configure.ac +++ b/configure.ac @@ -12,6 +12,10 @@ m4_ifndef([LT_INIT], [ LT_INIT([shared disable-static]) ]) +# Default to using the silent-rules feature when possible. Users +# (including rpm) can still change the default at configure time. +AM_SILENT_RULES([yes]) + dnl Checks for programs. AC_PROG_CC AC_LANG([C]) -- 2.13.5
The includes are not in alphabetical order which hurts my OCD. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/libvirt-php.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index ec73034..ef057fe 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -20,14 +20,14 @@ #include "vncfunc.h" #include "sockets.h" #include "libvirt-connection.h" -#include "libvirt-node.h" -#include "libvirt-stream.h" #include "libvirt-domain.h" -#include "libvirt-snapshot.h" -#include "libvirt-storage.h" #include "libvirt-network.h" +#include "libvirt-node.h" #include "libvirt-nodedev.h" #include "libvirt-nwfilter.h" +#include "libvirt-snapshot.h" +#include "libvirt-storage.h" +#include "libvirt-stream.h" DEBUG_INIT("core"); -- 2.13.5
In bd258258 when adding a simple example to demonstrate NWFilter APIs I've forgot to initialize $ret variable which is then used (possibly undefined). Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- examples/index.php | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/index.php b/examples/index.php index aa3ed51..01aa532 100644 --- a/examples/index.php +++ b/examples/index.php @@ -627,6 +627,7 @@ echo "<h2>Network filters</h2>"; echo "Here you can see all the network filters defined"; + $ret = false; if (array_key_exists('subaction', $_GET)) { $uuid = $_GET['uuid']; $name = $_GET['name']; -- 2.13.5
On Mon, Aug 28, 2017 at 04:45:45PM +0200, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Privoznik (3): Shut up automake libvirt-php.c: Reorder includes
s/OCD/CDO/ ? =D Seems sane, ACK series.
examples: Initialize $ret in index.php
configure.ac | 4 ++++ examples/index.php | 1 + src/libvirt-php.c | 8 ++++---- 3 files changed, 9 insertions(+), 4 deletions(-)
-- 2.13.5
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 08/29/2017 09:55 AM, Martin Kletzander wrote:
On Mon, Aug 28, 2017 at 04:45:45PM +0200, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Privoznik (3): Shut up automake libvirt-php.c: Reorder includes
s/OCD/CDO/ ? =D
:-)
Seems sane, ACK series.
Oh these are already pushed. Since there were no reviewers for -php I've started to push patches and then merely send them to the list for others to know. Should have said that in the cover letter, sorry. Michal
On Tue, Aug 29, 2017 at 09:57:55AM +0200, Michal Privoznik wrote:
On 08/29/2017 09:55 AM, Martin Kletzander wrote:
On Mon, Aug 28, 2017 at 04:45:45PM +0200, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Privoznik (3): Shut up automake libvirt-php.c: Reorder includes
s/OCD/CDO/ ? =D
:-)
Seems sane, ACK series.
Oh these are already pushed. Since there were no reviewers for -php I've started to push patches and then merely send them to the list for others to know. Should have said that in the cover letter, sorry.
No need to, you can push it under the rule of well nobody actually reads them. In that case maybe there is no need to send them to the ML? But I'd leave that up to you. I just didn't see anyone in similar position doing that before ;)
Michal
participants (2)
-
Martin Kletzander -
Michal Privoznik