[PATCH 0/2] virsh: Two simple long version output fixes
*** BLURB HERE *** Michal Prívozník (2): virsh: Format -V output properly virsh: Report iSCSI-direct backend in long version tools/virsh.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.37.4
When displaying long version (virsh -V), the 'Virtuozzo Storage' substring lacks leading space and thus produces awful output. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tools/virsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.c b/tools/virsh.c index 5696941550..ad11f4a9ac 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -586,7 +586,7 @@ virshShowVersion(vshControl *ctl G_GNUC_UNUSED) vshPrint(ctl, " ZFS"); #endif #ifdef WITH_STORAGE_VSTORAGE - vshPrint(ctl, "Virtuozzo Storage"); + vshPrint(ctl, " Virtuozzo Storage"); #endif vshPrint(ctl, "\n"); -- 2.37.4
We already report whether iSCSI backend was enabled at compile time, but we don't do the same with iSCSI-direct backend. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tools/virsh.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index ad11f4a9ac..8de85f2516 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -573,6 +573,9 @@ virshShowVersion(vshControl *ctl G_GNUC_UNUSED) #ifdef WITH_STORAGE_ISCSI vshPrint(ctl, " iSCSI"); #endif +#ifdef WITH_STORAGE_ISCSI_DIRECT + vshPrint(ctl, " iSCSI-direct"); +#endif #ifdef WITH_STORAGE_LVM vshPrint(ctl, " LVM"); #endif -- 2.37.4
On Thu, Nov 24, 2022 at 09:21:07 +0100, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (2): virsh: Format -V output properly virsh: Report iSCSI-direct backend in long version
tools/virsh.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
participants (2)
-
Jiri Denemark -
Michal Privoznik