[libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter
It's not immediately obvious why we're using it even when installing a distribution like Debian, so explain the motivation in a comment. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/lcitool | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index a630971..0e27796 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -540,7 +540,9 @@ class Application: # preseed files must use a well-known name to be picked up by # d-i; for kickstart files, we can use whatever name we please # but we need to point anaconda in the right direction through - # a kernel argument + # the 'ks' kernel parameter. We can use 'ks' unconditionally + # for simplicity's sake, because distributions that don't use + # kickstart for unattended installation will simply ignore it extra_arg = "console=ttyS0 ks=file:/{}".format(install_config) virt_install = distutils.spawn.find_executable("virt-install") -- 2.23.0
On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote:
It's not immediately obvious why we're using it even when installing a distribution like Debian, so explain the motivation in a comment.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/lcitool | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/guests/lcitool b/guests/lcitool index a630971..0e27796 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -540,7 +540,9 @@ class Application: # preseed files must use a well-known name to be picked up by # d-i; for kickstart files, we can use whatever name we please # but we need to point anaconda in the right direction through - # a kernel argument + # the 'ks' kernel parameter. We can use 'ks' unconditionally + # for simplicity's sake, because distributions that don't use + # kickstart for unattended installation will simply ignore it extra_arg = "console=ttyS0 ks=file:/{}".format(install_config)
On a side note - I'm pretty sure I've already mentioned it in the past, but we should convert to the 'inst.ks' syntax instead of plain 'ks', anaconda currently accepts both [1], but it documents that *all* installer options are prefixed with 'inst.' and in future releases it may stop accepting the older syntax. To the patch itself: Reviewed-by: Erik Skultety <eskultet@redhat.com> [1] https://anaconda-installer.readthedocs.io/en/latest/boot-options.html
On Tue, 2019-12-03 at 12:30 +0100, Erik Skultety wrote:
On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote:
extra_arg = "console=ttyS0 ks=file:/{}".format(install_config)
On a side note - I'm pretty sure I've already mentioned it in the past, but we should convert to the 'inst.ks' syntax instead of plain 'ks', anaconda currently accepts both [1], but it documents that *all* installer options are prefixed with 'inst.' and in future releases it may stop accepting the older syntax.
Is the new syntax supported by RHEL/CentOS 7? That would be the only obstacle to its adoption. If you have time to cook a patch and verify it doesn't cause regressions, I'll gladly take it :)
To the patch itself: Reviewed-by: Erik Skultety <eskultet@redhat.com>
Thanks! Pushed now. -- Andrea Bolognani / Red Hat / Virtualization
On Tue, Dec 03, 2019 at 02:00:50PM +0100, Andrea Bolognani wrote:
On Tue, 2019-12-03 at 12:30 +0100, Erik Skultety wrote:
On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote:
extra_arg = "console=ttyS0 ks=file:/{}".format(install_config)
On a side note - I'm pretty sure I've already mentioned it in the past, but we should convert to the 'inst.ks' syntax instead of plain 'ks', anaconda currently accepts both [1], but it documents that *all* installer options are prefixed with 'inst.' and in future releases it may stop accepting the older syntax.
Is the new syntax supported by RHEL/CentOS 7? That would be the only obstacle to its adoption. If you have time to cook a patch and verify it doesn't cause regressions, I'll gladly take it :)
Yes, it is - well, truth to be told, it was introduced around 7.2, but we're only considering the latest minor, so no, it shouldn't be an issue. Okay, I'll have a look. Erik
participants (2)
-
Andrea Bolognani -
Erik Skultety