2:05 p.m.
Thomas Backlund skrev 13.1.2013 20:38:
patch both inline and attached as thunderbird tends to mess up ...
-----
if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
header.
Found by trying to build libvirt and connman against 3.8-rc3 headers.
Ok,
ignore this patch, it's not the correct fix as it introduces
redefinitions...
Btw, the error that I hit that made me suggest this fix was libvirt
config check bailing out:
config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has
incomplete type
Reported-by: Colin Guthrie <colin(a)mageia.org>
Reported-by: Christiaan Welvaart <cjw(a)daneel.dyndns.org>
Signed-off-by: Thomas Backlund <tmb(a)mageia.org>
--
diff -Nurp linux-3.8-rc3/include/uapi/linux/if_bridge.h
linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h
--- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13
20:09:54.257271755 +0200
+++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13
20:15:04.153676151 +0200
@@ -14,6 +14,7 @@
#define _UAPI_LINUX_IF_BRIDGE_H
#include <linux/types.h>
+#include <linux/in6.h>
#define SYSFS_BRIDGE_ATTR "bridge"
#define SYSFS_BRIDGE_FDB "brforward"
-----
Thomas
--
Thomas
5:57 p.m.
New subject: [libvirt] if_bridge.h: include in6.h for struct in6_addr use
On 01/13/2013 01:05 PM, Thomas Backlund wrote:
Thomas Backlund skrev 13.1.2013 20:38:
> patch both inline and attached as thunderbird tends to mess up ...
> -----
>
> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
> header.
>
> Found by trying to build libvirt and connman against 3.8-rc3 headers.
>
Ok,
ignore this patch, it's not the correct fix as it introduces
redefinitions...
Btw, the error that I hit that made me suggest this fix was libvirt
config check bailing out:
config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has
incomplete type
Hmm, just now noticing this thread, after independently hitting and and
having to work around the same problem in libvirt:
https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html
https://bugzilla.redhat.com/show_bug.cgi?id=895141
> --- linux-3.8-rc3/include/uapi/linux/if_bridge.h
2013-01-13
> 20:09:54.257271755 +0200
> +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13
> 20:15:04.153676151 +0200
> @@ -14,6 +14,7 @@
> #define _UAPI_LINUX_IF_BRIDGE_H
>
> #include <linux/types.h>
> +#include <linux/in6.h>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
4:03 a.m.
New subject: [libvirt] the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi (was: Re: if_bridge.h: include in6.h for struct in6_addr use)
Eric Blake skrev 15.1.2013 01:57:
On 01/13/2013 01:05 PM, Thomas Backlund wrote:
> Thomas Backlund skrev 13.1.2013 20:38:
>> patch both inline and attached as thunderbird tends to mess up ...
>
>> -----
>>
>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
>> header.
>>
>> Found by trying to build libvirt and connman against 3.8-rc3 headers.
>>
>
> Ok,
> ignore this patch, it's not the correct fix as it introduces
> redefinitions...
>
> Btw, the error that I hit that made me suggest this fix was libvirt
> config check bailing out:
>
> config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has
> incomplete type
Hmm, just now noticing this thread, after independently hitting and and
having to work around the same problem in libvirt:
https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html
https://bugzilla.redhat.com/show_bug.cgi?id=895141
Yep,
and the commit breaking uapi headers is by using "struct in6_addr ip6" is:
From ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 Mon Sep 17 00:00:00 2001
From: Cong Wang <amwang(a)redhat.com>
Date: Fri, 7 Dec 2012 00:04:48 +0000
Subject: [PATCH] bridge: export multicast database via netlink
V5: fix two bugs pointed out by Thomas
remove seq check for now, mark it as TODO
V4: remove some useless #include
some coding style fix
V3: drop debugging printk's
update selinux perm table as well
V2: drop patch 1/2, export ifindex directly
Redesign netlink attributes
Improve netlink seq check
Handle IPv6 addr as well
This patch exports bridge multicast database via netlink
message type RTM_GETMDB. Similar to fdb, but currently bridge-specific.
We may need to support modify multicast database too (RTM_{ADD,DEL}MDB).
(Thanks to Thomas for patient reviews)
Cc: Herbert Xu <herbert(a)gondor.apana.org.au>
Cc: Stephen Hemminger <shemminger(a)vyatta.com>
Cc: "David S. Miller" <davem(a)davemloft.net>
Cc: Thomas Graf <tgraf(a)suug.ch>
Cc: Jesper Dangaard Brouer <brouer(a)redhat.com>
Signed-off-by: Cong Wang <amwang(a)redhat.com>
Acked-by: Thomas Graf <tgraf(a)suug.ch>
Signed-off-by: David S. Miller <davem(a)davemloft.net>
---
include/uapi/linux/if_bridge.h | 55 ++++++++++++++
include/uapi/linux/rtnetlink.h | 3 +
net/bridge/Makefile | 2 +-
net/bridge/br_mdb.c | 163
++++++++++++++++++++++++++++++++++++++++
net/bridge/br_multicast.c | 1 +
net/bridge/br_private.h | 1 +
security/selinux/nlmsgtab.c | 1 +
7 files changed, 225 insertions(+), 1 deletions(-)
create mode 100644 net/bridge/br_mdb.c
--
Thomas
4:11 a.m.
New subject: [libvirt] the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi (was: Re: if_bridge.h: include in6.h for struct in6_addr use)
On Tue, 2013-01-15 at 12:03 +0200, Thomas Backlund wrote:
Eric Blake skrev 15.1.2013 01:57:
> On 01/13/2013 01:05 PM, Thomas Backlund wrote:
>> Thomas Backlund skrev 13.1.2013 20:38:
>>> patch both inline and attached as thunderbird tends to mess up ...
>>
>>> -----
>>>
>>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
>>> header.
>>>
>>> Found by trying to build libvirt and connman against 3.8-rc3 headers.
>>>
>>
>> Ok,
>> ignore this patch, it's not the correct fix as it introduces
>> redefinitions...
>>
>> Btw, the error that I hit that made me suggest this fix was libvirt
>> config check bailing out:
>>
>> config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6'
has
>> incomplete type
>
> Hmm, just now noticing this thread, after independently hitting and and
> having to work around the same problem in libvirt:
> https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html
> https://bugzilla.redhat.com/show_bug.cgi?id=895141
Yep,
and the commit breaking uapi headers is by using "struct in6_addr ip6" is:
From ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 Mon Sep 17 00:00:00 2001
From: Cong Wang <amwang(a)redhat.com>
Date: Fri, 7 Dec 2012 00:04:48 +0000
Subject: [PATCH] bridge: export multicast database via netlink
Does the following patch help?
$ git diff include/uapi/linux/if_bridge.h
diff --git a/include/uapi/linux/if_bridge.h
b/include/uapi/linux/if_bridge.h
index 5db2975..653db23 100644
--- a/include/uapi/linux/if_bridge.h
+++ b/include/uapi/linux/if_bridge.h
@@ -14,6 +14,7 @@
#define _UAPI_LINUX_IF_BRIDGE_H
#include <linux/types.h>
+#include <linux/in6.h>
#define SYSFS_BRIDGE_ATTR "bridge"
#define SYSFS_BRIDGE_FDB "brforward"
4:55 a.m.
New subject: [libvirt] the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi
Cong Wang skrev 15.1.2013 12:11:
On Tue, 2013-01-15 at 12:03 +0200, Thomas Backlund wrote:
> Eric Blake skrev 15.1.2013 01:57:
>> On 01/13/2013 01:05 PM, Thomas Backlund wrote:
>>> Thomas Backlund skrev 13.1.2013 20:38:
>>>> patch both inline and attached as thunderbird tends to mess up ...
>>>
>>>> -----
>>>>
>>>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
>>>> header.
>>>>
>>>> Found by trying to build libvirt and connman against 3.8-rc3 headers.
>>>>
>>>
>>> Ok,
>>> ignore this patch, it's not the correct fix as it introduces
>>> redefinitions...
>>>
>>> Btw, the error that I hit that made me suggest this fix was libvirt
>>> config check bailing out:
>>>
>>> config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6'
has
>>> incomplete type
>>
>> Hmm, just now noticing this thread, after independently hitting and and
>> having to work around the same problem in libvirt:
>> https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html
>> https://bugzilla.redhat.com/show_bug.cgi?id=895141
>
>
> Yep,
>
> and the commit breaking uapi headers is by using "struct in6_addr ip6" is:
>
>
> From ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 Mon Sep 17 00:00:00 2001
> From: Cong Wang <amwang(a)redhat.com>
> Date: Fri, 7 Dec 2012 00:04:48 +0000
> Subject: [PATCH] bridge: export multicast database via netlink
Does the following patch help?
$ git diff include/uapi/linux/if_bridge.h
diff --git a/include/uapi/linux/if_bridge.h
b/include/uapi/linux/if_bridge.h
index 5db2975..653db23 100644
--- a/include/uapi/linux/if_bridge.h
+++ b/include/uapi/linux/if_bridge.h
@@ -14,6 +14,7 @@
#define _UAPI_LINUX_IF_BRIDGE_H
#include <linux/types.h>
+#include <linux/in6.h>
#define SYSFS_BRIDGE_ATTR "bridge"
#define SYSFS_BRIDGE_FDB "brforward"
Well, I suggested the same fix in the beginning of the thread
on netdev and lkml: "if_bridge.h: include in6.h for struct in6_addr use"
as it seemed to fix the libvirt case
but then asked it to be ignored after I tried to build connman,
and hit this conflict with glibc-2.17:
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:35:5: error: expected identifier before
numeric constant
/usr/include/netinet/in.h:197:8: error: redefinition of 'struct in6_addr'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:30:8: note: originally defined here
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:238:8: error: redefinition of 'struct
sockaddr_in6'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:46:8: note: originally defined here
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:274:8: error: redefinition of 'struct ipv6_mreq'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:54:8: note: originally defined here
make[1]: *** [src/src_connmand-tethering.o] Error 1
So I'm not sure it's the right one...
--
Thomas
11:51 p.m.
New subject: [libvirt] the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi
On Tue, 2013-01-15 at 12:55 +0200, Thomas Backlund wrote:
as it seemed to fix the libvirt case
but then asked it to be ignored after I tried to build connman,
and hit this conflict with glibc-2.17:
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:35:5: error: expected identifier before
numeric constant
/usr/include/netinet/in.h:197:8: error: redefinition of 'struct in6_addr'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:30:8: note: originally defined here
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:238:8: error: redefinition of 'struct
sockaddr_in6'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:46:8: note: originally defined here
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:274:8: error: redefinition of 'struct ipv6_mreq'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:54:8: note: originally defined here
make[1]: *** [src/src_connmand-tethering.o] Error 1
So I'm not sure it's the right one...
% rpm -q --whatprovides /usr/include/netinet/in.h
glibc-headers-2.14.90-24.fc16.9.x86_64
Seems we have conflicts with glibc headers...
12:06 a.m.
New subject: [libvirt] Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>
(Cc'ing some glibc developers...)
Hello,
In glibc source file inet/netinet/in.h and kernel source file
include/uapi/linux/in6.h, both define struct in6_addr, and both are
visible to user applications. Thomas reported a conflict below.
So, how can we handle this? /me is wondering why we didn't see this
before.
Thanks.
On Tue, 2013-01-15 at 12:55 +0200, Thomas Backlund wrote:
Cong Wang skrev 15.1.2013 12:11:
>
> Does the following patch help?
>
> $ git diff include/uapi/linux/if_bridge.h
> diff --git a/include/uapi/linux/if_bridge.h
> b/include/uapi/linux/if_bridge.h
> index 5db2975..653db23 100644
> --- a/include/uapi/linux/if_bridge.h
> +++ b/include/uapi/linux/if_bridge.h
> @@ -14,6 +14,7 @@
> #define _UAPI_LINUX_IF_BRIDGE_H
>
> #include <linux/types.h>
> +#include <linux/in6.h>
>
> #define SYSFS_BRIDGE_ATTR "bridge"
> #define SYSFS_BRIDGE_FDB "brforward"
>
Well, I suggested the same fix in the beginning of the thread
on netdev and lkml: "if_bridge.h: include in6.h for struct in6_addr use"
as it seemed to fix the libvirt case
but then asked it to be ignored after I tried to build connman,
and hit this conflict with glibc-2.17:
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:35:5: error: expected identifier before
numeric constant
/usr/include/netinet/in.h:197:8: error: redefinition of 'struct in6_addr'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:30:8: note: originally defined here
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:238:8: error: redefinition of 'struct
sockaddr_in6'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:46:8: note: originally defined here
In file included from /usr/include/arpa/inet.h:22:0,
from ./include/connman/inet.h:25,
from src/connman.h:128,
from src/tethering.c:40:
/usr/include/netinet/in.h:274:8: error: redefinition of 'struct ipv6_mreq'
In file included from /usr/include/linux/if_bridge.h:17:0,
from src/tethering.c:38:
/usr/include/linux/in6.h:54:8: note: originally defined here
make[1]: *** [src/src_connmand-tethering.o] Error 1
So I'm not sure it's the right one...
8:21 a.m.
New subject: [libvirt] Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>
Cong Wang wrote:
(Cc'ing some glibc developers...)
Hello,
In glibc source file inet/netinet/in.h and kernel source file
include/uapi/linux/in6.h, both define struct in6_addr, and both are
visible to user applications. Thomas reported a conflict below.
So, how can we handle this? /me is wondering why we didn't see this
before.
Thanks.
On Tue, 2013-01-15 at 12:55 +0200, Thomas Backlund wrote:
> Cong Wang skrev 15.1.2013 12:11:
>>
>> Does the following patch help?
>>
>> $ git diff include/uapi/linux/if_bridge.h
>> diff --git a/include/uapi/linux/if_bridge.h
>> b/include/uapi/linux/if_bridge.h
>> index 5db2975..653db23 100644
>> --- a/include/uapi/linux/if_bridge.h
>> +++ b/include/uapi/linux/if_bridge.h
>> @@ -14,6 +14,7 @@
>> #define _UAPI_LINUX_IF_BRIDGE_H
>>
>> #include <linux/types.h>
>> +#include <linux/in6.h>
>>
>> #define SYSFS_BRIDGE_ATTR "bridge"
>> #define SYSFS_BRIDGE_FDB "brforward"
>>
>
> Well, I suggested the same fix in the beginning of the thread
> on netdev and lkml: "if_bridge.h: include in6.h for struct in6_addr use"
>
> as it seemed to fix the libvirt case
>
> but then asked it to be ignored after I tried to build connman,
> and hit this conflict with glibc-2.17:
>
> In file included from /usr/include/arpa/inet.h:22:0,
> from ./include/connman/inet.h:25,
> from src/connman.h:128,
> from src/tethering.c:40:
> /usr/include/netinet/in.h:35:5: error: expected identifier before
> numeric constant
> /usr/include/netinet/in.h:197:8: error: redefinition of 'struct in6_addr'
> In file included from /usr/include/linux/if_bridge.h:17:0,
> from src/tethering.c:38:
> /usr/include/linux/in6.h:30:8: note: originally defined here
> In file included from /usr/include/arpa/inet.h:22:0,
> from ./include/connman/inet.h:25,
> from src/connman.h:128,
> from src/tethering.c:40:
> /usr/include/netinet/in.h:238:8: error: redefinition of 'struct
> sockaddr_in6'
> In file included from /usr/include/linux/if_bridge.h:17:0,
> from src/tethering.c:38:
> /usr/include/linux/in6.h:46:8: note: originally defined here
> In file included from /usr/include/arpa/inet.h:22:0,
> from ./include/connman/inet.h:25,
> from src/connman.h:128,
> from src/tethering.c:40:
> /usr/include/netinet/in.h:274:8: error: redefinition of 'struct ipv6_mreq'
> In file included from /usr/include/linux/if_bridge.h:17:0,
> from src/tethering.c:38:
> /usr/include/linux/in6.h:54:8: note: originally defined here
> make[1]: *** [src/src_connmand-tethering.o] Error 1
>
>
> So I'm not sure it's the right one...
This is not a new issue. In addition to this,
netinet/in.h also conflits with linux/in.h.
We might have
#if !defined(__GLIBC__) || !defined(_NETINET_IN_H)
:
#endif
around those conflicting definitions in uapi/linux/in{,6}.h.
--yoshfuji
9:47 a.m.
New subject: [libvirt] Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>
On Wed, 2013-01-16 at 23:21 +0900, YOSHIFUJI Hideaki wrote:
Cong Wang wrote:
> (Cc'ing some glibc developers...)
>
> Hello,
>
> In glibc source file inet/netinet/in.h and kernel source file
> include/uapi/linux/in6.h, both define struct in6_addr, and both are
> visible to user applications. Thomas reported a conflict below.
>
> So, how can we handle this? /me is wondering why we didn't see this
> before.
[...]
This is not a new issue. In addition to this,
netinet/in.h also conflits with linux/in.h.
We might have
#if !defined(__GLIBC__) || !defined(_NETINET_IN_H)
:
#endif
around those conflicting definitions in uapi/linux/in{,6}.h.
This only solves half the problem, as <netinet/in.h> might be included
after <linux/in.h>. Also, not all Linux userland uses glibc.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
3:45 p.m.
New subject: [libvirt] Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>
From: Ben Hutchings <bhutchings(a)solarflare.com>
Date: Wed, 16 Jan 2013 15:47:12 +0000
On Wed, 2013-01-16 at 23:21 +0900, YOSHIFUJI Hideaki wrote:
> Cong Wang wrote:
> > (Cc'ing some glibc developers...)
> >
> > Hello,
> >
> > In glibc source file inet/netinet/in.h and kernel source file
> > include/uapi/linux/in6.h, both define struct in6_addr, and both are
> > visible to user applications. Thomas reported a conflict below.
> >
> > So, how can we handle this? /me is wondering why we didn't see this
> > before.
[...]
> This is not a new issue. In addition to this,
> netinet/in.h also conflits with linux/in.h.
>
> We might have
> #if !defined(__GLIBC__) || !defined(_NETINET_IN_H)
> :
> #endif
> around those conflicting definitions in uapi/linux/in{,6}.h.
This only solves half the problem, as <netinet/in.h> might be included
after <linux/in.h>. Also, not all Linux userland uses glibc.
So I've been looking at reasonable ways to fix this.
What would be really nice is if GCC treated multiple identical
definitions of structures the same way it handles multiple identical
definitions of CPP defines. Which is to silently accept them.
But that's not the case, so we need a different solution.
Another thing to do is to use a new structure for in6_addr in kernel
headers exported to userland.
If we were to make the structure members and accessor macros identical
we could avoid breaking most if not all apps.
However the type name is different so:
struct in6_addr *p = &kern_struct->member;
wouldn't work so well. And you couldn't fix up the sources to these
kinds of accesses in a way that work cleanly both before and after
changing the kernel headers.
I'm out of ideas for today.
7:58 p.m.
New subject: [libvirt] Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>
On 01/16/2013 04:45 PM, David Miller wrote:
From: Ben Hutchings <bhutchings(a)solarflare.com>
Date: Wed, 16 Jan 2013 15:47:12 +0000
> On Wed, 2013-01-16 at 23:21 +0900, YOSHIFUJI Hideaki wrote:
>> Cong Wang wrote:
>>> (Cc'ing some glibc developers...)
>>>
>>> Hello,
>>>
>>> In glibc source file inet/netinet/in.h and kernel source file
>>> include/uapi/linux/in6.h, both define struct in6_addr, and both are
>>> visible to user applications. Thomas reported a conflict below.
>>>
>>> So, how can we handle this? /me is wondering why we didn't see this
>>> before.
> [...]
>> This is not a new issue. In addition to this,
>> netinet/in.h also conflits with linux/in.h.
>>
>> We might have
>> #if !defined(__GLIBC__) || !defined(_NETINET_IN_H)
>> :
>> #endif
>> around those conflicting definitions in uapi/linux/in{,6}.h.
>
> This only solves half the problem, as <netinet/in.h> might be included
> after <linux/in.h>. Also, not all Linux userland uses glibc.
So I've been looking at reasonable ways to fix this.
What would be really nice is if GCC treated multiple identical
definitions of structures the same way it handles multiple identical
definitions of CPP defines. Which is to silently accept them.
But that's not the case, so we need a different solution.
Another thing to do is to use a new structure for in6_addr in kernel
headers exported to userland.
If we were to make the structure members and accessor macros identical
we could avoid breaking most if not all apps.
However the type name is different so:
struct in6_addr *p = &kern_struct->member;
wouldn't work so well. And you couldn't fix up the sources to these
kinds of accesses in a way that work cleanly both before and after
changing the kernel headers.
I'm out of ideas for today.
So I just went down the rabbit hole, and the further I get the
closer I get to having two exact copies of the same definitions
in both glibc and the kernel and using whichever one was included
first.
Is anyone opposed to that kind of solution?
There is some ugliness there.
Cheers,
Carlos.
8:05 p.m.
New subject: [libvirt] Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>
From: Carlos O'Donell <carlos(a)systemhalted.org>
Date: Wed, 16 Jan 2013 20:58:47 -0500
So I just went down the rabbit hole, and the further I get the
closer I get to having two exact copies of the same definitions
in both glibc and the kernel and using whichever one was included
first.
Is anyone opposed to that kind of solution?
Sounds interesting, please share :-)
4:57 a.m.
New subject: [libvirt] Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>
On Thursday 2013-01-17 03:05, David Miller wrote:
From: Carlos O'Donell <carlos(a)systemhalted.org>
Date: Wed, 16 Jan 2013 20:58:47 -0500
> So I just went down the rabbit hole, and the further I get the
> closer I get to having two exact copies of the same definitions
> in both glibc and the kernel and using whichever one was included
> first.
>
> Is anyone opposed to that kind of solution?
Sounds interesting, please share :-)
iptables has the same issue, and solved it its way.
(uapi/)linux/netfilter.h is used to get at things like union
nf_inet_addr. This union contains struct in6_addr. There is no include
for in6_addr in netfilter.h itself. This may break the "standalone
compilation" test, but at least allows for specifying the
environment-specific header for in6_addr in the C file:
a. userspace: #include <netinet/in.h> before <linux/netfilter.h>
b. kernel parts: #include <linux/in6.h> before <linux/netfilter.h>
10:17 a.m.
New subject: [libvirt] if_bridge.h: include in6.h for struct in6_addr use
On Jan 14, 2013, at 5:57 PM, Eric Blake wrote:
On 01/13/2013 01:05 PM, Thomas Backlund wrote:
> Thomas Backlund skrev 13.1.2013 20:38:
>> patch both inline and attached as thunderbird tends to mess up ...
>
>> -----
>>
>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
>> header.
>>
>> Found by trying to build libvirt and connman against 3.8-rc3 headers.
>>
>
> Ok,
> ignore this patch, it's not the correct fix as it introduces
> redefinitions...
>
> Btw, the error that I hit that made me suggest this fix was libvirt
> config check bailing out:
>
> config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has
> incomplete type
Hmm, just now noticing this thread, after independently hitting and and
having to work around the same problem in libvirt:
https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html
https://bugzilla.redhat.com/show_bug.cgi?id=895141
>> --- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13
>> 20:09:54.257271755 +0200
>> +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13
>> 20:15:04.153676151 +0200
>> @@ -14,6 +14,7 @@
>> #define _UAPI_LINUX_IF_BRIDGE_H
>>
>> #include <linux/types.h>
>> +#include <linux/in6.h>
>>
Did this ever get resolved ?
- k
11:24 a.m.
New subject: [libvirt] if_bridge.h: include in6.h for struct in6_addr use
On 03/13/2013 09:17 AM, Kumar Gala wrote:
>>>
>>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
>>> header.
>>>
>>> Found by trying to build libvirt and connman against 3.8-rc3 headers.
>>>
>>
Did this ever get resolved ?
Libvirt has managed to work around the kernel issue in the meantime.
But just today, I hit the same issue with the latest
kernel-headers-3.8.2-206.fc18.x86_64 on Fedora 18 when backporting to an
older libvirt branch that did not have the workaround. A kernel person
would have to speak up for certain, but I think it is still a problem.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
4271
days inactive
4330
days old
14 comments
9 participants
participants (9)
-
Ben Hutchings -
Carlos O'Donell -
Cong Wang -
David Miller -
Eric Blake -
Jan Engelhardt -
Kumar Gala -
Thomas Backlund -
YOSHIFUJI Hideaki