Re: [libvirt] fix ix86 macros
On 02/17/2012 08:27 AM, Peter Robinson wrote:
commit 79ae809020d041ec2d10982a60a9eaf4782ca843 Author: Peter Robinson <pbrobinson@gmail.com> Date: Fri Feb 17 15:27:03 2012 +0000
fix ix86 macros
libvirt.spec | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) --- diff --git a/libvirt.spec b/libvirt.spec index 2c7f6c0..d0b82bd 100644 --- a/libvirt.spec +++ b/libvirt.spec @@ -22,7 +22,7 @@
# RHEL-5 builds are client-only for s390, ppc %if 0%{?rhel} == 5 -%ifnarch i386 i586 i686 x86_64 ia64 +%ifnarch %{ix86} x86_64 ia64
... Thanks for this fix. We'd also like to apply it to upstream libvirt.git, in the file libvirt.spec.in, so we don't have to repeat this type of fix in the future. Is it all right if I attribute such a patch in your name? -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Fri, Feb 17, 2012 at 3:33 PM, Eric Blake <eblake@redhat.com> wrote:
On 02/17/2012 08:27 AM, Peter Robinson wrote:
commit 79ae809020d041ec2d10982a60a9eaf4782ca843 Author: Peter Robinson <pbrobinson@gmail.com> Date: Fri Feb 17 15:27:03 2012 +0000
fix ix86 macros
libvirt.spec | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) --- diff --git a/libvirt.spec b/libvirt.spec index 2c7f6c0..d0b82bd 100644 --- a/libvirt.spec +++ b/libvirt.spec @@ -22,7 +22,7 @@
# RHEL-5 builds are client-only for s390, ppc %if 0%{?rhel} == 5 -%ifnarch i386 i586 i686 x86_64 ia64 +%ifnarch %{ix86} x86_64 ia64
...
Thanks for this fix. We'd also like to apply it to upstream libvirt.git, in the file libvirt.spec.in, so we don't have to repeat this type of fix in the future. Is it all right if I attribute such a patch in your name?
Absolutely fine with me. Peter
On 02/17/2012 10:09 AM, Peter Robinson wrote:
On Fri, Feb 17, 2012 at 3:33 PM, Eric Blake <eblake@redhat.com> wrote:
On 02/17/2012 08:27 AM, Peter Robinson wrote:
commit 79ae809020d041ec2d10982a60a9eaf4782ca843 Author: Peter Robinson <pbrobinson@gmail.com> Date: Fri Feb 17 15:27:03 2012 +0000
fix ix86 macros
-%ifnarch i386 i586 i686 x86_64 ia64 +%ifnarch %{ix86} x86_64 ia64
...
Thanks for this fix. We'd also like to apply it to upstream libvirt.git, in the file libvirt.spec.in, so we don't have to repeat this type of fix in the future. Is it all right if I attribute such a patch in your name?
Absolutely fine with me.
Done, and thanks again for the initial patch to Fedora. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Peter Robinson