[libvirt] [PATCH] Quick fix for config-demo.py
I guess this must have been changed and the demo not updated. Fix the demo so it uses the right value. Signed-off-by: Ian Main <imain@redhat.com> --- examples/config-demo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/config-demo.py b/examples/config-demo.py index 367d99a..c28d8b9 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -28,7 +28,7 @@ disk.set_type(LibvirtGConfig.DomainDiskType.FILE) disk.set_guest_device_type(LibvirtGConfig.DomainDiskGuestDeviceType.DISK) disk.set_source("/tmp/foo/bar") disk.set_driver_name("qemu") -disk.set_driver_format(LibvirtGConfig.DriverType.QCOW2) +disk.set_driver_format(LibvirtGConfig.DomainDiskFormat.QCOW2) disk.set_target_bus(LibvirtGConfig.DomainDiskBus.IDE) disk.set_target_dev("hda") domain.add_device(disk) -- 1.8.1.4
On Tue, Oct 22, 2013 at 03:50:36PM -0700, Ian Main wrote:
I guess this must have been changed and the demo not updated. Fix the demo so it uses the right value.
ACK (this was broken in c6b98f67d4b794ae1a91bf9fdff3445f1135bc85 , I tried to update to update the demo but somehow failed at it ;) Christophe
On 22.10.2013 23:50, Ian Main wrote:
I guess this must have been changed and the demo not updated. Fix the demo so it uses the right value.
Signed-off-by: Ian Main <imain@redhat.com> --- examples/config-demo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/config-demo.py b/examples/config-demo.py index 367d99a..c28d8b9 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -28,7 +28,7 @@ disk.set_type(LibvirtGConfig.DomainDiskType.FILE) disk.set_guest_device_type(LibvirtGConfig.DomainDiskGuestDeviceType.DISK) disk.set_source("/tmp/foo/bar") disk.set_driver_name("qemu") -disk.set_driver_format(LibvirtGConfig.DriverType.QCOW2) +disk.set_driver_format(LibvirtGConfig.DomainDiskFormat.QCOW2) disk.set_target_bus(LibvirtGConfig.DomainDiskBus.IDE) disk.set_target_dev("hda") domain.add_device(disk)
While having one list for two or more joint projects makes sense, I think it pushes some more requirements for submitting patches. For instance, I filter -glib patches into a separate folder (based on -glib appearing in the subject). So can you please run: git config format.subjectprefix libvirt-glib][PATCH within your libvirt-glib git tree, so you don't have to worry about using the correct prefix again? Thanks! Michal
On Thu, Oct 24, 2013 at 10:16:50AM +0100, Michal Privoznik wrote:
On 22.10.2013 23:50, Ian Main wrote:
I guess this must have been changed and the demo not updated. Fix the demo so it uses the right value.
Signed-off-by: Ian Main <imain@redhat.com> --- examples/config-demo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/config-demo.py b/examples/config-demo.py index 367d99a..c28d8b9 100644 --- a/examples/config-demo.py +++ b/examples/config-demo.py @@ -28,7 +28,7 @@ disk.set_type(LibvirtGConfig.DomainDiskType.FILE) disk.set_guest_device_type(LibvirtGConfig.DomainDiskGuestDeviceType.DISK) disk.set_source("/tmp/foo/bar") disk.set_driver_name("qemu") -disk.set_driver_format(LibvirtGConfig.DriverType.QCOW2) +disk.set_driver_format(LibvirtGConfig.DomainDiskFormat.QCOW2) disk.set_target_bus(LibvirtGConfig.DomainDiskBus.IDE) disk.set_target_dev("hda") domain.add_device(disk)
While having one list for two or more joint projects makes sense, I think it pushes some more requirements for submitting patches. For instance, I filter -glib patches into a separate folder (based on -glib appearing in the subject). So can you please run:
git config format.subjectprefix libvirt-glib][PATCH
within your libvirt-glib git tree, so you don't have to worry about using the correct prefix again? Thanks!
Yeah good idea. So far I have gotten it right but this was such a quicky I missed it. Ian
participants (3)
-
Christophe Fergeau -
Ian Main -
Michal Privoznik