On Sat, May 23, 2009 at 09:34:41PM +0200, Geert Jansen wrote:

Hi,

i'm working on some infrastructure to run unit tests in a virtual environment. For this, I need to be able to pass a "snapshot=on" argument to a qemu virtual disk so that I know I start with the same state all the time.

The attached patch implements this. It adds a boolean <snapshot/> to the <disk> section in the XML.

Please consider for inclusion.

Hi Geert, Hum, qemu args may come and go, to really add this at the libvirt API, one would need a clear semantic for the operation, and ideally an implementation for a different hypervisor. So your suggestion is to add an argument making a disk immutable between runs for the domain, i.e. the disk will always revert to the initial state when restarted, but this would bit affect Suspend/Resume or Save/Restore/Migrate operations, Right ? If yes that would need to be described fully in the documentation in docs/formatdomain.html.in Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/