On Thu, Nov 23, 2017 at 07:31:46AM -0500, John Ferlan wrote:
Commit id '36555364' removed the setting of the
driver->privileged,
which the udevProcessPCI would need in order to read the PCI device
configs.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
Not quite sure after seeing other issues how I missed this during
review of the series to change the udev nodedev code to use a thread.
Not sure why I removed in the first place.
I tripped across this while "investigating" a recurring issue I'm
having with the udev code in an avocado nwfilter test where during
a libvirtd restart the udev initialization "hangs" and cannot be killed
Is ^this one related to the async thread as well? Because it would just add
more fuel to the centos6 + upstream libvirt fire.
resulting in a <defunct> process and the only recovery is
reboot. Still
trying to hack through that, but figured this should go into 3.10 at
least. So far only 3.9 would be affected, but only to not get PCI
device details.
src/node_device/node_device_udev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index 35df13b153..1e1b71742b 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -1933,6 +1933,8 @@ nodeStateInitialize(bool privileged,
return -1;
}
+ driver->privileged = privileged;
+
if (!(driver->devs = virNodeDeviceObjListNew()) ||
!(priv = udevEventDataNew()))
goto cleanup;
--
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>