On Wed, Sep 30, 2009 at 12:17:32PM +0200, Matthias Bolte wrote:

2009/9/30 Pritesh Kothari <Pritesh.Kothari@sun.com>:

...

Hi All,

Just minor fix's.

Regards, Pritesh

I came across this 64bit compile problem (with -Werror) as well, but I would fix it differently: Change the signature of remoteSendStreamData() to use unsigned int instead of size_t. This is possible because remoteSendStreamData() is not part of the public API and it's currently called with len set to 0 or with len set to an int value returned by virStreamRecv().

ACK, I prefer this way

diff --git a/daemon/dispatch.c b/daemon/dispatch.c index e9fe260..ae4f60d 100644 --- a/daemon/dispatch.c +++ b/daemon/dispatch.c @@ -589,7 +589,7 @@ int remoteSendStreamData(struct qemud_client *client, struct qemud_client_stream *stream, const char *data, - size_t len) + unsigned int len) { struct qemud_client_message *msg; XDR xdr; diff --git a/daemon/dispatch.h b/daemon/dispatch.h index a5bf474..ed9d89d 100644 --- a/daemon/dispatch.h +++ b/daemon/dispatch.h @@ -75,6 +75,6 @@ int remoteSendStreamData(struct qemud_client *client, struct qemud_client_stream *stream, const char *data, - size_t len); + unsigned int len);

#endif /* __LIBVIRTD_DISPATCH_H__ */

-- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

-- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|