On Tue, Mar 12, 2024 at 17:58:08 +0000, m kamal wrote:

Thanks a lot for the review, Peter.

The first name I used was by mistake, it's the name of my Github profile, Github desktop probably auto-configured it as the global user name for git on my machine. It's in Arabic so it could confuse many non-Unicode-aware programs or protocols. The other name "m kamal" is just a contraction I wrote when I was subscribing to the mailing list from the web UI, I didn't realize it's important.

Technically that is not important as it can be overriden by using a From line similarly to your first subscription. The only important bit is what will be recorded in the GIT history, you're free to use any other version in other communication.

I will change my configured name in the .gitpublish config to be the longer name "Mostafa Mahmoud", that's the first 2 names of my legal name, it appears that most names here are also 2 names. If there is also a way to change my forum name "m kamal" please let me know.a

If by 'forum' you mean the mailing list you should be able to change that in https://lists.libvirt.org/user-profile/ once you log in.

Sorry for any inconvenience. One last question: After the patch got your approval, is there something on my end to do so that it gets merged? Will it automatically gets picked up by the Gitlab CI pipeline somehow?

Depending on whether you want to test if you configured your environment propely you can either send a v3 with updated autorship and sign-off, or just reply with the full format you're intending to use and I can modify this patch and push it. Pushing is done by one of the maintainers, which would be me since I've reviewed it.