[libvirt] [PATCH] Should determine the value of client first before locking it

--- src/rpc/virnetclient.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index dfc4ed9..c100ef1 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -271,6 +271,9 @@ void virNetClientFree(virNetClientPtr client) void virNetClientClose(virNetClientPtr client) { + if (!client) + return; + virNetClientLock(client); virNetSocketRemoveIOCallback(client->sock); virNetSocketFree(client->sock); -- 1.7.1

On Wed, Jul 20, 2011 at 06:43:12PM +0800, Guannan Ren wrote:
--- src/rpc/virnetclient.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index dfc4ed9..c100ef1 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -271,6 +271,9 @@ void virNetClientFree(virNetClientPtr client)
void virNetClientClose(virNetClientPtr client) { + if (!client) + return; + virNetClientLock(client); virNetSocketRemoveIOCallback(client->sock); virNetSocketFree(client->sock);
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (2)
-
Daniel P. Berrange
-
Guannan Ren