Found these problems while running libvirt-tck with up to date libvirt and qemu.git. Details in the patches. Thanks.
QMP in QEMU 0.13 has been fixed to enforce type correctness, this means that boolean types must be true or false, not integers. Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- src/qemu/qemu_monitor_json.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 8a586bc..bc19f23 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1601,9 +1601,9 @@ static int qemuMonitorJSONMigrate(qemuMonitorPtr mon, int ret; virJSONValuePtr cmd = qemuMonitorJSONMakeCommand("migrate", - "i:detach", flags & QEMU_MONITOR_MIGRATE_BACKGROUND ? 1 : 0, - "i:blk", flags & QEMU_MONITOR_MIGRATE_NON_SHARED_DISK ? 1 : 0, - "i:inc", flags & QEMU_MONITOR_MIGRATE_NON_SHARED_INC ? 1 : 0, + "b:detach", flags & QEMU_MONITOR_MIGRATE_BACKGROUND ? 1 : 0, + "b:blk", flags & QEMU_MONITOR_MIGRATE_NON_SHARED_DISK ? 1 : 0, + "b:inc", flags & QEMU_MONITOR_MIGRATE_NON_SHARED_INC ? 1 : 0, "s:uri", uri, NULL); virJSONValuePtr reply = NULL; -- 1.7.3.rc0.27.g154ad
QMP in QEMU 0.13 has been fixed to enforce type correctness, this means that boolean types must be true or false, not integers. Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- src/qemu/qemu_monitor_json.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index bc19f23..d3ab25f 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1353,7 +1353,7 @@ int qemuMonitorJSONEjectMedia(qemuMonitorPtr mon, int ret; virJSONValuePtr cmd = qemuMonitorJSONMakeCommand("eject", "s:device", devname, - "i:force", 0, + "b:force", 0, NULL); virJSONValuePtr reply = NULL; if (!cmd) -- 1.7.3.rc0.27.g154ad
On 09/09/2010 03:05 PM, Luiz Capitulino wrote:
QMP in QEMU 0.13 has been fixed to enforce type correctness, this means that boolean types must be true or false, not integers.
Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com> --- src/qemu/qemu_monitor_json.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index bc19f23..d3ab25f 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1353,7 +1353,7 @@ int qemuMonitorJSONEjectMedia(qemuMonitorPtr mon, int ret; virJSONValuePtr cmd = qemuMonitorJSONMakeCommand("eject", "s:device", devname, - "i:force", 0, + "b:force", 0,
ACK to both, and pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Luiz Capitulino