[libvirt] [PATCH] qemu: fix a typo on qemuDomainSetBlkioParameters

From: Alex Jia <ajia@redhat.com> It should be a copy-paste error, the result is programming will result in an infinite loop again due to without iterating 'j' variable. * src/qemu/qemu_driver.c: fix a typo on qemuDomainSetBlkioParameters. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=770520 Signed-off-by: Alex Jia <ajia@redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1a7e816..383b2be 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6002,7 +6002,7 @@ static int qemuDomainSetBlkioParameters(virDomainPtr dom, ret = -1; continue; } - for (j = 0; j < ndevices; i++) { + for (j = 0; j < ndevices; j++) { rc = virCgroupSetBlkioDeviceWeight(group, devices[j].path, devices[j].weight); -- 1.7.1

On 01/10/2012 10:55 AM, ajia@redhat.com wrote:
From: Alex Jia<ajia@redhat.com>
It should be a copy-paste error, the result is programming will result in an infinite loop again due to without iterating 'j' variable.
* src/qemu/qemu_driver.c: fix a typo on qemuDomainSetBlkioParameters.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=770520
Signed-off-by: Alex Jia<ajia@redhat.com> ---
ACK && pushed. Peter

On 01/10/2012 02:55 AM, ajia@redhat.com wrote:
From: Alex Jia <ajia@redhat.com>
It should be a copy-paste error, the result is programming will result in an infinite loop again due to without iterating 'j' variable.
How embarrassing - commit 1a3f6608 was supposed to fix just that, but I only got 2 out of the three instances of 'i' on that line. Thanks for cleaning up after me. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (3)
-
ajia@redhat.com
-
Eric Blake
-
Peter Krempa